From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7310C3ABB0 for ; Mon, 5 May 2025 10:02:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PKpVQKr8dLLUpoWrktCT6IWgKKoHWqB8wx1c+ST3NKI=; b=gWe4faWCFQSljUw7AI6rm5C3X2 xfzDVyzrQSdKPZP8m0ZZSv0lBQ3rQ7CXfrBHRhfZadgKM86887+FZ8LqhyEQ4Z8oqGSNkmA1yNgh8 gAk1hHjhcXTExT0Zes0U43f5UlnOfjzqV7s+2Yz9X0NLVkDBFGBh1jhidY6G7kyZtgxCa+pq+lXD0 23YetnMWLBYkzEKRq5cotUE1jZH1hS5eRYr4LqVkJofpM3iMCAgVYZEI7lSrF9VKPurCeIDA1BHDx 1KF4CpC8u0rSjyYOp21gwN4nKpJdRSi6jrlYQvi9OiQHKRNVQ+qA0ZRywmzpgDKmIljT0JxGzrHqo jgjZNr9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uBseC-000000070RJ-3DSq; Mon, 05 May 2025 10:02:04 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uBsa0-00000006zk3-1OjE for linux-arm-kernel@lists.infradead.org; Mon, 05 May 2025 09:57:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746439063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=PKpVQKr8dLLUpoWrktCT6IWgKKoHWqB8wx1c+ST3NKI=; b=LNLgFbr8sC36w0BgPIghfEtqzj36ghx7Qy9tbIJOrps3Tx4sKGU11xlGeg0CWsxfPJHYRH DIW2LBQEvXvBotmblWD7sEUym1J6uJ9mWACrCZCEg7jldsLe8kJVJTwLHXiDEAZVgoJGVn HpkLO5YQdkIGpo2/cVYpZFMZ+C2U7F8= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-655-_WvYvKlaM7ulXOBrN_DNGw-1; Mon, 05 May 2025 05:57:41 -0400 X-MC-Unique: _WvYvKlaM7ulXOBrN_DNGw-1 X-Mimecast-MFC-AGG-ID: _WvYvKlaM7ulXOBrN_DNGw_1746439061 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43d5ca7c86aso24850105e9.0 for ; Mon, 05 May 2025 02:57:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746439060; x=1747043860; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=PKpVQKr8dLLUpoWrktCT6IWgKKoHWqB8wx1c+ST3NKI=; b=pocvMLovsEiKqIV8GxteJ5JNN+aZc48kpym4UVQ89Zo/LoXp30pfq9WTbtnRTwgNit +Mka5gvWY3nfWPmN3+MLZLkmFlH6/IKQJA5PlDrRMEAmrTh5R0CDYIvNypbil19TGAKP HCHIy54F8l8Jh/yvN+3AjNTHJTMNYlCEesd9YhtWvXYZW63litFVYt9ohf5MXf1WV5bc u7vfovvE2sq0FtNpbmHcAIvhkaR12X6IIPE3vJGppuQI9bJQcPcl8pPxD4xHW6AYWU7N Uooloe5jcj5EdghSD7sTyYUFlI4JIdooxfOAjhbqH0de8e5MpRZn6ZqH3BHGUEQZPPQV wAIA== X-Gm-Message-State: AOJu0YxObINNUEW6d9oR1LjqwZPbtfHQk6QwqznvlAiGkXBQdXiu6Yov 0r6ylW04SspfECI0I9K1m/3KZqLQsEE1gpsQn4Mw35cyo1PFq/NiMaH1jhpLXbzAzUkJ8CKtfOQ K0zwi66KHLfHeshC6j/FxxQslbycdUxYWamfurrwbarWNarfOPWXMle1CGa9XX1Plh8yfl2djJG A2yZJPTm+zHg== X-Gm-Gg: ASbGncs03PQO8Sgr+JF7efHONMO18cela+w2/W7o5woMPZy2b6sH9F/OgZ2nAqpEIy9 RuPTWxnTThVVniSlNE545SdZ7Ix/Cqrm0U5YE/AH5d58smteELOywbPB1G3P2HN2s93yl7rOCV0 CZRyaZPzqPYGR2eCazoPxn18AAizE2zxbJlGnR8pycYnMmNdH4IpJFZiOZemm2zEEpcEuBSo2A9 zfdT2jliu8+q+2TKznhQBG1WG45qaeAGGNDH2WXhGCGWlFjhAAoFLUdqo5IWXqIWFtZsW79iTGP UzvurCKUYgCpMaE4yNqvKKLPHHxJOa3f2fg9fCVE3eZfDePF/sXMNvTdjZsVOP2kU3r35OXg3bQ mfaJ7deojWjRldSnny3iqWH4C5LgYeN5ENjZDQ14= X-Received: by 2002:a05:600c:500d:b0:43d:ed:ad07 with SMTP id 5b1f17b1804b1-441bbf3b4b3mr97989785e9.29.1746439060701; Mon, 05 May 2025 02:57:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEtIwxUjQXL2NSzan5novyjnrfpVxfypUeKQ35LMvAEv1T/4y5tjxEbs+pfQSDQVTpPSGypnw== X-Received: by 2002:a05:600c:500d:b0:43d:ed:ad07 with SMTP id 5b1f17b1804b1-441bbf3b4b3mr97989615e9.29.1746439060337; Mon, 05 May 2025 02:57:40 -0700 (PDT) Received: from ?IPV6:2003:cb:c73d:2400:3be1:a856:724c:fd29? (p200300cbc73d24003be1a856724cfd29.dip0.t-ipconnect.de. [2003:cb:c73d:2400:3be1:a856:724c:fd29]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441b2aed5e8sm172833335e9.16.2025.05.05.02.57.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 May 2025 02:57:39 -0700 (PDT) Message-ID: Date: Mon, 5 May 2025 11:57:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v4 3/5] mm/readahead: Make space in struct file_ra_state To: Ryan Roberts , Andrew Morton , "Matthew Wilcox (Oracle)" , Alexander Viro , Christian Brauner , Jan Kara , Dave Chinner , Catalin Marinas , Will Deacon , Kalesh Singh , Zi Yan Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <20250430145920.3748738-1-ryan.roberts@arm.com> <20250430145920.3748738-4-ryan.roberts@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250430145920.3748738-4-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: kDWgCRL-lm3-HPhzrjDPsjCX0ZRca6fKOmI0NhmRalo_1746439061 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250505_025744_464024_FB30CC90 X-CRM114-Status: GOOD ( 12.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 30.04.25 16:59, Ryan Roberts wrote: > We need to be able to store the preferred folio order associated with a > readahead request in the struct file_ra_state so that we can more > accurately increase the order across subsequent readahead requests. But > struct file_ra_state is per-struct file, so we don't really want to > increase it's size. > > mmap_miss is currently 32 bits but it is only counted up to 10 * > MMAP_LOTSAMISS, which is currently defined as 1000. So 16 bits should be > plenty. Redefine it to unsigned short, making room for order as unsigned > short in follow up commit. Makes sense and LGTM Acked-by: David Hildenbrand -- Cheers, David / dhildenb