From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39338C54E94 for ; Wed, 25 Jan 2023 10:03:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4Enob/FjYb/2atWmwMpvPBamWXppPLkmIgecrnwbj2o=; b=GqHZFUIe7yif7o pNU2gd3F4aIK5I1icCiL5ZZGYi4Leend17eFc/LCez7A6pazDPXfNuw8ooqqp9LVFPeO6DPYe33G9 9X58xbBoZL6b1O3uQgMo1tb0WTzNL2YGGtDT412J3bO19lToPRaQHZJZg5gOWz5czKKKraq73wS29 LB5CDYG9aUauGHW6eJgvvviO/vvVgwYqHo2rS8PBz6bCagtnJ7VrMZ476rBN3syBDBBq069CKVH+Z BdXmrNlO2/8dJHu6AXwlZRlqn2CIy1AKqoJImj3aKbzzED+/KH9f9mK5gx2TsTcBY2zUJsK/Wa1Qo T5QOkfKcuEpYHYL+VjXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKcbl-006nNq-BP; Wed, 25 Jan 2023 10:02:22 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKcVv-006l0x-2h for linux-arm-kernel@lists.infradead.org; Wed, 25 Jan 2023 09:56:20 +0000 Received: by mail-wm1-x331.google.com with SMTP id l8so13302409wms.3 for ; Wed, 25 Jan 2023 01:56:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jjtLqh6CEfr4H89H+JyTuRpUhaPVNfu/MoBCL57iE8g=; b=ODOhudb7YsmvAXpdn+8pa/MNOwv5DzADahJDMPProUJMhx1ol0bho1WnV9L0b6k92z krCqkWYW2KLb/0VzSEziwCXotCXFEoV6lTyRqX89u7FfzPWu/cnZ2hO319xZ64VUPbvR qbNuNwd4wmhThS75a0oq1HrGyHmzlM8UFQPt8p6Md8RQDdiyegFanW87dq5eDRtrEFU8 tZqmFdkErGSz1UK4klDRkNF6z+mEzvba1l+6TlHgZLCHBfZfQvsyBoGV7IMZmEmfj4lV 18fq48rpuw66MdMUwCJjvUPj8Iv2KCetGNHyB3yAqS8KM4XfA94pSP2rIXz/wjlg3kfO 5CUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jjtLqh6CEfr4H89H+JyTuRpUhaPVNfu/MoBCL57iE8g=; b=WfZWG4X2gmlvBP8hM1wP7hEG0y65Bbn4Bl+roztDxSLGL2+Q47xoDN8u5ViS9Mi24K rxUFogx59ya596LTszkZ6TGyW1YX2DvbwL7y97JtM34+/CMfXzYuUvxuoSrPnabcw5Hn k75Cwr7VSDa7TW5M9bhNUnGiJg/8Kio6CxpaTrjkT1LJks80TZkjHygx/cL1ozSI02Dh s4Xa1Tl9MSMpKQ2Qi8Mlzf3AIb2qewSkMn09Bw41yQ6/dUeDKJiKPkT3QVvBTQkOkmKl Uqd0kQAaIV/35AJfBAGbSNXAwmXtDYzQKcam6uPW7uo26saJg0bM7ewXe37yil87egdM B4wg== X-Gm-Message-State: AFqh2koPmSss/aKOoHFTjN8MYBE6//odCJnFD0zm1VpnNSqpBsZJ3t23 +20BIVIJ+eiOzPGYf8bllr6SDQ== X-Google-Smtp-Source: AMrXdXvuxRvcIjjVd2E4vmsSXXWrrMRWtGotsY9ODrzQowAqFDQIU1Hx8hv4NITTFxByu8Fu/SDf4Q== X-Received: by 2002:a05:600c:35cf:b0:3d3:49db:d95 with SMTP id r15-20020a05600c35cf00b003d349db0d95mr30676547wmq.37.1674640577575; Wed, 25 Jan 2023 01:56:17 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id e22-20020a05600c439600b003cffd3c3d6csm1322464wmn.12.2023.01.25.01.56.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jan 2023 01:56:17 -0800 (PST) Message-ID: Date: Wed, 25 Jan 2023 10:56:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH 09/15] dt-bindings: serial: add support for Ambarella Content-Language: en-US To: Li Chen Cc: Li Chen , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , "moderated list:ARM/Ambarella SoC support" , "open list:SERIAL DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <20230123073305.149940-1-lchen@ambarella.com> <20230123073305.149940-10-lchen@ambarella.com> <87wn5bgcrv.wl-me@linux.beauty> From: Krzysztof Kozlowski In-Reply-To: <87wn5bgcrv.wl-me@linux.beauty> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230125_015619_198268_DE7980E6 X-CRM114-Status: GOOD ( 16.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 25/01/2023 10:54, Li Chen wrote: > > Hi Krzysztof Kozlowski, > > Sorry for my late reply. > > On Mon, 23 Jan 2023 16:11:52 +0800, > Krzysztof Kozlowski wrote: >> >> On 23/01/2023 08:32, Li Chen wrote: >>> Add compatible for Ambarella. >>> >>> Signed-off-by: Li Chen >>> Change-Id: I32513d98f52af0311dfb55dd5c4739a58f6b9fc1 >>> --- >>> .../bindings/serial/ambarella_uart.yaml | 57 +++++++++++++++++++ >>> MAINTAINERS | 1 + >>> 2 files changed, 58 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/serial/ambarella_uart.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/serial/ambarella_uart.yaml b/Documentation/devicetree/bindings/serial/ambarella_uart.yaml >>> new file mode 100644 >>> index 000000000000..238d68078270 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/serial/ambarella_uart.yaml >>> @@ -0,0 +1,57 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/serial/ambarella_uart.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Ambarella S6LM SoC UART Controller >>> + >>> +maintainers: >>> + - Li Chen >>> + >>> +properties: >>> + compatible: >>> + const: ambarella,uart >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + amb,ignore-fe: >>> + description: | >>> + ignore frame error report for CV2/CV22/CV25/S6LM because it's >>> + checked too strict so that normal stop may be treated as frame error. >> >> Missing type. I don't understand why this is property of DT. > > Ok, I will add "type: boolean" to it. I still do not understand why this is a property of DT. You need to justify it. Otherwise: No. drop it. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel