From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C19B6CD4F26 for ; Tue, 12 May 2026 07:28:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:CC:To: Subject:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0nYwTUDHswJFeRsm/3KU6Cy6V8aaaXNHXn0IsdxK2KM=; b=tubWhi7J6YG8H7K74WEKTIE/ZO GDLR4LHycwzWtKkz6QRUCC8L87np/+QB3sMV0A1ZHXnZKR1y6M+SqSRlZBMZQdCbRAPL498SZA0NR 8PaNmZXqF35itkCAj7OrEZqig4tne/+Q0OHBnlwPjCBr14Dhfs4/qrF3i1K1oK14w6lU3zW2yVtGf KGcwOR965pb1GJKtTc6mPzc6SNjDUnAG1z+hKhh5KxUh0idZRYw7wm6J0NztW/tkwworhOq2aing6 fuc/8GTVWvpSMhMBMZoVRXjx2e6TgLj3d4QxYC1AkwkiYwD7gDorJt2B3ZnlHBSqTTRIy/yp3n1qF 1wDensAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wMhXa-0000000FvST-3bHH; Tue, 12 May 2026 07:28:30 +0000 Received: from canpmsgout10.his.huawei.com ([113.46.200.225]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wMhXW-0000000FvRR-47RK for linux-arm-kernel@lists.infradead.org; Tue, 12 May 2026 07:28:29 +0000 dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=0nYwTUDHswJFeRsm/3KU6Cy6V8aaaXNHXn0IsdxK2KM=; b=jDz5xt+7E9Lxfqur4EwzYh7d4J68ycyVgDFhfjX+3kufj3THHFvpmx0rAgUJs7I3IvBvS/xhN kRmNigPk/3bor01beAWpkIif/AtEHZ2SkATpOewgHbf9yewe0lajQKkW0+LLDeh9Udesbzl1aZw 0kHXJRz4zkGulG4lwkrqlWc= Received: from mail.maildlp.com (unknown [172.19.163.163]) by canpmsgout10.his.huawei.com (SkyGuard) with ESMTPS id 4gF7Kk28hxz1K96d; Tue, 12 May 2026 15:20:42 +0800 (CST) Received: from kwepemk200017.china.huawei.com (unknown [7.202.194.83]) by mail.maildlp.com (Postfix) with ESMTPS id 5A6B34056E; Tue, 12 May 2026 15:28:17 +0800 (CST) Received: from [10.174.178.219] (10.174.178.219) by kwepemk200017.china.huawei.com (7.202.194.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 12 May 2026 15:28:16 +0800 Subject: Re: [PATCH v17 24/24] KVM: selftests: Add guest_memfd testcase to fault-in on !mmap()'d memory To: Sean Christopherson CC: Zenghui Yu , Paolo Bonzini , Marc Zyngier , Oliver Upton , , , , , Ira Weiny , Gavin Shan , Shivank Garg , Vlastimil Babka , Xiaoyao Li , David Hildenbrand , Fuad Tabba , Ackerley Tng , Tao Chan , James Houghton References: <20250729225455.670324-1-seanjc@google.com> <20250729225455.670324-25-seanjc@google.com> <0064952b-048c-455d-ad89-e27e5cb82591@linux.dev> From: Zenghui Yu Message-ID: Date: Tue, 12 May 2026 15:28:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.219] X-ClientProxiedBy: kwepems500002.china.huawei.com (7.221.188.17) To kwepemk200017.china.huawei.com (7.202.194.83) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260512_002827_683835_3A2073C2 X-CRM114-Status: GOOD ( 15.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sean, On 2026/4/18 0:47, Sean Christopherson wrote: > > Does this fix things for you? If so, I'll send a proper patch. > > diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c > index ec7644aae999..c682bda722f9 100644 > --- a/tools/testing/selftests/kvm/guest_memfd_test.c > +++ b/tools/testing/selftests/kvm/guest_memfd_test.c > @@ -510,9 +510,15 @@ static void test_guest_memfd_guest(void) > "Default VM type should support INIT_SHARED, supported flags = 0x%x", > vm_check_cap(vm, KVM_CAP_GUEST_MEMFD_FLAGS)); > > + /* > + * Use the guest's page size for all accesses, e.g. to avoid having to > + * map multiple pages, but create the guest_memfd instance with the max > + * of the host or guest page size, as KVM requires gmem files to be > + * aligned to the host page size. > + */ > size = vm->page_size; > - fd = vm_create_guest_memfd(vm, size, GUEST_MEMFD_FLAG_MMAP | > - GUEST_MEMFD_FLAG_INIT_SHARED); > + fd = vm_create_guest_memfd(vm, max(size, page_size), GUEST_MEMFD_FLAG_MMAP | > + GUEST_MEMFD_FLAG_INIT_SHARED); > vm_set_user_memory_region2(vm, slot, KVM_MEM_GUEST_MEMFD, gpa, size, NULL, fd, 0); > > mem = kvm_mmap(size, PROT_READ | PROT_WRITE, MAP_SHARED, fd); This results in another failure at | vm_set_user_memory_region2(vm, slot, KVM_MEM_GUEST_MEMFD, gpa, size, NULL, fd, 0); # ./guest_memfd_test Random seed: 0x6b8b4567 __vm_create: mode='PA-bits:40, VA-bits:48, 4K pages' type='0', pages='672' ==== Test Assertion Failure ==== lib/kvm_util.c:974: !ret pid=284539 tid=284539 errno=22 - Invalid argument 1 0x00000000004008fb: test_guest_memfd_guest at guest_memfd_test.c:522 2 (inlined by) main at guest_memfd_test.c:561 3 0x0000000000417623: __libc_start_call_main at libc-start.o:? 4 0x000000000041796b: __libc_start_main_impl at ??:? 5 0x0000000000400cef: _start at ??:? KVM_SET_USER_MEMORY_REGION2 failed, errno = 22 (Invalid argument) Thanks, Zenghui