From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89B15C433F5 for ; Sat, 7 May 2022 06:37:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LmG9YnYJln17QZxC/+D9ib/KRstznpzO9k+Uvg/kx+k=; b=GC0vGEPThQDGnP OcP+xLbQXhiBKUXLFlEA+7MDl6L4CtVr1StJNxikGe7xl0i/EBXF5GNCnf+5b9tHjDP/HwJ4bh2B1 3ahmB1/ZsT2rJrAhzsyEXANuT/tJbBqY1RAIhbIXl6cijpYcgOvlGYZpFIy+vTvSI1xWteIqDTVG7 fmXcL/kZzMmRNgGl5MrR+/LnwhO8Z++yC/t7iEe7YLC4PiD1H7xQ0cXGmbblc/+7EHqQmpt++mHf6 7UtNjmRvpBp5cRSXH3ZPNcfgGTXNI4mz0sbHSkfnN3TxhQDd7EbMwpWwP3rKXS0Rdl3mcP7sYRgN7 KQACh/ZeMl63lxC/lNKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nnE2v-006EMS-2u; Sat, 07 May 2022 06:36:05 +0000 Received: from szxga03-in.huawei.com ([45.249.212.189]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nnE2s-006EJw-8j for linux-arm-kernel@lists.infradead.org; Sat, 07 May 2022 06:36:03 +0000 Received: from dggpemm500021.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4KwHd1099KzXdlN; Sat, 7 May 2022 14:31:01 +0800 (CST) Received: from dggpemm500013.china.huawei.com (7.185.36.172) by dggpemm500021.china.huawei.com (7.185.36.109) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 7 May 2022 14:35:44 +0800 Received: from [127.0.0.1] (10.67.108.67) by dggpemm500013.china.huawei.com (7.185.36.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 7 May 2022 14:35:43 +0800 Message-ID: Date: Sat, 7 May 2022 14:35:41 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [RFC PATCH v4 22/37] arm64: kernel: Skip validation of kuser32.o Content-Language: en-US To: Mark Rutland CC: Peter Zijlstra , , , , , , , , , , , , , , , References: <20220429094355.122389-1-chenzhongjin@huawei.com> <20220429094355.122389-23-chenzhongjin@huawei.com> <20220505092448.GE2501@worktop.programming.kicks-ass.net> <51ce37b5-f527-9743-36d3-50247cb0939f@huawei.com> From: Chen Zhongjin In-Reply-To: X-Originating-IP: [10.67.108.67] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500013.china.huawei.com (7.185.36.172) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220506_233602_508434_1056EAD8 X-CRM114-Status: UNSURE ( 9.99 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022/5/6 18:06, Mark Rutland wrote: >> However for my build kuser32.o content is in .text > > We should be able to move that into .rodata; it's never executed in kernel context. > >> and there is only `vdso` symbol in .rodata without `vdso32`. > > That means you're not building with CROSS_COMPILE_COMPAT, and so we can't build > the 32-bit VDSO. > >> And for defconfig the CONFIG_KUSER_HELPERS=y is on. > > Yes. > >> According to your description, it seems something wrong here? > > Sorry, I was wrong about how we linked the kuser32 code. > > I believe we can move that into .rodata by adding: > > .section .rodata > > ... to the start of that. It works. Thanks! > I think that'd be a nice cleanup to do regardless of objtool. > > Thanks, > Mark. > . _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel