From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE7CDC3DA59 for ; Mon, 15 Jul 2024 09:35:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0pBLMxnI/Lx/pzC7lmwf3CjH7RX4rMxZZVizZMZ5Npc=; b=gmZm3RRVv/8vA+cDZYd88+zDt7 JLDvnC9KhvEoT4764vfwQGYOkDcPF3YlN8UpNnirfP8nHvAlErJPuf26w5FkJ1qNUvgeBOzGHrXpO 81i8eXQALUc0AO4F3Tpux07qlvkluxpOcB8ksIPJ5hAb+oB5LQxAO3Q9anfJY/IOKz6TX0MCFUVGW CAUbKyTiDDpH2nSBfyszwzemG9cfarZ675sEzWcC71OTLJqNEENhilrm0Dr7c1dIO2Y63TV+2PFnx I8053fRla2jJ5Ev0fXIoKTXRe7BVY2B7Gqk9pNJNh5SgnuVYvnIOL9y/B6Qj/0cg/B+qoehNwOVj2 /HDVnYEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTI6i-00000006XuG-3f0I; Mon, 15 Jul 2024 09:34:56 +0000 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTI6P-00000006Xoj-05jj for linux-arm-kernel@lists.infradead.org; Mon, 15 Jul 2024 09:34:38 +0000 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-36796a9b636so2482226f8f.2 for ; Mon, 15 Jul 2024 02:34:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721036074; x=1721640874; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0pBLMxnI/Lx/pzC7lmwf3CjH7RX4rMxZZVizZMZ5Npc=; b=WwotjfxcT21OUq0z6ms9YeWraldJ79wh1vW+XZsrKr9Nkd2vIOOImjNOUITJ+TQK/Z moEbckdegKMl4J7qQAE87Ram7MnVqdV7lVtRRjLE2+BcC5lB7WuhQ+0i1moA5QpFB4DZ 5w6TqeivW2BCEhvj9vBriBYcFlDoxLd3ZbAUxlDwm9x9wCnqcu7fDhQLxV1LVS+DgIQE dt8rXrTVJmv4OSk2e7cTGTj9LLgnoa3mEbChfV1ShgjJEDYHBy+hNgxS1qthT1C5I9e9 iVw1JfCpAbVS2LRlod+ZEd2UNsOqv2+fjj1Zap+TB4xUcPpnlspuzJi5HiZ5IPajo0fD ZQSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721036074; x=1721640874; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0pBLMxnI/Lx/pzC7lmwf3CjH7RX4rMxZZVizZMZ5Npc=; b=XcByP9w9EhccvPCRRpaKRMQWZwr50bt+3DpJGRWfShWjEzL2nfBuwTFE4fVqCysu3E hrAb1gHbH+0a1oTsscsAx92dDbXDOvZjDKzeENr9eWfCl/rJAycQz0LN3RzNcE9l9zzU YDmDbTU2JZ1FUt/eeSN8WboZMlbTL/Bwumraxs3+p0E3JdU525cqsp5jypihx1ra891+ iMk6OnrcVanncGoktVz+7eSPDlCIt5N/OyAuN73mcVCqaLiewOE7ihOunMdvo+siPFt1 Byu2cXMYA/FbRFLCmv1SalYZaHdJ65TYL4fJraxqG1GI6zBEYm43PYm5gObRpdHt+ON0 sogw== X-Forwarded-Encrypted: i=1; AJvYcCUKvusNkwizl+YSTiZVBzv31V8YSbw6K8QvIXMv/VCnTa2NAPS6PxOYsMWs7nhegRU3G1jUSccGyO1U71KGchK1bRc/d6kU4Le7Hcjmh/sgAnIYwGc= X-Gm-Message-State: AOJu0YwNT0c3j08HZsiQjbGhh9qv2mvIkxDlVTk/89JBfvz8goTM1Zql FIiqgqkMvS8TZfgzHPyyODZC2akel27qHCanbVl4/AFr3Q28LkJBsgRGGr8VsXw= X-Google-Smtp-Source: AGHT+IEn0oRguKzoHALO8WTiJyKz1z++WLdzSOTZhpRLkl6K6+sEdmmnoP+hRMHpXQODC9ciJT6E3g== X-Received: by 2002:adf:fb86:0:b0:367:434f:ca9a with SMTP id ffacd0b85a97d-367ce5df8d6mr12162537f8f.0.1721036074355; Mon, 15 Jul 2024 02:34:34 -0700 (PDT) Received: from [192.168.1.3] ([89.47.253.130]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36816758620sm3377438f8f.19.2024.07.15.02.34.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jul 2024 02:34:33 -0700 (PDT) Message-ID: Date: Mon, 15 Jul 2024 10:34:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3 00/10] perf tools: Fix test "perf probe of function from different CU" To: Chaitanya S Prakash , linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo , Ian Rogers , Namhyung Kim Cc: anshuman.khandual@arm.com, Josh Poimboeuf , Suzuki K Poulose , Mike Leach , John Garry , Will Deacon , Leo Yan , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Chenyuan Mi , Masami Hiramatsu , Ravi Bangoria , =?UTF-8?Q?Ahelenia_Ziemia=C5=84ska?= , Colin Ian King , Changbin Du , Kan Liang , Athira Rajeev , Tiezhu Yang , Alexey Dobriyan , =?UTF-8?Q?Georg_M=C3=BCller?= , Liam Howlett , bpf@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peter Zijlstra , Ingo Molnar References: <20240601125946.1741414-1-ChaitanyaS.Prakash@arm.com> <65aaf9bb-ab2c-4185-b5bb-22a717ac7e73@arm.com> Content-Language: en-US From: James Clark In-Reply-To: <65aaf9bb-ab2c-4185-b5bb-22a717ac7e73@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240715_023437_100876_E74B9BDB X-CRM114-Status: GOOD ( 26.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/07/2024 8:39 am, Chaitanya S Prakash wrote: > Gentle ping, are there any updates on the string clean up patch set? > > On 6/1/24 18:29, Chaitanya S Prakash wrote: >> From: Chaitanya S Prakash >> >> Perf treated all files beginning with "/tmp/perf-" as a map file despite >> them always ending in ".map", this caused the test "perf probe of >> function from different CU" to fail when Perf was built with NO_DWARF=1. >> As the file was parsed as a map file, the probe...--funcs command output >> garbage values instead of listing the functions in the binary. After >> fixing the issue an additional check to test the output of the >> probe...--funcs command has been added. >> >> Additionally, various functions within the codebase have been refactored >> and restructured. The definition of str_has_suffix() has been adopted >> from tools/bpf/bpftool/gen.c and added to tools/lib/string.c in an >> attempt to make the function more generic. The implementation has been >> retained but the return values have been modified to resemble that of >> str_has_prefix(), i.e., return strlen(suffix) on success and 0 on >> failure. In light of the new addition, "ends_with()", a locally defined >> function used for checking if a string had a given suffix has been >> deleted and str_has_suffix() has replaced its usage. A call to >> strtailcmp() has also been replaced as str_has_suffix() seemed more >> suited for that particular use case. >> >> Finally str_has_prefix() is adopted from the kernel and is added to >> tools/lib/string.c, following which strstarts() is deleted and its use >> has been replaced with str_has_prefix(). >> >> This patch series has been tested on 6.10-rc1 mainline kernel, both on >> arm64 and x86 platforms. >> >> Changes in V3: >> >> - Patch adding configs required by "perf probe of function from different >>    CU" was originally part of the series but has been merged in 6.10-rc1. >> >> https://github.com/torvalds/linux/commit/6b718ac6874c2233b8dec369a8a377d6c5b638e6 >> >> - Restructure patches according to the maintainer trees. >> - Add explanation for why '| grep "foo"' is used. >> - Fix build errors for when perf is built with LLVM=1. >> >> Changes in V2: >> https://lore.kernel.org/all/20240408062230.1949882-1-ChaitanyaS.Prakash@arm.com/ >> >> - Add str_has_suffix() and str_has_prefix() to tools/lib/string.c >> - Delete ends_with() and replace its usage with str_has_suffix() >> - Replace an instance of strtailcmp() with str_has_suffix() >> - Delete strstarts() from tools/include/linux/string.h and replace its >>    usage with str_has_prefix() >> >> Changes in V1: >> https://lore.kernel.org/all/20240220042957.2022391-1-ChaitanyaS.Prakash@arm.com/ >> >> Cc: Josh Poimboeuf >> Cc: Peter Zijlstra >> Cc: Suzuki K Poulose >> Cc: Mike Leach >> Cc: James Clark >> Cc: John Garry >> Cc: Will Deacon >> Cc: Leo Yan >> Cc: Ingo Molnar >> Cc: Arnaldo Carvalho de Melo >> Cc: Namhyung Kim >> Cc: Mark Rutland >> Cc: Alexander Shishkin >> Cc: Jiri Olsa >> Cc: Ian Rogers >> Cc: Adrian Hunter >> Cc: Chenyuan Mi >> Cc: Masami Hiramatsu >> Cc: Ravi Bangoria >> Cc: Ahelenia Ziemiańska >> Cc: Colin Ian King >> Cc: Changbin Du >> Cc: Kan Liang >> Cc: Athira Rajeev >> Cc: Tiezhu Yang >> Cc: Alexey Dobriyan >> Cc: Georg Müller >> Cc: Liam Howlett >> Cc: bpf@vger.kernel.org >> Cc: coresight@lists.linaro.org >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-kernel@vger.kernel.org >> Cc: linux-perf-users@vger.kernel.org >> >> Chaitanya S Prakash (10): >>    tools lib: adopt str_has_suffix() from bpftool/gen.c LGTM, Reviewed-by: James Clark The below commit looked like it could be prone to an off by one error but I debugged it to confirm that it's ok: >>    perf util: Delete ends_with() and replace its use with >>      str_has_suffix() >>    perf util: Replace an instance of strtailcmp() by str_has_suffix() >>    tools lib: Adopt str_has_prefix() from kernel >>    libsubcmd: Replace strstarts() usage with str_has_prefix() >>    objtool: Replace strstarts() usage with str_has_prefix() >>    perf tools: Replace strstarts() usage with str_has_prefix() >>    tools lib: Remove strstarts() as all its usecases have been replaced >>      by str_has_prefix() >>    perf tools: Only treat files as map files when they have the extension >>      .map >>    perf test: Check output of the probe ... --funcs command >> >>   tools/include/linux/string.h                  | 12 ++--- >>   tools/lib/string.c                            | 48 +++++++++++++++++++ >>   tools/lib/subcmd/help.c                       |  2 +- >>   tools/lib/subcmd/parse-options.c              | 18 +++---- >>   tools/objtool/check.c                         |  2 +- >>   tools/perf/arch/arm/util/pmu.c                |  4 +- >>   tools/perf/arch/x86/annotate/instructions.c   | 14 +++--- >>   tools/perf/arch/x86/util/env.c                |  2 +- >>   tools/perf/builtin-c2c.c                      |  4 +- >>   tools/perf/builtin-config.c                   |  2 +- >>   tools/perf/builtin-daemon.c                   |  2 +- >>   tools/perf/builtin-ftrace.c                   |  2 +- >>   tools/perf/builtin-help.c                     |  6 +-- >>   tools/perf/builtin-kmem.c                     |  2 +- >>   tools/perf/builtin-kvm.c                      | 14 +++--- >>   tools/perf/builtin-kwork.c                    | 10 ++-- >>   tools/perf/builtin-lock.c                     |  6 +-- >>   tools/perf/builtin-mem.c                      |  4 +- >>   tools/perf/builtin-sched.c                    |  6 +-- >>   tools/perf/builtin-script.c                   | 30 ++++-------- >>   tools/perf/builtin-stat.c                     |  4 +- >>   tools/perf/builtin-timechart.c                |  2 +- >>   tools/perf/builtin-trace.c                    |  6 +-- >>   tools/perf/perf.c                             | 12 ++--- >>   .../shell/test_uprobe_from_different_cu.sh    |  2 +- >>   tools/perf/tests/symbols.c                    |  2 +- >>   tools/perf/ui/browser.c                       |  2 +- >>   tools/perf/ui/browsers/scripts.c              |  2 +- >>   tools/perf/ui/stdio/hist.c                    |  2 +- >>   tools/perf/util/amd-sample-raw.c              |  4 +- >>   tools/perf/util/annotate.c                    |  2 +- >>   tools/perf/util/callchain.c                   |  2 +- >>   tools/perf/util/config.c                      | 12 ++--- >>   tools/perf/util/map.c                         |  8 ++-- >>   tools/perf/util/pmus.c                        |  2 +- >>   tools/perf/util/probe-event.c                 |  2 +- >>   tools/perf/util/sample-raw.c                  |  2 +- >>   tools/perf/util/symbol-elf.c                  |  4 +- >>   tools/perf/util/symbol.c                      |  3 +- >>   39 files changed, 148 insertions(+), 117 deletions(-) >> >