From: Markus Elfring <Markus.Elfring@web.de>
To: "Alexander A. Klimov" <grandmaster@al2klimov.de>,
linux-actions@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
"Andreas Färber" <afaerber@suse.de>,
"Daniel Lezcano" <daniel.lezcano@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Thomas Gleixner" <tglx@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clocksource/drivers/owl: fix refcount leak
Date: Thu, 21 May 2026 14:10:48 +0200 [thread overview]
Message-ID: <c1aba09f-0a74-485c-b787-59b215a3bd88@web.de> (raw)
In-Reply-To: <20260521041901.542964-1-grandmaster@al2klimov.de>
> Every value returned from of_clk_get() is supposed to be cleaned up
> via clk_put() once not needed anymore.
How do you think about to add a wording like “Thus add a missing function call.”?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.1-rc4#n94
Would the application of another guard become helpful?
How will chances evolve to adjust variable scopes accordingly?
https://elixir.bootlin.com/linux/v7.1-rc4/source/drivers/clocksource/timer-owl.c#L116-L173
Regards,
Markus
next prev parent reply other threads:[~2026-05-21 12:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 4:19 [PATCH] clocksource/drivers/owl: fix refcount leak Alexander A. Klimov
2026-05-21 12:10 ` Markus Elfring [this message]
2026-05-22 18:20 ` Alexander A. Klimov
2026-05-22 19:25 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1aba09f-0a74-485c-b787-59b215a3bd88@web.de \
--to=markus.elfring@web.de \
--cc=afaerber@suse.de \
--cc=daniel.lezcano@kernel.org \
--cc=grandmaster@al2klimov.de \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox