From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA414C43381 for ; Fri, 15 Mar 2019 12:35:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A818D218A1 for ; Fri, 15 Mar 2019 12:35:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WQU+3/CC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A818D218A1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WZy1tOtDqrTL6C/9zpQmpyIhwhV3V4/90kAb7rzjBh4=; b=WQU+3/CCz7SR0B PhDvLaAFu+ipS2CyKalKSuCHoJJlYj86kxvVwjAeWcxIz3PQHk9f8Qizwzcm7iqoSLejR+BIZuNo6 uJR4fc/R4jrBr+sJj/A3G9hyJahK4panewSPzdSX09sWZI4c70b3IZSLHacWYgN6/1m5B1Mziv2kx zdzyCjhb/rpcXBK3zdawsDhvTsAEp7mSleZDPHw1zw29W0pW2MHonVZyOL+8g30nH3eSlAwBZH3NK t7eK5jMEvbFAkHtcSztdZZ6Dmhq0N2y7VtbzTPddwhrju6Gv5g5rEeB3VJL0ZDM/3H4bibbgAZeY2 dC3mL2xvmW1OEUHUPVcw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4m3e-0001u4-FE; Fri, 15 Mar 2019 12:35:30 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4m3Z-0001tF-Db for linux-arm-kernel@lists.infradead.org; Fri, 15 Mar 2019 12:35:27 +0000 Received: from aptenodytes (aaubervilliers-681-1-80-102.w90-88.abo.wanadoo.fr [90.88.22.102]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 57B80240011; Fri, 15 Mar 2019 12:35:16 +0000 (UTC) Message-ID: Subject: Re: [PATCH] ARM: dts: sun8i-h3: Add support for the RerVision H3-DVK board From: Paul Kocialkowski To: Maxime Ripard Date: Fri, 15 Mar 2019 13:35:15 +0100 In-Reply-To: <20190314155011.znrhrxp6jyrxdodt@flea> References: <20190314130656.8010-1-paul.kocialkowski@bootlin.com> <20190314155011.znrhrxp6jyrxdodt@flea> Organization: Bootlin User-Agent: Evolution 3.30.5 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190315_053525_762442_8285576C X-CRM114-Status: GOOD ( 20.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Rob Herring , Thomas Petazzoni , Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Thu, 2019-03-14 at 16:50 +0100, Maxime Ripard wrote: > On Thu, Mar 14, 2019 at 02:06:56PM +0100, Paul Kocialkowski wrote: > > This is an H3-based board that sticks close to the reference design. > > > > Supported features: > > * UART > > * DRAM > > * MMC > > * eMMC > > * Ethernet > > * USB host > > * USB peripheral > > * HDMI > > > > Signed-off-by: Paul Kocialkowski > > --- > > arch/arm/boot/dts/Makefile | 1 + > > arch/arm/boot/dts/sun8i-h3-rervision-dvk.dts | 119 +++++++++++++++++++ > > 2 files changed, 120 insertions(+) > > create mode 100644 arch/arm/boot/dts/sun8i-h3-rervision-dvk.dts > > > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > > index bd40148a15b2..8db275b75214 100644 > > --- a/arch/arm/boot/dts/Makefile > > +++ b/arch/arm/boot/dts/Makefile > > @@ -1078,6 +1078,7 @@ dtb-$(CONFIG_MACH_SUN8I) += \ > > sun8i-h3-orangepi-plus.dtb \ > > sun8i-h3-orangepi-plus2e.dtb \ > > sun8i-h3-orangepi-zero-plus2.dtb \ > > + sun8i-h3-rervision-dvk.dtb \ > > sun8i-r16-bananapi-m2m.dtb \ > > sun8i-r16-nintendo-nes-classic.dtb \ > > sun8i-r16-nintendo-super-nes-classic.dtb \ > > diff --git a/arch/arm/boot/dts/sun8i-h3-rervision-dvk.dts b/arch/arm/boot/dts/sun8i-h3-rervision-dvk.dts > > new file mode 100644 > > index 000000000000..94b71e064eb6 > > --- /dev/null > > +++ b/arch/arm/boot/dts/sun8i-h3-rervision-dvk.dts > > @@ -0,0 +1,119 @@ > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > +/* > > + * Copyright (C) 2019 Bootlin > > + * Author: Paul Kocialkowski > > + */ > > + > > +/dts-v1/; > > +#include "sun8i-h3.dtsi" > > +#include "sunxi-common-regulators.dtsi" > > + > > +#include > > +#include > > + > > +/ { > > + model = "RerVision H3-DVK"; > > + compatible = "rervision,h3-dvk", "allwinner,sun8i-h3"; > > + > > + aliases { > > + ethernet0 = &emac; > > + serial0 = &uart0; > > + }; > > + > > + chosen { > > + stdout-path = "serial0:115200n8"; > > + }; > > + > > + connector { > > + compatible = "hdmi-connector"; > > + type = "a"; > > + > > + port { > > + hdmi_connector_input: endpoint { > > + remote-endpoint = <&hdmi_connector_output>; > > Those are pretty long labels, how would you feel about hdmi_con_in and > hdmi_out_con, as we've used on all the other boards? Sure, let's go with label names that match what is done on other boards! > > +&mmc2_8bit_pins { > > + drive-strength = <40>; > > + bias-pull-up; > > +}; > > bias-pull-up is already set by default, and a 30mA drive strength > should cover what the spec asks for. Did you encounter any issue with > this? You're right, I don't need to set this in particular and the eMMC works just as well with the defaults. Cheers, Paul -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel