From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Ryan Chen <ryan_chen@aspeedtech.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Philipp Zabel <p.zabel@pengutronix.de>,
openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/3] dt-bindings: i2c-ast2600: Add support for AST2600 I2C global controller
Date: Thu, 02 Feb 2023 12:25:26 +0800 [thread overview]
Message-ID: <c227fa62c1040c7c280f1a6559dcf4cf8fb40428.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20230201103359.1742140-2-ryan_chen@aspeedtech.com>
Hi Ryan,
> AST2600 I2C global register controller, add bindings document
> to support driver of i2c global register set.
[...]
> +allOf:
> + - $ref: /schemas/i2c/i2c-controller.yaml#
Are you sure about this? This particular binding doesn't describe the
i2c controller.
> +
> +properties:
> + compatible:
> + enum:
> + - aspeed,ast2600-i2c-global
> +
> + reg:
> + minItems: 1
> + items:
> + - description: address offset and range of bus
> + - description: address offset and range of bus buffer
Seems to be a duplicate here.
Cheers,
Jeremy
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-02 4:27 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 10:33 [PATCH v4 0/3] Add ASPEED AST2600 I2C new controller driver Ryan Chen
2023-02-01 10:33 ` [PATCH v4 1/3] dt-bindings: i2c-ast2600: Add support for AST2600 I2C global controller Ryan Chen
2023-02-02 4:25 ` Jeremy Kerr [this message]
2023-02-02 5:15 ` Ryan Chen
2023-02-02 8:52 ` Krzysztof Kozlowski
2023-02-01 10:33 ` [PATCH v4 2/3] dt-bindings: i2c-ast2600: Add support for AST2600 i2C driver Ryan Chen
2023-02-02 8:55 ` Krzysztof Kozlowski
2023-02-02 8:57 ` Krzysztof Kozlowski
2023-02-15 5:43 ` Ryan Chen
2023-02-15 20:17 ` Krzysztof Kozlowski
2023-02-16 9:20 ` Ryan Chen
2023-02-16 9:22 ` Krzysztof Kozlowski
2023-02-16 9:26 ` Ryan Chen
2023-02-17 8:37 ` Krzysztof Kozlowski
[not found] ` <TYZPR06MB52741EB5CD43327A877CA20FF2A69@TYZPR06MB5274.apcprd06.prod.outlook.com>
2023-02-20 7:59 ` Krzysztof Kozlowski
2023-02-20 9:14 ` Ryan Chen
2023-02-20 10:34 ` Krzysztof Kozlowski
2023-02-16 4:17 ` Dhananjay Phadke
2023-02-16 8:08 ` Krzysztof Kozlowski
2023-02-16 9:17 ` Ryan Chen
2023-02-01 10:33 ` [PATCH v4 3/3] i2c: aspeed: support ast2600 i2c new register mode driver Ryan Chen
2023-02-02 6:04 ` Jeremy Kerr
2023-02-02 9:16 ` Ryan Chen
2023-02-02 9:33 ` Krzysztof Kozlowski
2023-02-02 10:03 ` Ryan Chen
2023-02-14 6:12 ` Ryan Chen
2023-02-14 7:46 ` Krzysztof Kozlowski
2023-02-14 8:57 ` Ryan Chen
2023-02-14 9:32 ` Krzysztof Kozlowski
2023-02-02 8:59 ` Krzysztof Kozlowski
2023-02-02 9:00 ` [PATCH v4 0/3] Add ASPEED AST2600 I2C new controller driver Krzysztof Kozlowski
2023-02-02 9:02 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c227fa62c1040c7c280f1a6559dcf4cf8fb40428.camel@codeconstruct.com.au \
--to=jk@codeconstruct.com.au \
--cc=andrew@aj.id.au \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=ryan_chen@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).