From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Will Deacon <will@kernel.org>, linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: Re: [PATCH] clocksource/drivers/exynos_mct: Fix silly typo resulting in checkpatch warning
Date: Wed, 3 Nov 2021 17:49:32 +0100 [thread overview]
Message-ID: <c22e305e-cf28-9dfe-8354-9d71ee643faf@canonical.com> (raw)
In-Reply-To: <20211103164804.30182-1-will@kernel.org>
On 03/11/2021 17:48, Will Deacon wrote:
> Commit ae460fd9164b ("clocksource/drivers/exynos_mct: Prioritise Arm
> arch timer on arm64") changed the rating of the MCT clockevents device
> to be lower than the Arm architected timer and, in the process, replaced
> a semicolon with a comma thanks to a silly copy-paste error.
>
> Put the semicolon back so that the code looks more idiomatic and resolve
> the SUSPECT_COMMA_SEMICOLON warning from checkpatch at the same time.
>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Signed-off-by: Will Deacon <will@kernel.org>
> ---
>
> Although this doesn't have a functional impact and I'd normally not pay
> too much attention to checkpatch warnings, the code is pretty weird as-is
> and I didn't intend for that comma to be there!
>
> drivers/clocksource/exynos_mct.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-11-03 16:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 16:48 [PATCH] clocksource/drivers/exynos_mct: Fix silly typo resulting in checkpatch warning Will Deacon
2021-11-03 16:49 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c22e305e-cf28-9dfe-8354-9d71ee643faf@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox