From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1B3ADEB64D8 for ; Fri, 16 Jun 2023 11:40:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sDjAw4i23de7cAai5QSsQRvQ93OeKtp80ZnSjDwn/zQ=; b=fXdXe0dWvV3+8p qXgO51coksRkuFy/8mm2PWBdnapURKYQ/ismoBpE6RSPZfc0XN/tlJ0nycCCNKZNulAwphK1Rk6Om 10m1xALrWQYC19/GwxQWc2c+UNE8B8zr/ZXeSOlyYaEvWzJ+mYYb55n677E5R+b3oLfHf87PXxjX6 6zqrWIkYS2nD4gGHZcbMDlrOqPg5aTqsti+R2wgOO9paQppYEyHlraFgcY+zr36d/lcd1z2FtWfL2 M3semSzNVz7/fVAF1xleBB6XxZ4nPTkL4KNh9AY7uA0jEL67B8VduWK3XgOySxenqTYabGEMZ2056 iYVkedIOPkCZBQSpm5Mg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qA7nu-000Pma-2W; Fri, 16 Jun 2023 11:39:46 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qA7nr-000Pld-0Y for linux-arm-kernel@lists.infradead.org; Fri, 16 Jun 2023 11:39:45 +0000 Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-98377c5d53eso82548566b.0 for ; Fri, 16 Jun 2023 04:39:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686915581; x=1689507581; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aqBe1Ld+4yX8XBJIVvbQoAD/S8ybcl184LNQsljKFsA=; b=A7U3VltIT686Wpl3bdGE/23F9FQo8ptkUXR3cOqDHMT3q2KVnuexPS6Kbo2y5KMOSF xwcWA9N6GslFuYaB6sYUxjc6YulcqNnggw1xQr0af8PPR20w1mRMK0bFLbfinMvdVTFx rx14YG3npkm+PKE0AY6l5APxfN+gMxQo0o8azP1Kuniv7BhPly98uBOYg6VlDEBQmdjd n+KgBQjDaFWPOOqBELCsSTqRfIjacjBDHkd/YkR+q9ksoD/jAXnvAVIGzhwzrvFpvYvX nH+d0FVIu5Ah/QCME8RtJhEvWKJChzFHCVCHITaZMXyTmTK2AkZMFOKBBVtcQ0D4hDug IcLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686915581; x=1689507581; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aqBe1Ld+4yX8XBJIVvbQoAD/S8ybcl184LNQsljKFsA=; b=ia6jNg7jw8QNwV3aN+d755eo59wX96XAXlC1CYqMyOjRiEDJNiyTDkmULZ8MsjiGCe 5j4NuVtN+FntuKrBx5iXCxUu4mJNfzNaPBVY0UO+9RIFvO4Grt+LaPBvFI6XY00df+pr 2xitO51E0Ath7/aE8zkhGJefpxkW2OYFi0l+TnPLWJRQAGzqY0tAT5qPP+LWzYtkrhbZ C1g3xcyLslbuZX/JTuBnNyS/KoMoWvafHHw9wARqXtvZGx526R6kOJKDvScmn/ecpE7o IsZet0szLmCZP/cnxvGbUr4GtgisfGMhkWhLmYmFP3qKILofcaXHq1QMO9H8Zf+eCd+p nxuQ== X-Gm-Message-State: AC+VfDxt0CJLofqS0P6wH1EKnG5FKdNWto+CBEz/NLpLMI9lkOflunAd Qqa3crIDj4ZUVLeQ6djdKmIAOw== X-Google-Smtp-Source: ACHHUZ4Ytjnsly62llDfkxacpRktKqwfSAt3dv08j/wlwMsJ6HyQinXjlHec9+jtqJ9mTP68qWBR+g== X-Received: by 2002:a17:907:7e90:b0:974:6335:4239 with SMTP id qb16-20020a1709077e9000b0097463354239mr1636560ejc.34.1686915580716; Fri, 16 Jun 2023 04:39:40 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id lx15-20020a170906af0f00b009837806ae2fsm1137144ejb.78.2023.06.16.04.39.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Jun 2023 04:39:40 -0700 (PDT) Message-ID: Date: Fri, 16 Jun 2023 13:39:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 3/3] arm64: dts: freescale: Add support for LX2162 SoM & Clearfog Board Content-Language: en-US To: Josua Mayer , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Li Yang References: <20230616110610.32173-1-josua@solid-run.com> <20230616110610.32173-4-josua@solid-run.com> From: Krzysztof Kozlowski In-Reply-To: <20230616110610.32173-4-josua@solid-run.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230616_043943_213030_E50A3113 X-CRM114-Status: GOOD ( 18.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/06/2023 13:06, Josua Mayer wrote: > Add support for the SolidRun LX2162A System on Module (SoM), and the > Clearfog evaluation board. > > The SoM has few software-controllable features: > - AR8035 Ethernet PHY > - eMMC > - SPI Flash > - fan controller > - various eeproms > Thank you for your patch. There is something to discuss/improve. > + > +&i2c2 { > + /* retimer: ds250df410@18 */ > + > + i2c-switch@70 { > + compatible = "nxp,pca9546"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x70>; reg is usually just after compatible. ... > + > +&emdio1 { > + /* > + * SoM has a phy at address 1 connected to SoC Ethernet Controller 1. > + * It competes for WRIOP MAC17, and no connector has been wired. > + */ > + /delete-node/ ethernet-phy@1; > + > + ethernet_phy0: mv88e2580@8 { Node names should be generic. See also explanation and list of examples in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + reg = <8>; > + compatible = "ethernet-phy-ieee802.3-c45"; > + max-speed = <1000>; > + }; > + > + ethernet_phy1: mv88e2580@9 { > + reg = <9>; > + compatible = "ethernet-phy-ieee802.3-c45"; > + max-speed = <1000>; > + }; > + > + ethernet_phy2: mv88e2580@a { > + reg = <10>; > + compatible = "ethernet-phy-ieee802.3-c45"; > + max-speed = <1000>; > + }; > + > + ethernet_phy3: mv88e2580@b { > + reg = <11>; > + compatible = "ethernet-phy-ieee802.3-c45"; > + max-speed = <1000>; > + }; > + > + ethernet_phy4: mv88e2580@c { > + reg = <12>; > + compatible = "ethernet-phy-ieee802.3-c45"; > + max-speed = <1000>; > + }; > + > + ethernet_phy5: mv88e2580@d { > + reg = <13>; > + compatible = "ethernet-phy-ieee802.3-c45"; > + max-speed = <1000>; > + }; > + > + ethernet_phy6: mv88e2580@e { > + reg = <14>; > + compatible = "ethernet-phy-ieee802.3-c45"; > + max-speed = <1000>; > + }; > + > + ethernet_phy7: mv88e2580@f { > + reg = <15>; > + compatible = "ethernet-phy-ieee802.3-c45"; > + max-speed = <1000>; > + }; > +}; > + > +&esdhc0 { > + status = "okay"; > + sd-uhs-sdr104; > + sd-uhs-sdr50; > + sd-uhs-sdr25; > + sd-uhs-sdr12; > +}; > + > +&pcie3 { > + status = "disabled"; > +}; > + > +&pcie4 { > + status = "disabled"; > +}; > + > +&pcs_mdio3 { > + status = "okay"; > +}; > + > +&pcs_mdio4 { > + status = "okay"; > +}; > + > +&pcs_mdio5 { > + status = "okay"; > +}; > + > +&pcs_mdio6 { > + status = "okay"; > +}; > + > +&pcs_mdio11 { > + status = "okay"; > +}; > + > +&pcs_mdio12 { > + status = "okay"; > +}; > + > +&pcs_mdio13 { > + status = "okay"; > +}; > + > +&pcs_mdio14 { > + status = "okay"; > +}; > + > +&pcs_mdio15 { > + status = "okay"; > +}; > + > +&pcs_mdio16 { > + status = "okay"; > +}; > + > +&pcs_mdio17 { > + status = "okay"; > +}; > + > +&pcs_mdio18 { > + status = "okay"; > +}; > + > +&serdes_1 { > + status = "okay"; > +}; > + > +&serdes_2 { > + status = "okay"; > +}; > + > +&uart0 { > + status = "okay"; > +}; > + > +&usb0 { > + status = "okay"; > +}; > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi > new file mode 100644 > index 000000000000..49e03b6600d6 > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi > @@ -0,0 +1,78 @@ > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > +// > +// Device Tree file for LX2162A-SOM > +// > +// Copyright 2021 Rabeeh Khoury > +// Copyright 2023 Josua Mayer > + > +&crypto { > + status = "okay"; > +}; > + > +&dpmac17 { > + phy-handle = <ðernet_phy0>; > + phy-connection-type = "rgmii-id"; > +}; > + > +&emdio1 { > + status = "okay"; > + > + ethernet_phy0: ethernet-phy@1 { > + reg = <1>; > + }; > +}; > + > +&esdhc1 { > + status = "okay"; > + bus-width = <8>; > + mmc-hs200-1_8v; > + mmc-hs400-1_8v; > +}; > + > +&fspi { > + status = "okay"; > + > + flash@0 { > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "m25p80", "jedec,spi-nor"; > + m25p,fast-read; > + spi-max-frequency = <50000000>; > + reg = <0>; Fix the order of properties. compatible is always first, then the reg. > + /* The following setting enables 1-1-8 (CMD-ADDR-DATA) mode */ > + spi-rx-bus-width = <8>; > + // spi-tx-bus-width = <8>; Don't add dead code without appropriate comment why it is dead. > + }; > +}; > + > +&i2c0 { > + status = "okay"; > + > + fan-controller@18 { > + compatible = "ti,amc6821"; > + reg = <0x18>; > + cooling-min-state = <0>; > + cooling-max-state = <9>; > + #cooling-cells = <2>; > + }; > + > + ddr_spd: eeprom@51 { > + reg = <0x57>; > + compatible = "st,24c02", "atmel,24c02"; Ditto > + read-only; > + }; > + > + config_eeprom: eeprom@57 { > + reg = <0x57>; > + compatible = "st,24c02", "atmel,24c02"; Ditto > + }; > +}; > + > +&i2c4 { > + status = "okay"; > + > + variable_eeprom: eeprom@54 { > + reg = <0x54>; > + compatible = "st,24c2048", "atmel,24c2048"; ditto > + }; > +}; Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel