From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19577C433F5 for ; Wed, 2 Feb 2022 13:48:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FRIB7MFGoi83N9VZiOEu4g5Ogfv2PNlfKzEN3GTB2/U=; b=kZyJu2f9r5R/+x MMBrOGGHEXcQjTWQ1+SysZznJyper/uKkoVYGqAaeBqlD25E3ulPL3Z1jCMmR2BZNPKHVFntdXJn7 NE5DYi7DuQHcFchxsnCDiJ8Z1KzYNkmQ7HnjfJkpU/O9P1l2o49WzAv4s4DEI5zSPCGlVhZ5yBIRX KBEOxcOtQP5dGPs8lUQyMkN6DUDMwbsLwn+6dULAu0Tp2I9qLfaIYOQCamBQAA4AJUwxYgFgXHMmt w2mNoam2aVj2J6/nHJkePeAyv8AxEcxa4A88Mw/2WUTnIZWEAPtqi66zqywAjgLmW/07LjQNKEWop 3RTrdf/Kvw2MKDTL/cYA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nFFxS-00FNyt-NM; Wed, 02 Feb 2022 13:46:02 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nFFxN-00FNwk-Cu for linux-arm-kernel@lists.infradead.org; Wed, 02 Feb 2022 13:45:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643809554; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YxruncnGKSYEtQADjLUNkNWhCcGBbzpK2sbDwkeQUpo=; b=RoxsWcT/93u1UTHWUfdPuRjCGwhDikGNumfAdBMKu6esMIdExq1J6zYN9PQ75UJZ1W+1ba kw0spbYYiD546kTHSwmwpsazHbnGXf67tdHnZTLvFleXzVl9sSGoWLVMuXpEP5XHMcyFix SOXpjgBRqM3yAph0odVCFHvzSFBh9Gs= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-203-HIfmBDOqNCq4K80nbchPaw-1; Wed, 02 Feb 2022 08:45:54 -0500 X-MC-Unique: HIfmBDOqNCq4K80nbchPaw-1 Received: by mail-ej1-f71.google.com with SMTP id d7-20020a1709061f4700b006bbf73a7becso4556087ejk.17 for ; Wed, 02 Feb 2022 05:45:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=YxruncnGKSYEtQADjLUNkNWhCcGBbzpK2sbDwkeQUpo=; b=50RzvM4bqSXq2lae0kw32DHV7rqTQpurwk/RgUnskxulTMM3JTRPdzjhKXq6LxCAcn 1mQVnFL42ol6HAJZFqA9kHBXDkQ+tAHj/IV1zler7ngtb9mvwUtJ0WLFdCbUn2irv+BH Zx7rnIuIth0cRaSewB01wBUptoXjoYeq8eE1fciD7ZcQ5zv/BYruH8Tc1JlymWR2pJo6 ruXOenFUA0DI+qOz4wTjjWUz4PqfpOrXGmEHftkIhIrDEPRRcrELIJZYipRK1HuSoxSH 0TJgoztetxDCv5Ll43aseK0jKAavTbCXHJ56eLRerDy1KVXC5iEn4ZjVaBgxs+lMnTAb nK5w== X-Gm-Message-State: AOAM530g/H/FilnkRUHqgIButpSBHw4kfIDZkjQQuUUxsFXxII78oKMD OkzYhxicQT1G1Zwzs9zbMbdi6V2k9c9G3OeZeleo1yZk7FqCMWmy+HB4fOlkdUDFSGF79xzIYb4 VRWGcc8UTuhTozeHGxxq9eYyZujPXkQhdfsQ= X-Received: by 2002:a05:6402:5248:: with SMTP id t8mr30084278edd.14.1643809552853; Wed, 02 Feb 2022 05:45:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJxqE4L2UK0676VaeKIuCkwGMt3tw/zzsCSLR83dbtSZbWUp25WGEt3s5690JhdDTieh82ha0w== X-Received: by 2002:a05:6402:5248:: with SMTP id t8mr30084241edd.14.1643809552570; Wed, 02 Feb 2022 05:45:52 -0800 (PST) Received: from ?IPV6:2003:cb:c709:f800:a55c:e484:3cd9:3632? (p200300cbc709f800a55ce4843cd93632.dip0.t-ipconnect.de. [2003:cb:c709:f800:a55c:e484:3cd9:3632]) by smtp.gmail.com with ESMTPSA id z8sm15746580ejc.151.2022.02.02.05.45.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Feb 2022 05:45:52 -0800 (PST) Message-ID: Date: Wed, 2 Feb 2022 14:45:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH RFC v1] drivers/base/node: consolidate node device subsystem initialization in node_dev_init() To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , Greg Kroah-Hartman , Michal Hocko , Oscar Salvador , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Yoshinori Sato , Rich Felker , "David S. Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "Rafael J. Wysocki" , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org References: <20220128151540.164759-1-david@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220128151540.164759-1-david@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220202_054557_542629_BEF8F61E X-CRM114-Status: GOOD ( 21.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28.01.22 16:15, David Hildenbrand wrote: > ... and call node_dev_init() after memory_dev_init() from driver_init(), > so before any of the existing arch/subsys calls. All online nodes should > be known at that point. > > This is in line with memory_dev_init(), which initializes the memory > device subsystem and creates all memory block devices. > > Similar to memory_dev_init(), panic() if anything goes wrong, we don't > want to continue with such basic initialization errors. > > The important part is that node_dev_init() gets called after > memory_dev_init() and after cpu_dev_init(), but before any of the > relevant archs call register_cpu() to register the new cpu device under > the node device. The latter should be the case for the current users > of topology_init(). > > Cc: Andrew Morton > Cc: Greg Kroah-Hartman > Cc: Michal Hocko > Cc: Oscar Salvador > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Thomas Bogendoerfer > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Paul Walmsley > Cc: Palmer Dabbelt > Cc: Albert Ou > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Yoshinori Sato > Cc: Rich Felker > Cc: "David S. Miller" > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: "Rafael J. Wysocki" > Cc: x86@kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-ia64@vger.kernel.org > Cc: linux-mips@vger.kernel.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-riscv@lists.infradead.org > Cc: linux-s390@vger.kernel.org > Cc: linux-sh@vger.kernel.org > Cc: sparclinux@vger.kernel.org > Cc: linux-mm@kvack.org > Signed-off-by: David Hildenbrand If there are no further comments, then I'll resend as !RFC with a slightly extended patch description, testing at least under arm64 and ppc64 as they are relatively easy to test for me. -- Thanks, David / dhildenb _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel