From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71000C43381 for ; Mon, 25 Mar 2019 09:29:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E5692085A for ; Mon, 25 Mar 2019 09:29:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lasK+4UI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E5692085A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=i2se.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=G5mkPU4yIJe6vx16IGuM6srRRJ58GskATL5fzmnm2LM=; b=lasK+4UIhSnzK5V6lROyinQSlp HRUHZTlpBRpe6nKsbdngVHkVSLkn9ERIRRyMLgtLfjre4RB/Biv5fY6rkpf8SowUs8l175P3aJ+rK g/WnSslAjo1BzmuVBXtAHtlsVU3qcpwQjGYdgEzIzcmr34rMrcrRVBvBIx7PxP9ADjMbp5Cs1SMXl +oEcobvRpigqncbgpIzOVyCJ8Iq2/ohdGdZiw3rx1BaeRvGKzxmCdLsbv6H9NMIP8bVCpnxCv6SOn eRPSEMQBwpf6Cqe6so1vVK+ZkvpZAmrDrZPnax9+cZv5oBVTDGU/BHl+IFxDeTEq+7t4Qxaq8me/S xlQP+1KQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8Luf-0004ou-9b; Mon, 25 Mar 2019 09:29:01 +0000 Received: from mout.kundenserver.de ([212.227.126.131]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8LuW-0004kw-Ei; Mon, 25 Mar 2019 09:28:58 +0000 Received: from [192.168.178.52] ([109.104.40.77]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1M3VAI-1h8tsC0ONG-000fei; Mon, 25 Mar 2019 10:28:46 +0100 Subject: Re: [PATCH V2 8/9] spi: bcm2835aux: add driver stats to debugfs To: kernel@martin.sperl.org, Mark Brown , Eric Anholt , Hubert Denkmair , linux-spi@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org References: <20190324175002.28969-1-kernel@martin.sperl.org> <20190324175002.28969-9-kernel@martin.sperl.org> From: Stefan Wahren Message-ID: Date: Mon, 25 Mar 2019 10:28:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190324175002.28969-9-kernel@martin.sperl.org> Content-Language: en-US X-Provags-ID: V03:K1:vl957xKfKboaHuD72jYbRr9stgy6RJicojlvODbJGrAULol4RAy k6onaImFdKRPHASiI3C044nGLLuwpylN9tODaEXDvR4AWlDBKHHC9W3xcLxz5WGgTGkTaJz NwlbunWSiz8tg3QH/qTrVy72DwPVjhDwtcCJp7QVojS3wu9NVO5Gmrj+VCS/7GVb1SJzBdw Ty0lCF3Q4NlGM7mHqeP3A== X-UI-Out-Filterresults: notjunk:1;V03:K0:gVGSmXAkmso=:/AXl6uC0Zqp3PddRNYq+9c 5OFDIhm7hnh0ajfXQJ6i0TpjHq7h4BeXWm6C2arzoA+3/qT7HXevVBjp5vdMmOcYTStlA+1sI zl1jbfYcfvAvuA9JumdSV9e6YotspHog0yrr8O2w/yxmlMhehoUAWQk7OiGUkBplIeitn9ZtY /SFx5h0gOSIJmpzerRXjw4yvBdVmAeHC3lt5+nWSL32+MgEvJo0A3DvZxEQiHhKvlPCF2NLkz YMtjuXIgNj95Ts4XWRECX6EocB4/OdK7nhKw7nbbK3O/NJogxg2aZfKlRfpAxRRuvqazpGsYx p83BGgzmKYm1RWpH98qFv9tJRtTgzKtZL5GoLV+bAGY0Q1GJ0HcanDJiR5qCB/0suAW+gnn+t +hb2vfVOXJ8T/iw3XCFl2oH71DXSPBfy6+DPJCRePXZdZY2WugGcJ7F8kl5aOTY5FbnpMGx5J TTm8YEX/LIqU2k6EM64mMeCjfBt2csOEtq4CU/ZeKlQzREDtBVIribxdimiUUnDZcrs6KzgTM IxyYLAUOpXK/F2blsDFfY8G0KuiC/TF1ob3cJcCXAcEigOE3lOFlmMlTGXTRAK60bCPZl8qKo 69CiV+eEbYrdfR8FLyqijHQgh2Tup0d4bgydiWVw5Ma44XuWRu/v1yx0+fGSxJKi5xVOM513l 23x/s37mVXGVOIYjsMDOdm9tJVEIkAxZ9C3fl+95oWyTkhM8C1tMvJbPDfO0r6s/y9GGK8HoZ NNzgXo+m4LM9jy8+JJtVXRvslZVB0fgMOGYonqTQmdeQx0bjG7lhA5/Q4d4= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190325_022852_795214_4806608F X-CRM114-Status: GOOD ( 13.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Martin, Am 24.03.19 um 18:50 schrieb kernel@martin.sperl.org: > From: Martin Sperl > > To estimate efficiency add statistics on transfer types > (polling and interrupt) used to debugfs. > > Signed-off-by: Martin Sperl > --- > drivers/spi/spi-bcm2835aux.c | 61 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 61 insertions(+) > > diff --git a/drivers/spi/spi-bcm2835aux.c b/drivers/spi/spi-bcm2835aux.c > index dd0446968da6..d2b58060b333 100644 > --- a/drivers/spi/spi-bcm2835aux.c > +++ b/drivers/spi/spi-bcm2835aux.c > @@ -21,6 +21,7 @@ > > #include > #include > +#include > #include > #include > #include > @@ -102,8 +103,57 @@ struct bcm2835aux_spi { > int tx_len; > int rx_len; > int pending; > + > +#if defined(CONFIG_DEBUG_FS) > +#define BCM2835_AUX_INCR(field) ((field)++) > + u64 count_transfer_polling; > + u64 count_transfer_irq; > + u64 count_transfer_irq_after_poll; > + > + struct dentry *debugfs_dir; > +#else > +#define BCM2835_AUX_INCR(field) > +#endif /* CONFIG_DEBUG_FS */ > }; > is there a chance to avoid these ifdefs CONFIG_DEBUG_FS? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel