Re: [PATCH v4 8/8] arm64: dts: amlogic: t7: khadas-vim4: Add fan cooling to thermal zones

[Neil Armstrong <neil.armstrong@linaro.org>]

On 4/23/26 18:07, Ronald Claveau via B4 Relay wrote:
> From: Ronald Claveau <linux-kernel-dev@aliel.fr>
> 
> Add an active trip at 50°C to all six thermal zones and map it to the
> khadas_mcu fan controller, using cooling states 30 to 100.
> 
> Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>
> ---
>   .../dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts  | 102 +++++++++++++++++++++
>   1 file changed, 102 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts
> index 5d7f5390f3a66..ba9219073dd0a 100644
> --- a/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts
> +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts
> @@ -157,6 +157,74 @@ wifi32k: wifi32k {
>   	};
>   };
>   
> +&a53_thermal {
> +	trips {
> +		a53_active: a53-active {
> +			temperature = <50000>; /* millicelsius */
> +			hysteresis = <2000>; /* millicelsius */
> +			type = "active";
> +		};
> +	};
> +
> +	cooling-maps {
> +		map {
> +			trip = <&a53_active>;
> +			cooling-device = <&khadas_mcu 30 100>;
> +		};
> +	};
> +};
> +
> +&a73_thermal {
> +	trips {
> +		a73_active: a73-active {
> +			temperature = <50000>; /* millicelsius */
> +			hysteresis = <2000>; /* millicelsius */
> +			type = "active";
> +		};
> +	};
> +
> +	cooling-maps {
> +		map {
> +			trip = <&a73_active>;
> +			cooling-device = <&khadas_mcu 30 100>;
> +		};
> +	};
> +};
> +
> +&gpu_thermal {
> +	trips {
> +		gpu_active: gpu-active {
> +			temperature = <50000>; /* millicelsius */
> +			hysteresis = <2000>; /* millicelsius */
> +			type = "active";
> +		};
> +	};
> +
> +	cooling-maps {
> +		map {
> +			trip = <&gpu_active>;
> +			cooling-device = <&khadas_mcu 30 100>;
> +		};
> +	};
> +};
> +
> +&hevc_thermal {
> +	trips {
> +		hevc_active: hevc-active {
> +			temperature = <50000>; /* millicelsius */
> +			hysteresis = <2000>; /* millicelsius */
> +			type = "active";
> +		};
> +	};
> +
> +	cooling-maps {
> +		map {
> +			trip = <&hevc_active>;
> +			cooling-device = <&khadas_mcu 30 100>;
> +		};
> +	};
> +};
> +
>   &i2c_m_ao_a {
>   	status = "okay";
>   	pinctrl-0 = <&i2c0_ao_d_pins>;
> @@ -170,6 +238,23 @@ khadas_mcu: system-controller@18 {
>   	};
>   };
>   
> +&nna_thermal {
> +	trips {
> +		nna_active: nna-active {
> +			temperature = <50000>; /* millicelsius */
> +			hysteresis = <2000>; /* millicelsius */
> +			type = "active";
> +		};
> +	};
> +
> +	cooling-maps {
> +		map {
> +			trip = <&nna_active>;
> +			cooling-device = <&khadas_mcu 30 100>;
> +		};
> +	};
> +};
> +
>   &pwm_ab {
>   	status = "okay";
>   	pinctrl-0 = <&pwm_a_pins>;
> @@ -266,3 +351,20 @@ &uart_a {
>   	clocks = <&xtal>, <&xtal>, <&xtal>;
>   	clock-names = "xtal", "pclk", "baud";
>   };
> +
> +&vpu_thermal {
> +	trips {
> +		vpu_active: vpu-active {
> +			temperature = <50000>; /* millicelsius */
> +			hysteresis = <2000>; /* millicelsius */
> +			type = "active";
> +		};
> +	};
> +
> +	cooling-maps {
> +		map {
> +			trip = <&vpu_active>;
> +			cooling-device = <&khadas_mcu 30 100>;
> +		};
> +	};
> +};
> 

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil