From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46BFBC4829B for ; Mon, 12 Feb 2024 12:14:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t84lSUr8ZbbLFvTOsQbahPoMGxh2wM0XqeIxtV7J1Dw=; b=Wlu1Y3mqN/F3is nt674Ss8V8n74jMEXwxhUlJdcOcs0cvUF8nLRX65N/aEqj7HZirPhHDMlE6CfCa9c/so8YNTOTZD5 gi1WGDvz6s11znHgh8rBrdLcAZszCaDsGgx0IcjBCL7tnNeWJcCuRse6nda4CdDFnTUK2T8725/6L i+FI9Y7RyEOx47kZrRL9qHM46Rmjb6jZiGqv3VpCa7CbbybpwYVuZFRwUMpDmqlbPy+zX7VeRH00X iMllkkRHDGAQmzPYLTFWMFcG6g9B/5B8YE9dTJNwIgOy4ofWUWrhuC48NQiuw+M7o8mHI5uGLzc0E sIO7q+rnSDj+r0rbgR2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZVCl-00000005E3U-0B8k; Mon, 12 Feb 2024 12:14:35 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZVCg-00000005E0v-40fI for linux-arm-kernel@lists.infradead.org; Mon, 12 Feb 2024 12:14:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707740069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=pFmZN5D+FLkUR/TqfEmtJ0sttF3Ny0Zc/N855oN1DmU=; b=Fabt8eKfDWzkjCY0X4W+Z8bzH/0MoRiSO4WjJYqPEnu1qeE7ruMlC3gc733fp/73VrwTuA pD26lxCpxgwtalmpTVBKNihp7xs0hoIOiYHX934dMslBeb8DJaECGg2kC1SxEDp9gMNHEp Ht79Ase/8UGaGBAdXfUwTFnrra/sZCY= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-97-1jaDHmkXMomQC3FvHi31cg-1; Mon, 12 Feb 2024 07:14:27 -0500 X-MC-Unique: 1jaDHmkXMomQC3FvHi31cg-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-51176e89e21so2314514e87.1 for ; Mon, 12 Feb 2024 04:14:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707740065; x=1708344865; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pFmZN5D+FLkUR/TqfEmtJ0sttF3Ny0Zc/N855oN1DmU=; b=RKJC03x+n+wvzrqqvvhPpiMskvOaryv8HmUuWEw0v7Skl0oXxNDtWPjDyHPtHmiPU6 7gdHWA2x/z69Iy4Rs5Of03YULe3MEjTb4rEoLBTtJW8+tpk6dQFn/P3bWy4qQH66VtY7 3xxX7sieARO4N4c4HmdzxB7N5j4mE6DUYpIXP37o8DWkDdjAocy2hI4Ih+Ip2jbEGvYa VmLZLfGyFcVDKFNgozBxO7WlGaeQl6ew8FPuKpG1I8iUaInnr8jn9RI6MW7Z28J4FWWb 7ifPNUwrrOyH/0yM5o2wahyOTcKWaLRet/AKqg3b5O3t/Af94buzSBUw9dFFJgYIrkAl kzZg== X-Gm-Message-State: AOJu0Yw3fwLM6CDUYc0meUdH/8HLIDnsLskmMykEM6Quq8lp63m7OuCq q4lW7toW1it/8mVfECeh70dgtPfH4pHEuCESLTeIPMHhikbZxvbtEjozUWDlvZjhoRJdy86HdUF A/pSTDS4XoKWOiZjNODX149VYSx8Egf6naLQ/DkB56fr6NKzdR/t4AX63g/5HoZgiMcc6EF3P X-Received: by 2002:a05:6512:39c9:b0:511:751c:7e8f with SMTP id k9-20020a05651239c900b00511751c7e8fmr4678241lfu.20.1707740065660; Mon, 12 Feb 2024 04:14:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IEfvRMFMBzLv20u7RK1sffSKRqvL876q4EvpSF1avR8GYZmBmJqkptYtg77nabHSr6SBVyRxw== X-Received: by 2002:a05:6512:39c9:b0:511:751c:7e8f with SMTP id k9-20020a05651239c900b00511751c7e8fmr4678188lfu.20.1707740065123; Mon, 12 Feb 2024 04:14:25 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWin1JcrzkSHrzXWn9NgERU1bRLCGCJmSYsfWUE1Od2oRRe6X1Bvd7ng1cs1dC1WVKDTfFn08/VMnSZDG0Mvx2X9Det59j0bGx41Nv6uj4UY71dgUvdLRhV/SLXp8xFc/1teR4RCtNkBRrYFgWZNNxvmID3326dbEcsOqwzumRnQSASEI0wYBi3PEBSNoStgvtbyNeWpzzBlvqkYjbOzoUJdBHvHBdeAE8jIgKcJ4qW+LRY4kwh+gPsVsss6PU97R866f2R/IragU//+z3eijNEkM4+n+ZwADmS4jvU73NJ6mauZui+QlX+jSe6Ld+T0AFs/rrQn2zAxWYBqlz2nP3FdPsIHwitRXQtN/UyzXyMc+BQ1Oo3cSkXtrs6M9HxVxzi2g+gv57LWHD7XVsOCOvDdnTPdZPN7crMZ5WWohiyyi5k2aPOQcdjFtRFEgqXzoBgVA/6Up29knbYbxje4Eixf96iuwaJ7GQ64S+z5+ZdNLu+18nTjDhfMFZmvmnzham9cxa9/U/rcUdRx7xvi4RlYlXqEsy/DvCBpFrYzMRt92NmvkQl+g6hKDXwxTW5UzlcKKixMaS7fHzEosfl3q9nm6SUk59RdzfOSew7Y0gd2RuNurV5j9tzuvBWCB9ssXeiUjyoBhdUdtmGFuDZns7usjCkgDVTh9DfBhJITZKUh/X1zE2EXw1wz6bxdZlIynR7grKLrWEOZSI6GNLC7V0CdBVdRj6xytotCrTVH+cH5HyAu49HNHbH3180mcDDx0blzsXmgJmMj+Tob6Qn9zURZdCxFwJyNUy3qVRJvuyBXiPOWzFDsu/v+s3j5AnAITgoS9mHgQFC0KqfiMwsEAbut24ZL93SsLjpsEcfCPte Received: from ?IPV6:2003:cb:c730:2200:7229:83b1:524e:283a? (p200300cbc7302200722983b1524e283a.dip0.t-ipconnect.de. [2003:cb:c730:2200:7229:83b1:524e:283a]) by smtp.gmail.com with ESMTPSA id g8-20020a05600c310800b00410cfc34260sm3105364wmo.2.2024.02.12.04.14.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Feb 2024 04:14:24 -0800 (PST) Message-ID: Date: Mon, 12 Feb 2024 13:14:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 03/25] mm: Make pte_next_pfn() a wrapper around pte_advance_pfn() To: Ryan Roberts , Catalin Marinas , Will Deacon , Ard Biesheuvel , Marc Zyngier , James Morse , Andrey Ryabinin , Andrew Morton , Matthew Wilcox , Mark Rutland , Kefeng Wang , John Hubbard , Zi Yan , Barry Song <21cnbao@gmail.com>, Alistair Popple , Yang Shi , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Cc: linux-arm-kernel@lists.infradead.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240202080756.1453939-1-ryan.roberts@arm.com> <20240202080756.1453939-4-ryan.roberts@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240202080756.1453939-4-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240212_041431_119643_DA576127 X-CRM114-Status: GOOD ( 24.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 02.02.24 09:07, Ryan Roberts wrote: > The goal is to be able to advance a PTE by an arbitrary number of PFNs. > So introduce a new API that takes a nr param. > > We are going to remove pte_next_pfn() and replace it with > pte_advance_pfn(). As a first step, implement pte_next_pfn() as a > wrapper around pte_advance_pfn() so that we can incrementally switch the > architectures over. Once all arches are moved over, we will change all > the core-mm callers to call pte_advance_pfn() directly and remove the > wrapper. > > Signed-off-by: Ryan Roberts > --- > include/linux/pgtable.h | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h > index 5e7eaf8f2b97..815d92dcb96b 100644 > --- a/include/linux/pgtable.h > +++ b/include/linux/pgtable.h > @@ -214,9 +214,15 @@ static inline int pmd_dirty(pmd_t pmd) > > > #ifndef pte_next_pfn > +#ifndef pte_advance_pfn > +static inline pte_t pte_advance_pfn(pte_t pte, unsigned long nr) > +{ > + return __pte(pte_val(pte) + (nr << PFN_PTE_SHIFT)); > +} > +#endif > static inline pte_t pte_next_pfn(pte_t pte) > { > - return __pte(pte_val(pte) + (1UL << PFN_PTE_SHIFT)); > + return pte_advance_pfn(pte, 1); > } > #endif > I do wonder if we simply want to leave pte_next_pfn() around? Especially patch #4, #6 don't really benefit from the change? So are the other set_ptes() implementations. That is, only convert all pte_next_pfn()->pte_advance_pfn(), and leave a pte_next_pfn() macro in place. Any downsides to that? This patch here would become: #ifndef pte_advance_pfn static inline pte_t pte_advance_pfn(pte_t pte, unsigned long nr) { return __pte(pte_val(pte) + (nr << PFN_PTE_SHIFT)); } #endif #ifndef pte_next_pfn #define pte_next_pfn(pte) pte_advance_pfn(pte, 1) #endif As you convert the three arches, make them define pte_advance_pfn and udnefine pte_next_pfn. in the end, you can drop the #ifdef around pte_next_pfn here. -- Cheers, David / dhildenb _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel