From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Felipe Balbi <balbi@kernel.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 09/11] usb: phy: phy-mv-usb: convert to readl_poll_timeout_atomic()
Date: Thu, 20 Aug 2020 13:17:49 +0300 [thread overview]
Message-ID: <c28a906c-ed1a-8884-3016-b8664a313331@gmail.com> (raw)
In-Reply-To: <1597902349-8998-9-git-send-email-chunfeng.yun@mediatek.com>
On 20.08.2020 8:45, Chunfeng Yun wrote:
> Use readl_poll_timeout_atomic() to simplify code
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> v2: udelay 10us instead of 20us according to kerneldoc
> ---
> drivers/usb/phy/phy-mv-usb.c | 16 +++++++---------
> 1 file changed, 7 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/usb/phy/phy-mv-usb.c b/drivers/usb/phy/phy-mv-usb.c
> index ce767ec..e801569 100644
> --- a/drivers/usb/phy/phy-mv-usb.c
> +++ b/drivers/usb/phy/phy-mv-usb.c
> @@ -8,6 +8,7 @@
> #include <linux/module.h>
> #include <linux/kernel.h>
> #include <linux/io.h>
> +#include <linux/iopoll.h>
> #include <linux/uaccess.h>
> #include <linux/device.h>
> #include <linux/proc_fs.h>
> @@ -135,8 +136,8 @@ static int mv_otg_set_timer(struct mv_otg *mvotg, unsigned int id,
>
> static int mv_otg_reset(struct mv_otg *mvotg)
> {
> - unsigned int loops;
> u32 tmp;
> + int ret;
>
> /* Stop the controller */
> tmp = readl(&mvotg->op_regs->usbcmd);
> @@ -146,15 +147,12 @@ static int mv_otg_reset(struct mv_otg *mvotg)
> /* Reset the controller to get default values */
> writel(USBCMD_CTRL_RESET, &mvotg->op_regs->usbcmd);
>
> - loops = 500;
> - while (readl(&mvotg->op_regs->usbcmd) & USBCMD_CTRL_RESET) {
> - if (loops == 0) {
> - dev_err(&mvotg->pdev->dev,
> + ret = readl_poll_timeout_atomic(&mvotg->op_regs->usbcmd, tmp,
> + (tmp & USBCMD_CTRL_RESET), 10, 10000);
> + if (ret < 0) {
> + dev_err(&mvotg->pdev->dev,
> "Wait for RESET completed TIMEOUT\n");
You forgot to re-align this argument, it should start under & on the
previous line...
[...]
MBR, Sergei
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-20 10:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 5:45 [PATCH v2 01/11] usb: early: convert to readl_poll_timeout_atomic() Chunfeng Yun
2020-08-20 5:45 ` [PATCH v2 02/11] usb: early: ehci-dbgp: " Chunfeng Yun
2020-08-20 5:45 ` [PATCH v2 03/11] usb: pci-quirks: " Chunfeng Yun
2020-08-20 5:45 ` [PATCH v2 04/11] usb: xhci-rcar: " Chunfeng Yun
2020-08-20 5:45 ` [PATCH v2 05/11] usb: oxu210hp-hcd: " Chunfeng Yun
2020-08-20 5:45 ` [PATCH v2 06/11] usb: fotg210-hcd: " Chunfeng Yun
2020-08-20 5:45 ` [PATCH v2 07/11] usb: isp1760-hcd: " Chunfeng Yun
2020-08-20 5:45 ` [PATCH v2 08/11] usb: phy-ulpi-viewport: " Chunfeng Yun
2020-08-20 5:45 ` [PATCH v2 09/11] usb: phy: phy-mv-usb: " Chunfeng Yun
2020-08-20 10:17 ` Sergei Shtylyov [this message]
2020-08-21 1:52 ` Chunfeng Yun
2020-08-20 5:45 ` [PATCH v2 10/11] usb: udc: net2280: " Chunfeng Yun
2020-08-20 5:45 ` [PATCH v2 11/11] iopoll: update kerneldoc of read_poll_timeout_atomic() Chunfeng Yun
2020-08-20 10:14 ` Sergei Shtylyov
2020-08-21 1:43 ` Chunfeng Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c28a906c-ed1a-8884-3016-b8664a313331@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=balbi@kernel.org \
--cc=chunfeng.yun@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox