From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CCBDBC4828F for ; Fri, 9 Feb 2024 13:57:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sh81MRn85lDFMFBmSELKxrUetJBsAmPWJDYLgu9lJ50=; b=tnOvbdKMQUBqwY u5+i25uC6UmZcqrdt65L0XZcoLT1vkJ6jGFw0ckmFkdGP3Ncx4p9bekPs1Nh1PMY5vS2GjDYfAwjg hl656/b9QTbjWGGquBHCgrkPH4rASKz9vPkrgs0av+RIXw4icrpdw/TFQyrrENAibrcv6X7uIRUUL EE8EC/Q7LFXw18l+UWheljuxGIgwwU/Gl4cmoWGuHwwezHO25QFtt8hIjqabBddLwIkn4irTp4IMT KHtxmh0mv9LLlCbNslM/gPV6Yt5pcwnBmx6p2eTpETl352VPMykdBnsrcmGsg22THtx71H3WcTQFl In24fC3ZyqjTvI7LeIuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rYRNK-0000000H87M-0nRG; Fri, 09 Feb 2024 13:57:06 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rYRNG-0000000H85P-01pz for linux-arm-kernel@lists.infradead.org; Fri, 09 Feb 2024 13:57:03 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-410489e1a63so8170725e9.3 for ; Fri, 09 Feb 2024 05:57:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707487019; x=1708091819; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wzAUr8FZtB/gqQ92jmcp3rLgsmu5bcmcfB5ZKvPCTAo=; b=hZfBKCGAftKn+zKPCORt6cdM17QJxf1m7mszzoPGvPeratWPmxY2DbmKy/v5huf51K f2Sjg8q5yCAOu6iwSs7o6a4ERhkGLW56GvL6InysXGbFVFS9nvyXdyVEYHCTq+ea72lM SDyBF2r56sROPzUqCfUqKoeJTZQeXhTltTNGkMW2tAAQRF9/XJ7gC0nzLYsSyYuoCPoH Pf4+YISujXMTWdaX/9/4B6QxV2jq2XyWkKJF1O90oJgTgLJ8BI5p+IWh0UDlspiQCXHt nRCxzRoBMYHbZ33Ft1xw3dfvxQOEyTo5zRf6ytB2FPQSKzlD8KAajegNVB+WqK2j61Zm h39A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707487019; x=1708091819; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wzAUr8FZtB/gqQ92jmcp3rLgsmu5bcmcfB5ZKvPCTAo=; b=OSoYUFV7JpfKYBhSVKDOFsx2akt/YrJf4CDwo/OeW1eAon5yZBBToYfikN6gsLJda4 onDihWtRd/mh6XVvhTZCoDflVVpCE8nBPSfF9bR3w5JdrssGJO2kxLUTfEse2hoCDrha wtXEI+QAyhZ3FtIY5l43TG5ihtIg+yFsH0sL6+nmAB+sncHe2hI6BiNugS19xjtxjNsh l0EKqflptzn4yjK/LHHETqnECn1ZW5pMPRUvAJ86hIaIN3IzajKNtKEx8vAqLvkFgYEK HKKPga0I7kN8BvUJaguLVNpsSbr9oEzZM1K0j68Qe1Glnkl9m8DA2Mv/+VtKviMUvjrg sUlQ== X-Gm-Message-State: AOJu0YwQGREBQ28joG99fTvIY5JtFF48CCvrRSjhyzjgQHugfchL4U9F 7NkTEqBOmnLcb1olECdhPs5yDopy8SdYRtqpKprQkLWPaW3CzDOPRAx2C5IXITg= X-Google-Smtp-Source: AGHT+IEQLdyh2jCb+lCGrI2nNjyBAeHm6ekGsfjlzmDpZwXFB+7GiDDq9gKjNYS8MsJewo5AjV1XJQ== X-Received: by 2002:a05:600c:3d0b:b0:40e:fb4c:801d with SMTP id bh11-20020a05600c3d0b00b0040efb4c801dmr1298142wmb.13.1707487019031; Fri, 09 Feb 2024 05:56:59 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWqzdyXPQpxuboeQxrzdVEqFAjU+CVslIikEPsUW2QQfQZXYGuwwroNabViw65p+INrxFkbWKR4aLNysYn8znZWXwpiPcZJhXQaN7r82SfEfo0susUG3IoLcRzoDavxVp48t9pbrchLcyp33CQYXUs72wdhHr6E919JKxuFxf1Y5GK+pwuXg5WbNj+IM1MrLEd2nVo0n7pCdhrO+SqUMyx6AzjDFNQM/b7uW3hYlqPMkzTB075tJxSxm77z3ZY3iYGOV1dcWPqynNKaNnhNOdfL4YFhPpAJ108SgjTkKFagnCnQ1w8PWv4Pnwp1v3EcFDUKZBFN1hZmVQKRM9DgUagyNtMW7qrW+ygkR+Fa0gTeLqBL5ojuKKu7GtZm9jqg9DwD1amfLWFicbQMRLh1kcjQwzxWoadTmlA68oxQ18XQJZZ2p1tdOCKfzXZ+uZy+sP4EKQ83pcq/DGViab3cFG4/5t/C5Nk/WlxfIZIa1y9+PuqYrCc9nOd61vfneEXo/GgCL7V0TFxFHwmeZIX3pvUt3gek9gg26DCKiG0qiNIx6+CkFP4q5OyWQbppcum6/EBm7VKwrlOu5ojo2Jx6AwyQ1aqHZNHycjcKaGD4Fvww7jINzjl5/nc= Received: from [192.168.2.107] ([79.115.63.202]) by smtp.gmail.com with ESMTPSA id m6-20020a05600c3b0600b0040e9d507424sm789392wms.5.2024.02.09.05.56.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Feb 2024 05:56:58 -0800 (PST) Message-ID: Date: Fri, 9 Feb 2024 13:56:56 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/12] spi: dt-bindings: introduce the ``fifo-depth`` property Content-Language: en-US To: Conor Dooley , Geert Uytterhoeven Cc: broonie@kernel.org, robh@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, conor+dt@kernel.org, devicetree@vger.kernel.org, arnd@arndb.de References: <20240208135045.3728927-1-tudor.ambarus@linaro.org> <20240208135045.3728927-2-tudor.ambarus@linaro.org> <20240208-grating-legwarmer-0a04cfb04d61@spud> From: Tudor Ambarus In-Reply-To: <20240208-grating-legwarmer-0a04cfb04d61@spud> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240209_055702_094035_A1E0710E X-CRM114-Status: GOOD ( 17.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org + Geert On 2/8/24 18:24, Conor Dooley wrote: > On Thu, Feb 08, 2024 at 01:50:34PM +0000, Tudor Ambarus wrote: >> There are instances of the same IP that are configured by the integrator >> with different FIFO depths. Introduce the fifo-depth property to allow >> such nodes to specify their FIFO depth. >> >> We haven't seen SPI IPs with different FIFO depths for RX and TX, thus >> introduce a single property. > > Some citation attached to this would be nice. "We haven't seen" offers > no detail as to what IPs that allow this sort of configuration of FIFO > size that you have actually checked. > > I went and checked our IP that we use in FPGA fabric, which has a > configurable fifo depth. It only has a single knob for both RX and TX > FIFOs. The Xilinx xps spi core also has configurable FIFOs, but again RX > and TX sizes are tied there. At least that's a sample size of three. > > One of our guys is working on support for the IP I just mentioned and > would be defining a vendor property for this, so > Reviewed-by: Conor Dooley > Thanks, Conor. I had in mind that SPI has a shift register and it's improbable to have different FIFO depths for RX and TX. At least I don't see how it would work, I guess it will use the minimum depth between the two? I grepped by "fifo" in the spi bindings and I now see that renesas is using dedicated properties for RX and TX, but I think that there too the FIFOs have the same depths. Looking into drivers/spi/spi-sh-msiof.c I see that the of_device_id.data contains 64 bytes FIFOs for RX and TX, regardless of the compatible. Geert, any idea if the FIFO depths can differ for RX and TX in spi-sh-msiof.c? Anyway, even if there are such imbalanced architectures, I guess we can consider them when/if they appear? (add rx/tx-fifo-depth dt properties) Cheers, ta ---- $ git grep fifo Documentation/devicetree/bindings/spi/ Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml: atmel,fifo-size: Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml: atmel,fifo-size = <32>; Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml: cdns,fifo-depth: Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml: cdns,fifo-depth: Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml: cdns,fifo-depth: Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml: cdns,fifo-width: Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml: - cdns,fifo-depth Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml: - cdns,fifo-width Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml: cdns,fifo-depth = <128>; Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml: cdns,fifo-width = <4>; Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml: renesas,tx-fifo-size: Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml: Override the default TX fifo size. Unit is words. Ignored if 0. Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml: renesas,rx-fifo-size: Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml: Override the default RX fifo size. Unit is words. Ignored if 0. Documentation/devicetree/bindings/spi/spi-sifive.yaml: sifive,fifo-depth: Documentation/devicetree/bindings/spi/spi-sifive.yaml: sifive,fifo-depth = <8>; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel