From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38907C982DA for ; Sun, 20 Sep 2026 17:07:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SRR6GWm8VvaCpKgQykY2MiSoqyYUd1GFMV1rrWkJ4JI=; b=KvCyZJurhfH0pMkSbdh+TQYwU+ /s+kV0KusI+xxwtYCnN9klWYhE/JUGCF+DMTq/nXGbpp0hHeMJ3Y5QqnnnyARNVtxmYb+qcq2K2rf qhvukEn9+xzi1zHfNZ6MQhs8YSphZbF5P0deuwHDbtWYP0gjBDxWgT9EcyM3QvWsVmF8lU0KlBODp +ZJUSyyJR/I0IDx+n9ht8DprZzB57xN1jguBs5jmVgEN1PVHAEvvay4UJ/tc1TWO0CcJuLBN3TwSU yowhE4FXCjThyOI27GzuZQLCBgs8X6ITS5ieAJsOM39dRUj1QHiH3Bbv2EDOWeh+c/tw4iBDWCE7F WUT88cxg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8L0w-00000000AkC-0dqG; Sun, 20 Sep 2026 17:07:42 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8L0u-00000000Ajd-29Ph; Sun, 20 Sep 2026 17:07:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=SRR6GWm8VvaCpKgQykY2MiSoqyYUd1GFMV1rrWkJ4JI=; b=LswdCCLGZ/fMTQ3fP37RE0xKmP tWLPS26CI1aHU7OSJLo4czeq1buGrq1SP4843QH/8q7GydxdJRJ5FarpIzBqSKJ98gU2TQc0oQwGy FY+BYRxWt7Lee6y7s9AFMUxX5aVGPlNmmDATqZIjBxpHEmBB2Dit1Azv1/G9/Qn+g4cQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1x8L0d-006BGL-FN; Sun, 20 Sep 2026 19:07:23 +0200 Date: Sun, 20 Sep 2026 19:07:23 +0200 From: Andrew Lunn To: jan.petrous@oss.nxp.com Cc: Ciprian Marian Costea , NXP S32 Linux Team , Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ghennadi Procopciuc , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Geert Uytterhoeven , Magnus Damm , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Bogdan Hamciuc , Ionut Vicovan , Heiner Kallweit , Russell King , Clark Wang , Philipp Zabel , Maxime Chevallier , Maxime Coquelin , Alexandre Torgue , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Richard Cochran , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, imx@lists.linux.dev, linux-pci@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Vincent Guittot , Alexandru-Catalin Ionita , Bogdan Roman Subject: Re: [PATCH RFC v3 05/12] net: pcs: Add NXP S32G XPCS driver Message-ID: References: <20260919-s32g_serdes-v3-0-9d68868c1e89@oss.nxp.com> <20260919-s32g_serdes-v3-5-9d68868c1e89@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260919-s32g_serdes-v3-5-9d68868c1e89@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260920_100740_554310_0B7D356B X-CRM114-Status: UNSURE ( 5.95 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > +#define SR_MII_CTRL 0x1f0000 This is 0x1f0000 + MII_BMCR > +#define SS13 BIT(13) #define BMCR_SPEED100 0x2000 /* Select 100Mbps */ > +#define AN_ENABLE BIT(12) #define BMCR_ANENABLE 0x1000 /* Enable auto negotiation */ > +#define RESTART_AN BIT(9) #define BMCR_ANRESTART 0x0200 /* Auto negotiation restart */ > +#define DUPLEX_MODE BIT(8) #define BMCR_FULLDPLX 0x0100 /* Full duplex */ > +#define SS6 BIT(6) #define BMCR_SPEED1000 0x0040 /* MSB of Speed (1000) */ > +#define SR_MII_STS 0x1f0001 This is 0x1f0000 + MII_BMSR > +#define LINK_STS BIT(2) #define BMSR_LSTATUS 0x0004 /* Link status */ Please go through all these register definitions and throw out all the ones which follow 801.3 and use the values from include/uapi/linux/mii.h Andrew --- pw-bot: cr