From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4BBCC433EF for ; Mon, 11 Jul 2022 14:54:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PfPkwekvSjgai1G399ZFrlLPLfGV+8L+TeskEo4VFUM=; b=nKNMOdX9ChsI+y hPjEJu1bR2QDDPKWbmoNz2vnoGlj7I4h5Eq8pcXDZD1uz52yIEGjRAJbqM6/CihZcYRC6JfNtuKdg JXshKtY9eBKMEaoj7jfY9yl2mm+1lIla3qHWLMWsF7iWRdCRuG6u3XiXwRdHzK/eNIZveX+7OMFD4 AAZY7QlwW3A8avevsili15L++Oy08WZriz5V2iJGzhDl0fv7hP36Vck1f6SYECeUDqG0OpLG7Xh6F jWzIPiZwy3s63TUkBN6KYFWaedXR6Lrjhkzfll83uBcgL5ygeAnRmpgayfMoQdzTzaHPdVz2SiqUT kncmdSp+UBWta7MvTvHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oAunD-002cGT-BI; Mon, 11 Jul 2022 14:53:47 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oAun9-002cBx-DU for linux-arm-kernel@lists.infradead.org; Mon, 11 Jul 2022 14:53:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657551220; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WJKzatRpxuBvlw+y/WmRUjNpFDe0w/BjpatBDpchBJM=; b=JfoC/2v0koMztXy7nlpLhI0AoMujYOKff3fWmuX6J8CEZPQS7isOwwXRRP50myoB/RkD3h 7xUr0M+b2kmSQf/fJXBIKsASnXitmIL4pmX0exPXDaVkUG8xgtaV3r2IOQMbUOOpxpvNHU h7/Jq22YZ2jVxii4OLzsFeYkQvax53s= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-264-BXRLGqygMZGuADKEFEMEXg-1; Mon, 11 Jul 2022 10:53:39 -0400 X-MC-Unique: BXRLGqygMZGuADKEFEMEXg-1 Received: by mail-wm1-f69.google.com with SMTP id x6-20020a05600c21c600b003a2e9d4a106so522187wmj.6 for ; Mon, 11 Jul 2022 07:53:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=WJKzatRpxuBvlw+y/WmRUjNpFDe0w/BjpatBDpchBJM=; b=REN3Gvl6kaqbXI94nd58GAtSRj1gaqH/UOsz8FJEeJ2ERITQO5q7+3h3viRUnwRTeg 81u4nmQd+tboeVaqpicwAQNke3W7e+BdiApicvlN+Tl+5elKPwuU7QiDw6sDCRNCU69I MZNLunm2dnRq1nrOwKvppxJUXKaXtLC1J7pSRieKBNWVXoQgmOqyoFe/hKDRdetmbBmN ZbEcbRe8giVCYIeCTfky8mKbBB4n7l8ymS7H0K2Eq9AGamEcLUm8XzbhFAHDGw5CEqRy LUKka2iwDgb/NwRusTmUioAvMRVjJy6c0rF4LuIr8JA55k91r0sxRrIryTgaGEJMwMAF 3lcA== X-Gm-Message-State: AJIora8Z5VUNekjU15X+HMDGqt++gvRqQQmCWckVWZJ/1UC0qtQo6Veo FN8Snbh6yNe9u4dyeoLse6POyLPIvyY+MbBz2aXvuHscKKnH8E8sAM8AeFOfq+EOHE464XNRF0w vrq1z+xOG5AX5lIj4lOsG4RLsj25VCbX4FJE= X-Received: by 2002:a05:600c:3592:b0:3a1:9e9d:2595 with SMTP id p18-20020a05600c359200b003a19e9d2595mr16789380wmq.76.1657551217925; Mon, 11 Jul 2022 07:53:37 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uF7fVJz9gV/LGNy5ZuztDsIKohRmcbcs6QZEq6X8YOCi+3alMsLlZbv00GX9vpBHFadMKsmA== X-Received: by 2002:a05:600c:3592:b0:3a1:9e9d:2595 with SMTP id p18-20020a05600c359200b003a19e9d2595mr16789363wmq.76.1657551217690; Mon, 11 Jul 2022 07:53:37 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:1400:c3:4ae0:6d5c:1ab2? (p200300cbc702140000c34ae06d5c1ab2.dip0.t-ipconnect.de. [2003:cb:c702:1400:c3:4ae0:6d5c:1ab2]) by smtp.gmail.com with ESMTPSA id m8-20020a05600c3b0800b003a2ead2c884sm528930wms.13.2022.07.11.07.53.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Jul 2022 07:53:37 -0700 (PDT) Message-ID: Date: Mon, 11 Jul 2022 16:53:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/4] mm/sparse: skip no-map memblock check when fill_subsection_map To: Li Chen , Catalin Marinas , Will Deacon , Rob Herring , Frank Rowand , Andrew Morton Cc: Li Chen , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org References: <20220711122459.13773-1-me@linux.beauty> <20220711122459.13773-3-me@linux.beauty> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220711122459.13773-3-me@linux.beauty> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220711_075343_574417_24302A42 X-CRM114-Status: GOOD ( 20.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11.07.22 14:24, Li Chen wrote: > From: Li Chen > > When mhp use sparse_add_section, don't check no-map region, > so that to allow no-map reserved memory to get struct page > support. > > Signed-off-by: Li Chen > Change-Id: I0d2673cec1b66adf695251037a00c240976b226f > --- > mm/sparse.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/sparse.c b/mm/sparse.c > index 120bc8ea5293..a29cd1e7014f 100644 > --- a/mm/sparse.c > +++ b/mm/sparse.c > @@ -690,7 +690,9 @@ static int fill_subsection_map(unsigned long pfn, unsigned long nr_pages) > > if (bitmap_empty(map, SUBSECTIONS_PER_SECTION)) > rc = -EINVAL; > - else if (bitmap_intersects(map, subsection_map, SUBSECTIONS_PER_SECTION)) > + else if (memblock_is_map_memory(PFN_PHYS(pfn)) && > + bitmap_intersects(map, subsection_map, > + SUBSECTIONS_PER_SECTION)) > rc = -EEXIST; > else > bitmap_or(subsection_map, map, subsection_map, I'm not sure I follow completely what you are trying to achieve. But if you have to add memblock hacks into mm/sparse.c you're most probably doing something wrong. Please explain why that change is necessary, and why it is safe. If the subsection map already spans memory (iow, subsection map is set) you intend to add, then something already added memory in that range? -- Thanks, David / dhildenb _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel