From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jayesh Choudhary <j-choudhary@ti.com>,
nm@ti.com, vigneshr@ti.com, afd@ti.com
Cc: s-vadapalli@ti.com, kristo@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, a-bhatia1@ti.com
Subject: Re: [PATCH v3 4/5] arm64: dts: ti: k3-j784s4-main: Add DSS and DP-bridge node
Date: Wed, 19 Apr 2023 20:04:10 +0200 [thread overview]
Message-ID: <c2db08eb-a31d-cded-cb20-c358b77d804c@linaro.org> (raw)
In-Reply-To: <bc58b9cc-f1a1-9c60-341c-9a00777e7142@ti.com>
On 19/04/2023 12:35, Jayesh Choudhary wrote:
>>> + reg-names = "common_m", "common_s0",
>>> + "common_s1", "common_s2",
>>> + "vidl1", "vidl2","vid1","vid2",
>>> + "ovr1", "ovr2", "ovr3", "ovr4",
>>> + "vp1", "vp2", "vp3", "vp4",
>>> + "wb";
>>> +
>>> + clocks = <&k3_clks 218 0>,
>>
>> Broken indentation.
>
> Indentation at both places are similar to j721e dss node.
> Changes are needed in both?
There is no DTS coding style which uses indentation before or after '='.
Just because some DTS are written wrong, should not encourage you to do
the same...
I am commenting only on this patch - it is not correct. What is wrong in
other files should be fixed in other places, not relevant to this patch.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-04-19 18:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 6:17 [PATCH v3 0/5] Add peripherals for J784S4 Jayesh Choudhary
2023-04-19 6:17 ` [PATCH v3 1/5] arm64: dts: ti: k3-j784s4-main: Add system controller and SERDES lane mux Jayesh Choudhary
2023-04-19 7:49 ` Krzysztof Kozlowski
2023-04-19 9:44 ` Jayesh Choudhary
2023-04-19 6:17 ` [PATCH v3 2/5] arm64: dts: ti: k3-j784s4: Add Main CPSW2G node Jayesh Choudhary
2023-04-19 7:50 ` Krzysztof Kozlowski
2023-04-19 10:02 ` Jayesh Choudhary
2023-04-19 6:17 ` [PATCH v3 3/5] arm64: dts: ti: k3-j784s4: Add WIZ and SERDES PHY nodes Jayesh Choudhary
2023-04-19 6:17 ` [PATCH v3 4/5] arm64: dts: ti: k3-j784s4-main: Add DSS and DP-bridge node Jayesh Choudhary
2023-04-19 7:51 ` Krzysztof Kozlowski
2023-04-19 10:35 ` Jayesh Choudhary
2023-04-19 18:04 ` Krzysztof Kozlowski [this message]
2023-04-19 6:17 ` [PATCH v3 5/5] arm64: dts: ti: k3-j784s4-evm: Enable DisplayPort-0 Jayesh Choudhary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2db08eb-a31d-cded-cb20-c358b77d804c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a-bhatia1@ti.com \
--cc=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=j-choudhary@ti.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).