From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F597C6FD18 for ; Wed, 19 Apr 2023 18:05:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PHjC9pBd+hY8vVgXKLTaz4zuzNybzp/TcrqsBi78wCU=; b=Ba12NlIBSAKDkN UVetmRXvHYElv7fTjsoxD67WQ5WAUKkaStB8wjQZFBM1d6w18l72/hik7CgARSknIE77lDQLRw51r jK8WG32E6Cg1mv/EueCntvqaq8ASljnMUc8bWSyfTQjYUJjZictmdiFuX9Ar/gdsAXXelKkdiaewN KvxMxPwSFxzmYwWC0H4wp7TEGLrZ9sechr6PYH9u/93zCP1OjZwu5CFMjxyoc9sbLUe30WdqRIdmD MwSIr2DZPwkBWmzTvw6BiiUkINYceEofgQQ4KHdnsGA6KNjDjYJicUN7FwgSp/HyEdwPNvJCQAm2A OWpS3OlKmsog31Wh3blQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ppCAC-0066rl-1z; Wed, 19 Apr 2023 18:04:16 +0000 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ppCA9-0066r3-0k for linux-arm-kernel@lists.infradead.org; Wed, 19 Apr 2023 18:04:14 +0000 Received: by mail-ej1-x62e.google.com with SMTP id vc20so341629ejc.10 for ; Wed, 19 Apr 2023 11:04:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681927452; x=1684519452; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mhOMRuZ4RYtVXwhrIpThNbtd7ozYp3pbSIMKq7KmV5Q=; b=R8fdSS20ksg1pynC9t1vSq0+5JD/pvO/96eT3IfrzjVuvnhalxXhh/yJQtfTfr3DzJ ryAwWLtABjI87c0z9zmAbHW3rsytORLAJOsrCtYDNe9zLQHYDtTqRw4vRgLOG6ulOlzl Mu6idsPej6poqU9sASR0dhAhHbbOjA8Omr6e7wCcLoICA/HqFeeMIqw3/ZJZS8htjRkT MXxAHk0a5hNRtOSxJAHAgYoawBVai6Kkx4swhTOEiJ8nV+Ksh5Z49NyxiKjLKsaiJdNw 4+Iflj7FUBz1QDVxee+PQx9qC6OGbD5maWB27JYaMorrMx3GxO7YwcVeDXUZ8uSkEHqH J/sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681927452; x=1684519452; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mhOMRuZ4RYtVXwhrIpThNbtd7ozYp3pbSIMKq7KmV5Q=; b=b4nywKEdtrrRBc52nrWZczuQmLRSujHj65sz2XUCCwInwVD50/zF8j2VFmc9Nsl6Ct +GVmTiGEJ/qg98YwHfV4OocV8zKJoZy3OcaJNq8WNLrNTbpxvtYx4ErD3C1okLOylDCH uV91IFpkZ7MRlgjB+8MxFgpILE8suZyu/4HvkYNXvtHcKtm1MGWAdCz6BocS11BBXpwq zhCV40E9PF1NBRf275KbkuIwBGn5znm4FZhlgyzAqNU/zCFKyyljqm8g1bmag072oNJX 9SbN+0TWC3CiJiPoIgagUoz42/39tZkNuisPmiTPQPpUGuA3Qio+6HhR3+v71cGL12zh zN6w== X-Gm-Message-State: AAQBX9fWSd71t53MOChSFvH8Rbe89wWL2swUunOlsudM1CgnGMPGGo3G svjDLLHEHnDsoPEiczS2O+DMoQ== X-Google-Smtp-Source: AKy350b8y+4R4SLiYhgrlKJuX9NH3AJCLiUJaiXvpzYv0lnZA9rcV8nlPVKRWSkRvRHiA5/ZxfOn8A== X-Received: by 2002:a17:907:1245:b0:94e:6294:9d23 with SMTP id wc5-20020a170907124500b0094e62949d23mr12770897ejb.26.1681927451762; Wed, 19 Apr 2023 11:04:11 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:b7d8:d88b:1fac:c802? ([2a02:810d:15c0:828:b7d8:d88b:1fac:c802]) by smtp.gmail.com with ESMTPSA id hs4-20020a1709073e8400b0094ed3abc937sm8496477ejc.82.2023.04.19.11.04.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Apr 2023 11:04:11 -0700 (PDT) Message-ID: Date: Wed, 19 Apr 2023 20:04:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v3 4/5] arm64: dts: ti: k3-j784s4-main: Add DSS and DP-bridge node Content-Language: en-US To: Jayesh Choudhary , nm@ti.com, vigneshr@ti.com, afd@ti.com Cc: s-vadapalli@ti.com, kristo@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, a-bhatia1@ti.com References: <20230419061710.290068-1-j-choudhary@ti.com> <20230419061710.290068-5-j-choudhary@ti.com> <83c8bce1-f4e2-899e-46a9-0ba9da702572@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230419_110413_277721_DFE44B0D X-CRM114-Status: GOOD ( 11.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19/04/2023 12:35, Jayesh Choudhary wrote: >>> + reg-names = "common_m", "common_s0", >>> + "common_s1", "common_s2", >>> + "vidl1", "vidl2","vid1","vid2", >>> + "ovr1", "ovr2", "ovr3", "ovr4", >>> + "vp1", "vp2", "vp3", "vp4", >>> + "wb"; >>> + >>> + clocks = <&k3_clks 218 0>, >> >> Broken indentation. > > Indentation at both places are similar to j721e dss node. > Changes are needed in both? There is no DTS coding style which uses indentation before or after '='. Just because some DTS are written wrong, should not encourage you to do the same... I am commenting only on this patch - it is not correct. What is wrong in other files should be fixed in other places, not relevant to this patch. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel