From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0BAE9C54E4A for ; Fri, 8 Mar 2024 09:49:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NZCOnqIEoaZRRhstSuocPN864TFqqnQwF1B4aVa++PY=; b=R6jr5Ax1T7wmRS KgVj6F3ii/wn2qkPO5oaASqDOpeDcFbuX5p5cUbyg3PNKsADbk+eyQvxd5v1qTCsb8w41uGlaPXgD 04dDamjzGrqs4qCGJtB4xiV9XaI0k02O9IDkkw7cOl2mWbYLOhE3E5GTJPdqvBuoa3a/2SqtYd4aZ rlP/Cvluc2WRhxUjn9XJ0f8Y0gKva1aDofMtS4skjxkK8DQxfn7aI1GdHMWBgkXBGqJ94DD+GMUvZ imVerttdoI2XbaXuAsND1R73zwvPmPB7mKf0LEa2Yjj7dOgKOlC6SHrC3sXJ+YvB6EjfLEUDLnrf1 ix8r5jVLkNKJ5HQH3fHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1riWqk-00000008d1x-1siI; Fri, 08 Mar 2024 09:49:10 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1riWqh-00000008d13-29Y4 for linux-arm-kernel@lists.infradead.org; Fri, 08 Mar 2024 09:49:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1709891347; x=1741427347; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=Zo+hLmMOrxDDslH256VVd8pEnRInJdPD0qjzhmJJb+w=; b=QI3FlHqaWEZlHtkrL0xxwuuPL27UuUEVy0V3YRAyJGW/a8BLmL80tcmX H7ZEJM3Hn1UhK6Es3iwaDuUwokwO2SeLNDwjCYfhbu5bNZKHXpguwqvqa dhROVRYF2YjPiVw75gkyGTdIfZH5A7zf8cVuxV6JRqblJJDm7uTbWfaNp jTaoLfZcci3hL8Kdsx6VZaZp5CECFPF893hqrWmqdfENsVgsedo3luQx8 dqZSo3qJ3I48JvJm+3zxMGgu4ZRsNWKl7GrGR4MmMsAuMKTrFcWDHA0KZ WT5wFBV7VjYd/r9zZK7VcE5TWreY1FDfbXIaNR2MJ9NsRonENM+PEeUZ6 A==; X-CSE-ConnectionGUID: B+js35oNSN291EIfb2xPyA== X-CSE-MsgGUID: lf++Gj7rT7er6mzIn5tKlQ== X-IronPort-AV: E=Sophos;i="6.07,109,1708412400"; d="scan'208";a="17381631" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa4.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 08 Mar 2024 02:49:03 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 8 Mar 2024 02:48:39 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (10.10.215.250) by email.microchip.com (10.10.87.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 8 Mar 2024 02:48:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GfzozS9BLHi0uVLOkWK5g3NH2L5eLsRNCIj0iutHE35SVKPmgYsFa3dwUBUt7skkcRciDtU3NQ7ieVowvYg6jP7LfBLbwWRC2HpFiWwNfgzpY3Y2hLprJNQiE4tEI35NCXU32s1OUsNt3y0xQhwVOE+B/vZhfkskjk8//V9j0HWFCBhyoIxNzmBbMoKHJ0SXpqN/qWf4NwKFQhPeDvbwHKOuKqcfyKFngMCOEL9qScep+Qks5wQamvCWrHtWF31C6qbM8N5tcZIO+iOO0ndG9vR86OCjKIuzquOZrWepZ/72PkLmdz7nKeG0QADXS2jW3/783N9cGmkrhjgO4XnCDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Zo+hLmMOrxDDslH256VVd8pEnRInJdPD0qjzhmJJb+w=; b=iNmNPuFruseiOBZJmQ8aMN85eBHzB0w4KlVV8yS4oT3DXosThGyzflvhn7a2R7uUUZwx44Bm0HByD19FToDYsTdjk1LRGLwjyo3duHXr28lz7wk0X5/HKJAev0NSb/mP6DRQ3hlqpHKta++eBdB6M8tv3LKqUhKP4+nqkKDtYlV/RNyoa9oPa2zOt4LEnlVcM/e3/kX3SYJvT9RAAtOqG0bgMQRFdUXE4jXybb8l/e+EjzrxBWhsRjrY1ap/td6JPrAZ3NkMhidUU3cON+HVTjSjSXZvBUMMcQGNFRC9BvVgwSM783cOytAvrCM58faRNqJUz3ifN/hn188V4F9o/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchip.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zo+hLmMOrxDDslH256VVd8pEnRInJdPD0qjzhmJJb+w=; b=AIwR+LQDxyUtS2DlYs1LNUZi+OZCUCj/RN4qJ2HSJQwWGHQOLDzwUVLdtpiRzsPP+dpA4ydMWi5CdQculAQS7Oh5oQmuTwcJAEtUaeU6Ylw4+XYzZbFtC20sL2734oWVdpym3R+46MGniEo/k5/ryI8jhNoGME3OvIvvL04ILNvSI58ha8Brf+UoKEEL2njk2WAksxBdUFDl6r3Wcsu98p35IhhZKGZmcSs+VZelBd8m53EdcxS+IC1GRZVErmYRWMothIFyNSElBWxeOWu3GYhm6lEpS/kIDNdx1Rc0w9lG0Tm4I7xZe/2dzQW89ZdJByFIPZg4bxmr11pFiiHsjQ== Received: from SA0PR11MB4719.namprd11.prod.outlook.com (2603:10b6:806:95::17) by DS0PR11MB7333.namprd11.prod.outlook.com (2603:10b6:8:13e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.10; Fri, 8 Mar 2024 09:48:35 +0000 Received: from SA0PR11MB4719.namprd11.prod.outlook.com ([fe80::f65f:f05e:4faf:4433]) by SA0PR11MB4719.namprd11.prod.outlook.com ([fe80::f65f:f05e:4faf:4433%4]) with mapi id 15.20.7386.009; Fri, 8 Mar 2024 09:48:35 +0000 From: To: , , , , , , , , , , , , , Subject: Re: [PATCH v4 39/39] ARM: dts: at91: sam9x75_curiosity: add sam9x75 curiosity board Thread-Topic: [PATCH v4 39/39] ARM: dts: at91: sam9x75_curiosity: add sam9x75 curiosity board Thread-Index: AQHaZn4raEIk6bXo7kyr7EePEwSde7El/ROAgAexggA= Date: Fri, 8 Mar 2024 09:48:35 +0000 Message-ID: References: <20240223171342.669133-1-varshini.rajendran@microchip.com> <20240223173113.673595-1-varshini.rajendran@microchip.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA0PR11MB4719:EE_|DS0PR11MB7333:EE_ x-ms-office365-filtering-correlation-id: a0f0e2cb-1833-4281-c4a7-08dc3f54ec34 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pMmNFol1u9cWHCxoYXTA/L1vK/xN8oRVbb9Eo8NsW9aB5fGFoJIaqduDFoXeGjbdJuYw+cqm1UZzjEJ1hoeo3s+zNw82KIc/NLyFYH3UnnCPPkz3GVjemc3JYrOPXNT/diTQnh9NNrLYhz96sCGURYf9gYxsuPZhveSmgU/1fdWb6vZoItTmcZ4GYmIzi2vlcADEgo2NegFEtqnmU3xATIYZYSQPcrdd3tL2hwIo0MTIbJncHk+62of55Mk7gnuO0+CHH/Kii1OBfRCtZoKaOG2hdwRAVXk6zDm8VXUMDb+Z+F5FeaY3YrXdevaMCWNkEH1GA0owonFMm2VX55E/5GB42kp/9jn6vS5anyw0CHtdnraak7HQ1dLAOooZuVDm2xvIEtlUsKiEFSeWHBqPCcqoj9nEBv4UHBWgg2jnG0DQf7i/M6VPhshKY1VOdCsg02yBjYe9INEOGfz+ze9XQQYyBysuc2ED7yuK9Vns6dYusc0gBDwNnmcwfEU4Bo37zogvWMHGw6mssJo6KovgnUVeAggCfwi1KNp878sD4M54rYY0PPtmi6LBESNsaOjSAKte+boVOOLps68jvVhFSFka0FJPW1/fOE0zXksqjsySkD5dZw80IgqURbZYjpadhWgr5hu8lDgi8rG0tScR0eTrlNIj2vTBLmaVAyu7ZlEiqxDnfc54Mqv9nnYe+hba x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR11MB4719.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(7416005)(376005)(1800799015)(921011)(38070700009);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?U0dyaEFhU01nM3dSOFRFelRLbHJHc25Vb1pRL05pVUZUUzAveDMwZFFjczF2?= =?utf-8?B?Zk1ObmlPc2xTdEIvNW9ZTk94TGp1RnNyMU9uWUdCY2ZBNHYxWHJxUCtRQmsv?= =?utf-8?B?ZVhBMVFXZmhtVlVhQUwzRUN1eU0yY3VBRlNPNW1oV1IrN2d3aXE1bkc2K1VT?= =?utf-8?B?b1NNSkxFU0QrZk83ZHAySkxCWkR3MzRDeG1iRmNSa1krWXVXUTUrcHlpdnFM?= =?utf-8?B?SkhLY09oUmxpYldOWm93Ukt3cEJXcXJyTS94cVBwMCtYUUZCdERoNjNGeXI0?= =?utf-8?B?NzVRVzQyVkNCNE0rRVFKR09qSE1VQnVnOFVEU2RFUWw2NnJmY0w0TFJUZjdx?= =?utf-8?B?Rm1zeDhyK2xMb1JaQVYxbi9WWVVXekI1cHU0OWJSNzlJaDZYQmYycFFEQ0RB?= =?utf-8?B?YmwyZzFSalY1M3dLNFNuOHZwcG5NWGlwYk81UVBoR3c4VlorNU9RZlhiZWVI?= =?utf-8?B?bDRYREF2SjFJUndDOXdPR1MxZTFvU2tXN2FkOFdnVm8xdFVrN2psOGtCRktr?= =?utf-8?B?b05nV0hSQWFCdVA5TU11aCt3UkxsaCs5WVFQaTlrUkMzMlF6VElzNjFkWXlX?= =?utf-8?B?MmI2UldvYTN0bE9UK1RFNlJDenJuS3Vvc0gwVFFad3dYdGoxaWJhSHFDWmFI?= =?utf-8?B?OWNlc0FuWndQdHBPeUE4cVR6ZDBoWDVoR29UTE5FRTIxRU52NFl4c3VVUVdJ?= =?utf-8?B?bkpSaUpyc245VXN6b2tZOU9OUmxDb2RvOWxkb0MvUHZ1a1cwYzZwUXNxWnlT?= =?utf-8?B?aEx1VC9qNDhmR3ljM1pYTXQ2MnAzK2Y4NHVYSmsxK1RZVzRUTVc4ZFdXcEo1?= =?utf-8?B?S1BpSXRkMlpVZWVVYjQ4NXVtQUF6NnJmczZscVVOclRFRXZIaDVjbklxQWti?= =?utf-8?B?Tk9qRFBZZklpbmY0RjU3TnRuY2FWanIxR3A0RzhZOTVHKzN4MW9XK3BPUys2?= =?utf-8?B?K0lkdWRtTXNmVjdwRlZwSUVCcUZKcjdaY1IxWm9XOEtkQnNvN1liS2ZkWnVz?= =?utf-8?B?YnQxNWdSamhpSWJ6N2xTRWp1RW9uR3B5Mno2R1dvcXVtbTdZbkl1RE53TGFj?= =?utf-8?B?QkZ4WDR3ZldxUHQ3OWlrcHhsN3NORzdQcjY1RGF1MENUcEhXRDZMbGZUeHdR?= =?utf-8?B?QzlpeFFiRDdMTk1adUZIS1FpMU5TQVc3VmhZd1VKUUR2RlVWSkVzNGkyNGt2?= =?utf-8?B?QjQ5NUMxNkxtTjVZR09VQ29SdlBKMkJwell6NUlrM3FpblQzL0NZSDEvSjA2?= =?utf-8?B?SmFUeHBRVkw1dnBVNUdES2lDa3ZFN21KcTlYNU5XN2VqVVlLK1pWOWFURWt3?= =?utf-8?B?b2c0TGdBbXNqZTFDNmpiR3ZGUWMxMjNaNUhzLzVrR2xTV2FVVzZmK2NKaDFR?= =?utf-8?B?U1ZmTVVDYzB2eGl3ZGl6cDZNQUNvTWE2Zm90N2xJUzBYY1pEZWVlRTVhOUx0?= =?utf-8?B?L0xRclAyQUJMekFHNFRwcTF6YUVWN2R3VDU4dXZMZHdZd2RlRklMV3N6Vkpu?= =?utf-8?B?RTh4bGhoQnNLaFNuQW10SjU1YmFsQUVhN2hPRHlwU1krMXRLcGRMaGZTU3R6?= =?utf-8?B?bGUvWExxcjlITFJzWDBORXVuRXNxQXNvKzJLZ2xPYWptTnh0WkVMVURJdVZZ?= =?utf-8?B?VVQvMlpOUE1mSlNSREV6ZFc1VURIdU9tcE5kNCtxNWtEaVJxUnFvWGZGbXVK?= =?utf-8?B?YngzZ3JHUURmZWp3dWtBSDBFS0lSMlFVNCt1cGMzN0FaSXQvUDlUa2JUOUJa?= =?utf-8?B?MEVsKzYxdFlWak14aWM5MkRaclQxV2lMTVhIL1JqRXBzZkwvNGY4NGg0ckkx?= =?utf-8?B?MnJqN09CT2F1eTgrVXpWb21HUERNbVliVjR6V3VuZFAxUndvUlhZbWYvU1B1?= =?utf-8?B?SlR6RDlYY0k5MnM2UVJycjFNd3g4ZkN6bWxqWnJqSkJ1QTQxN29VdjFLTzRM?= =?utf-8?B?UUFvbkdSUXFYeWpsMzZLUmVqM0pNRUwyWWRlU1JFYVA3L1VyNTQ4Ni9Lb3k1?= =?utf-8?B?WlkwZlZiMzIxTHNjLzZIdHJ3Tzd6bU0rQjNXejIzRXloNitSRmhveEdhRXdj?= =?utf-8?B?UzBhbUtZOG56UTU2REszZ0FvWm80MTJFbVpJbEhpVWhqVDJLNzBZc1k1Vng2?= =?utf-8?B?Z1BQUGFzekRHaHVabitxOVZvcFFCUjVwenF2K1RIL2FGT2NoY25DemFQZHcv?= =?utf-8?B?NFE9PQ==?= Content-ID: <24F43027E2273D4B9BA7B95BDE8E4506@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA0PR11MB4719.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0f0e2cb-1833-4281-c4a7-08dc3f54ec34 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2024 09:48:35.2437 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vGW9b3qxtZ5TPnw/snuLvvYdEyIquPoFctdWFxAkHkyP0/+nN0E7OKHshiARyjLgUnXYe5Nppz3jrB1F2sJ8XiIJve/1iSufs+Y5HuWKkpQPmfmhE8f0gQMpNAYp9Xq1 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7333 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240308_014907_980296_D3CAC8F8 X-CRM114-Status: GOOD ( 17.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Claudiu, On 03/03/24 5:49 pm, claudiu beznea wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > s/ARM: dts: at91/ARM: dts: microchip > > in title. > > On 23.02.2024 19:31, Varshini Rajendran wrote: >> Add device tree file for sam9x75 curiosity board. >> >> Signed-off-by: Varshini Rajendran >> --- >> Changes in v4: >> - Removed full node paths >> - Renamed Leds with color names >> - Corrected regulator node names >> - Added support for classd and i2s nodes and their corresponding >> pinctrl nodes >> - Dropped USB nodes owing to the discussion here >> https://lore.kernel.org/linux-devicetree/CAL_JsqJ9PrX6fj-EbffeJce09MXs=B7t+KS_kOinxaRx38=WxA@mail.gmail.com/ >> (Explained elaborately in the cover letter) >> - Updated the linux,code property with the necessary value >> --- >> arch/arm/boot/dts/microchip/Makefile | 3 + >> .../dts/microchip/at91-sam9x75_curiosity.dts | 309 ++++++++++++++++++ >> 2 files changed, 312 insertions(+) >> create mode 100644 arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts >> >> diff --git a/arch/arm/boot/dts/microchip/Makefile b/arch/arm/boot/dts/microchip/Makefile >> index efde9546c8f4..5b3d518da319 100644 >> --- a/arch/arm/boot/dts/microchip/Makefile >> +++ b/arch/arm/boot/dts/microchip/Makefile >> @@ -12,6 +12,7 @@ DTC_FLAGS_at91-sama5d3_eds := -@ >> DTC_FLAGS_at91-sama5d3_xplained := -@ >> DTC_FLAGS_at91-sama5d4_xplained := -@ >> DTC_FLAGS_at91-sama7g5ek := -@ >> +DTC_FLAGS_at91-sam9x75_curiosity := -@ > > Keep it alphanumerically sorted, thus after sam9x60 entry. > >> dtb-$(CONFIG_SOC_AT91RM9200) += \ >> at91rm9200ek.dtb \ >> mpa1600.dtb >> @@ -59,6 +60,8 @@ dtb-$(CONFIG_SOC_AT91SAM9) += \ >> dtb-$(CONFIG_SOC_SAM9X60) += \ >> at91-sam9x60_curiosity.dtb \ >> at91-sam9x60ek.dtb >> +dtb-$(CONFIG_SOC_SAM9X7) += \ >> + at91-sam9x75_curiosity.dtb >> dtb-$(CONFIG_SOC_SAM_V7) += \ >> at91-kizbox2-2.dtb \ >> at91-kizbox3-hs.dtb \ >> diff --git a/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts b/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts >> new file mode 100644 >> index 000000000000..be37022d3d05 >> --- /dev/null >> +++ b/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts >> @@ -0,0 +1,309 @@ >> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> +/* >> + * at91-sam9x75_curiosity.dts - Device Tree file for Microchip SAM9X75 Curiosity board >> + * >> + * Copyright (C) 2023 Microchip Technology Inc. and its subsidiaries >> + * >> + * Author: Varshini Rajendran >> + */ >> +/dts-v1/; >> +#include "sam9x7.dtsi" >> +#include >> + >> +/ { >> + model = "Microchip SAM9X75 Curiosity"; >> + compatible = "microchip,sam9x75-curiosity", "microchip,sam9x7", "atmel,at91sam9"; >> + >> + aliases { >> + i2c0 = &i2c6; >> + }; >> + >> + chosen { >> + stdout-path = "serial0:115200n8"; >> + }; >> + >> + gpio-keys { >> + compatible = "gpio-keys"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_key_gpio_default>; >> + >> + button-user { >> + label = "USER"; >> + gpios = <&pioC 9 GPIO_ACTIVE_LOW>; >> + linux,code = ; >> + wakeup-source; >> + }; >> + }; >> + >> + leds { >> + compatible = "gpio-leds"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_led_gpio_default>; >> + >> + led-red { >> + label = "red"; >> + gpios = <&pioC 19 GPIO_ACTIVE_HIGH>; >> + }; >> + >> + led-green { >> + label = "green"; >> + gpios = <&pioC 21 GPIO_ACTIVE_HIGH>; >> + }; >> + >> + led-blue { >> + label = "blue"; >> + gpios = <&pioC 20 GPIO_ACTIVE_HIGH>; >> + linux,default-trigger = "heartbeat"; >> + }; >> + }; >> + >> + memory@20000000 { >> + device_type = "memory"; >> + reg = <0x20000000 0x10000000>; >> + }; >> +}; >> + >> +&classd { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_classd>; >> + atmel,pwm-type = "diff"; >> + atmel,non-overlap-time = <10>; >> + status = "okay"; >> +}; >> + >> +&dbgu { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_dbgu>; >> + status = "okay"; >> +}; >> + >> +&dma0 { >> + status = "okay"; >> +}; >> + >> +&flx6 { >> + atmel,flexcom-mode = ; >> + status = "okay"; >> +}; >> + >> +&i2c6 { > > I don't know if you got any review comments w/ regards to this in the > previous email but having flexcoms and inner node grouped together is > easier to follow (at least to me). e.g.: > Yes, I received a comment not to duplicate nodes. https://patchwork.kernel.org/project/linux-mmc/patch/20230623203056.689705-46-varshini.rajendran@microchip.com/ >> + #address-cells = <1>; >> + #size-cells = <0>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_flx6_default>; >> + i2c-analog-filter; >> + i2c-digital-filter; >> + i2c-digital-filter-width-ns = <35>; >> + status = "okay"; >> + >> + pmic@5b { >> + compatible = "microchip,mcp16502"; >> + reg = <0x5b>; >> + >> + regulators { >> + vdd_3v3: VDD_IO { >> + regulator-name = "VDD_IO"; >> + regulator-min-microvolt = <3000000>; >> + regulator-max-microvolt = <3600000>; > > I can't find the schematics for this but these values here should reflect > the voltage that the board support not the ones that the PMIC itself > supports. Valid for all the other regulators. > Okay. I will double check this with hardware experts as well. > >> + regulator-initial-mode = <2>; >> + regulator-allowed-modes = <2>, <4>; >> + regulator-always-on; >> + >> + regulator-state-standby { >> + regulator-on-in-suspend; >> + regulator-mode = <4>; >> + }; >> + >> + regulator-state-mem { >> + regulator-mode = <4>; >> + }; >> + }; >> + >> + vddioddr: VDD_DDR { >> + regulator-name = "VDD_DDR"; >> + regulator-min-microvolt = <1283000>; >> + regulator-max-microvolt = <1450000>; >> + regulator-initial-mode = <2>; >> + regulator-allowed-modes = <2>, <4>; >> + regulator-always-on; >> + >> + regulator-state-standby { >> + regulator-on-in-suspend; >> + regulator-mode = <4>; >> + }; >> + >> + regulator-state-mem { >> + regulator-on-in-suspend; >> + regulator-mode = <4>; >> + }; >> + }; >> + >> + vddcore: VDD_CORE { >> + regulator-name = "VDD_CORE"; >> + regulator-min-microvolt = <500000>; >> + regulator-max-microvolt = <1210000>; >> + regulator-initial-mode = <2>; >> + regulator-allowed-modes = <2>, <4>; >> + regulator-always-on; >> + >> + regulator-state-standby { >> + regulator-on-in-suspend; >> + regulator-mode = <4>; >> + }; >> + >> + regulator-state-mem { >> + regulator-mode = <4>; >> + }; >> + }; >> + >> + vddcpu: VDD_OTHER { >> + regulator-name = "VDD_OTHER"; >> + regulator-min-microvolt = <1700000>; >> + regulator-max-microvolt = <3600000>; >> + regulator-initial-mode = <2>; >> + regulator-allowed-modes = <2>, <4>; >> + regulator-ramp-delay = <3125>; >> + regulator-always-on; >> + >> + regulator-state-standby { >> + regulator-on-in-suspend; >> + regulator-mode = <4>; >> + }; >> + >> + regulator-state-mem { >> + regulator-mode = <4>; >> + }; >> + }; >> + >> + vldo1: LDO1 { >> + regulator-name = "LDO1"; >> + regulator-min-microvolt = <1200000>; >> + regulator-max-microvolt = <3700000>; >> + regulator-always-on; >> + >> + regulator-state-standby { >> + regulator-on-in-suspend; >> + }; >> + }; >> + >> + vldo2: LDO2 { >> + regulator-name = "LDO2"; >> + regulator-min-microvolt = <1200000>; >> + regulator-max-microvolt = <3700000>; >> + >> + regulator-state-standby { >> + regulator-on-in-suspend; >> + }; >> + }; >> + }; >> + }; >> +}; >> + >> +&i2s { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_i2s_default>; >> + #sound-dai-cells = <0>; >> + status = "disabled"; > > Any reason this is disabled? There is a conflict. My bad, I missed mentioning it since the other node support is not added yet. I will add it in the next version. > >> +}; >> + >> +&main_xtal { >> + clock-frequency = <24000000>; >> +}; >> + >> +&pinctrl { >> + > > This line could be removed. > >> + classd { >> + pinctrl_classd: classd { >> + atmel,pins = >> + > Try to be compliant with coding style from here (valid everywhere): > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n167 > >> + AT91_PIOA 19 AT91_PERIPH_C AT91_PINCTRL_PULL_DOWN>; >> + }; >> + }; >> + >> + dbgu { >> + pinctrl_dbgu: dbgu-0 { > > usually pinctrl label is something like the following in Microchip AT91 DTSes: > pinctrl__default and node name is -default. > > Please use the same rule everywhere. > >> + atmel,pins = > + AT91_PIOA 27 AT91_PERIPH_A AT91_PINCTRL_NONE>; >> + }; >> + }; >> + >> + flexcom { >> + pinctrl_flx6_default: flx6-twi { >> + atmel,pins = >> + > + AT91_PIOA 25 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; >> + }; >> + }; >> + >> + gpio-keys { >> + pinctrl_key_gpio_default: key-gpio-default { >> + atmel,pins = ; >> + }; >> + }; >> + >> + i2s { >> + pinctrl_i2s_default: i2s { >> + atmel,pins = >> + > + AT91_PIOB 15 AT91_PERIPH_D AT91_PINCTRL_NONE /* I2SWS */ >> + AT91_PIOB 16 AT91_PERIPH_D AT91_PINCTRL_NONE /* I2SDIN */ >> + AT91_PIOB 17 AT91_PERIPH_D AT91_PINCTRL_NONE /* I2SDOUT */ >> + AT91_PIOB 25 AT91_PERIPH_D AT91_PINCTRL_NONE>; /* I2SMCK */ >> + }; >> + }; >> + >> + leds { >> + pinctrl_led_gpio_default: led-gpio-default { >> + atmel,pins = > + AT91_PIOC 21 AT91_PERIPH_GPIO AT91_PINCTRL_NONE >> + AT91_PIOC 20 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>; >> + }; >> + }; >> + >> + sdmmc0 { >> + pinctrl_sdmmc0_default: sdmmc0 { >> + atmel,pins = >> + > + AT91_PIOA 1 AT91_PERIPH_A (AT91_PINCTRL_PULL_UP | AT91_PINCTRL_DRIVE_STRENGTH_HI | AT91_PINCTRL_SLEWRATE_DIS) /* PA1 CMD periph A with pullup */ >> + AT91_PIOA 0 AT91_PERIPH_A (AT91_PINCTRL_PULL_UP | AT91_PINCTRL_DRIVE_STRENGTH_HI | AT91_PINCTRL_SLEWRATE_DIS) /* PA0 DAT0 periph A */ >> + AT91_PIOA 3 AT91_PERIPH_A (AT91_PINCTRL_PULL_UP | AT91_PINCTRL_DRIVE_STRENGTH_HI | AT91_PINCTRL_SLEWRATE_DIS) /* PA3 DAT1 periph A with pullup */ >> + AT91_PIOA 4 AT91_PERIPH_A (AT91_PINCTRL_PULL_UP | AT91_PINCTRL_DRIVE_STRENGTH_HI | AT91_PINCTRL_SLEWRATE_DIS) /* PA4 DAT2 periph A with pullup */ >> + AT91_PIOA 5 AT91_PERIPH_A (AT91_PINCTRL_PULL_UP | AT91_PINCTRL_DRIVE_STRENGTH_HI | AT91_PINCTRL_SLEWRATE_DIS)>; /* PA5 DAT3 periph A with pullup */ >> + }; >> + }; >> + > > You can remove this line > >> +}; /* pinctrl */ >> + >> +&rtt { >> + atmel,rtt-rtc-time-reg = <&gpbr 0x0>; >> +}; >> + >> +&sdmmc0 { >> + bus-width = <4>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_sdmmc0_default>; >> + cd-gpios = <&pioA 23 GPIO_ACTIVE_LOW>; >> + disable-wp; >> + status = "okay"; >> +}; >> + >> +&slow_xtal { >> + clock-frequency = <32768>; >> +}; >> + >> +&power_management { >> + debounce-delay-us = <976>; >> + status = "okay"; >> + >> + input@0 { >> + reg = <0>; >> + }; >> +}; >> + >> +&trng { >> + status = "okay"; >> +}; >> + >> +&watchdog { >> + status = "okay"; >> +}; -- Thanks and Regards, Varshini Rajendran. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel