From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01805C48BF8 for ; Mon, 19 Feb 2024 19:50:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5+gMA3f+zXE0QzQdw1IAMI5PRGQcYNb0izjdo3rZLYA=; b=RoosxWF7fBdBLM /VinArCp96o2Q7YbdqSKxX9tDEghyU+wT8Q/DUDXlYNFLZgcBQ/aEKxaX7xLDIFW2CbtPIPw/m/08 W7P3okbPtROf8EwsI69WjkQUOuCf7ZLi6+zK2eBEa7BwXJ0KYKTm2MM3iFApXJU09M/HuueqveQvr GKu1Z7DfCYGVK/QRTeZupXtdTrIIG5MSvbb6KVDJbIv354Rp+wzFS4PEHhOwEvP7HOKgxnX17t3tl sUg4jjHMXevFrA3b/RCaMi75R5binqIcteLetzZDSHV0OF+9sWntlWoRNQ4zVezGcajAPBqDuV2EV T1X9xFEPO33HqrL0Jd/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rc9eF-0000000Bxwb-3NWo; Mon, 19 Feb 2024 19:49:55 +0000 Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rc9eC-0000000Bxuv-3lct for linux-arm-kernel@lists.infradead.org; Mon, 19 Feb 2024 19:49:54 +0000 Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2d220ad10b3so35494281fa.1 for ; Mon, 19 Feb 2024 11:49:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708372188; x=1708976988; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=j+Mxj6oL3njy7wYXA6Pewj5A5hfEOxX2yUvAWo5Ne8Y=; b=G1EPnXwKmyn5maGjrezGF4eJ6gBVSPOKBvyxWelCX8BAlYTI0yPVnSTuX3H8wr4FOR OXJaKnDn0/5B7M+oWV/3MWvPEJtuFvPouiE9g3oIANsoRzpZN4CwrJ7yoGhM0z8MmNF3 1CnCc/+kzUTNwGFdkQPW37Ov9WfPC5miuzMvfvgLy5dxKusK8k0RyITGjjzJxqb+ON+4 y5DaBHhbfv8sHJzielAhfSfUt0nZKrblpwwi+a7CTZ2jD/aSORUD5EdtJhw9fT4hcleh aXHbgY7jxvtLyAWff9VrACHWsQchJqKtnCeLWLK44QepCKa6L+jooFgd4jqcIjdUxxZj OBAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708372188; x=1708976988; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=j+Mxj6oL3njy7wYXA6Pewj5A5hfEOxX2yUvAWo5Ne8Y=; b=sihz1mlSIH9ofCxvWmgUNHij6yVrX/ejsxXrfxe2b5leWkJnoOBIy8HhGqKGjlthmN ETWJJApvLzkCcMKDZXB5OtyBCfCHw72IRCgZPqr9B7m/Ya6RlRfoFAg0+iDn4Q9dlIbt JdhqSLoSGzz17b+1CzfbbMrOJ6UrGneaVFYVQ/SyjjzfTce1UGOO9+E2ig/ujugeaweC eW0F2ANYGSLLsYemgx99fDlZSEYLsJYR3TKMpUCaUHVn/XgSNrqqWHI+2SzT3tmbu/7h YIdFBehV91gr4NJ4pIp0AVkBDbO/FJOAGYVqcmmGpjKC/tEo9SBhddoH90od3/VECt+D BgoA== X-Forwarded-Encrypted: i=1; AJvYcCWs/eUM04+O1jHu4LYToWhnDs8cIACH1JkkK/3uIIpq9to+vhS521TuQnz2pBcCSvZz8fypMX+NCdnEiQMAQS2nJh5bRQXQS8e1fu9uelQwdyDDfis= X-Gm-Message-State: AOJu0YyTUxYR+bS8heIAD0CywYFSeLY5bXQzy+U12e9sw6w5yLD3CuXR zQ6MXWdqtk2AXj1m2A1E+uIc1yKv39A8SgDFCNLZPUEfVY06EPDM X-Google-Smtp-Source: AGHT+IFih7GdrQAufuteLL8qMR0G4/2b7CwVADm2kPBGSrjoEY1liwkNr8A7UP7zROTWMCWm0iPUfA== X-Received: by 2002:a05:651c:b21:b0:2d2:35e6:7a7f with SMTP id b33-20020a05651c0b2100b002d235e67a7fmr3898833ljr.0.1708372188047; Mon, 19 Feb 2024 11:49:48 -0800 (PST) Received: from [192.168.50.244] (83.8.201.110.ipv4.supernova.orange.pl. [83.8.201.110]) by smtp.gmail.com with ESMTPSA id d5-20020aa7c1c5000000b00564775edd4esm1224313edp.35.2024.02.19.11.49.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Feb 2024 11:49:47 -0800 (PST) Message-ID: Date: Mon, 19 Feb 2024 20:49:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ARM: dts: exynos4212-tab3: limit usable memory range To: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht References: <20240217-tab3-limit-usable-memory-range-v1-1-49cc9c86a5cc@gmail.com> <15ab6aa6-fb30-4970-9c50-546afb933e03@linaro.org> Content-Language: en-US From: Artur Weber In-Reply-To: <15ab6aa6-fb30-4970-9c50-546afb933e03@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240219_114952_976645_BE5045C9 X-CRM114-Status: GOOD ( 19.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19.02.2024 08:44, Krzysztof Kozlowski wrote: > On 17/02/2024 20:02, Artur Weber wrote: >> The stock bootloader on the Samsung Galaxy Tab 3 8.0 provides an >> incorrect available memory range over ATAG_MEM. Limit the usable >> memory in the DTS to prevent it from doing so, without having to >> disable ATAG support. >> >> Signed-off-by: Artur Weber >> --- >> arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi >> index e5254e32aa8f..9bc05961577d 100644 >> --- a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi >> +++ b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi >> @@ -45,6 +45,12 @@ chosen { >> /* Default S-BOOT bootloader loads initramfs here */ >> linux,initrd-start = <0x42000000>; >> linux,initrd-end = <0x42800000>; >> + >> + /* >> + * Stock bootloader provides incorrect memory size in ATAG_MEM; >> + * override it here >> + */ >> + linux,usable-memory-range = <0x40000000 0x3fc00000>; > > Applied and dropped: > chosen: linux,usable-memory-range:0: [4611686019496935424] is too short This seems to be a binding issue; the DT schema expects a 64-bit memory address and size, and doesn't allow a 32-bit range. I've tested the DTS on my device and this property seems to be handled fine, so I think this should allow 32-bit values as well. I've opened a PR[1] against devicetree-org/dt-schema (where the schema for the chosen node is stored) to try and fix this. If my approach is incorrect, feel free to comment there as well. Best regards Artur [1] https://github.com/devicetree-org/dt-schema/pull/128 > > Does not look you tested the bindings. > > Please observe that we have dedicated subsystem profile since a release: > https://www.kernel.org/doc/html/latest/process/maintainers.html#arm-samsung-s3c-s5p-and-exynos-arm-architectures > > Best regards, > Krzysztof > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel