From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EAC1AC61DA4 for ; Wed, 15 Mar 2023 06:37:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vboFJDIbQG5MaUqPcmOQ0Y0qM6HYJVAr7soJP8LvlqM=; b=hQkPEXQxkhYo8h tBnZA5iNowzYPcSZ5w87auYrhe6XWpufmgMN3fS2FwS3Uekq2yagSDAoA/HpH0OrJJ6GG3EVfy0D3 g4ISSJvJjxqzwf4FA5PKAAKoSsYPgHEKZ/c5sNr/rTkx0SLChPK4JyIkqtHsiJrVhWX5/tPXk8cIQ 5KpAGZCQfmIOB88fpKAoI7LGtwPF/Nl9WAst2zVkJ++xGUZ4AiBK0p/KOF1u4QuE8vkjoJxiK0tC4 M9TKH/IWjOZ+ql13hAgb7MmJOlphL8LiF4Ez6Ctfz+BWHTvk+mk08TFXsNljanoDiaSYMorRp1mNO diteIUKsixrnXnJiDUXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcKkp-00CYCO-0m; Wed, 15 Mar 2023 06:36:55 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcKkl-00CYAU-03 for linux-arm-kernel@lists.infradead.org; Wed, 15 Mar 2023 06:36:53 +0000 Received: by mail-ed1-x534.google.com with SMTP id z21so6055992edb.4 for ; Tue, 14 Mar 2023 23:36:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678862209; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KC0WmgOfjafcWzo9T9EJ/kwEick/ELqJEOpJmapTe34=; b=EOjepyr2KbnBu8V+/dIGLzeB7rf6edvM4dAgNrBj3u509JsU8+PnB8JwXXcPViAggr 9jNvXLnXOa4cPP77tl3j43+VkIE1JTz/rcuv04wM+uUq+872el8nhhFDCuzFWE4VtinF S7mxdEAYzcPDPhUC7e5Rbx7z+l7ImirLvzSTe7fgguKwMCICuHOwxili5n55Fl6sRzYi gjWeC6M0eFSpNpEcC8PeA+0n6NyYUyVZcTlwa7StRY7I0E75n5Y71R0QWqFacnPbBGxG SuJBo5pUr2eh0WXQeKBSguE3QcuUXZ0dCW/b1mq+p9K+TWKtsOBHDoX1bQzGDGxLYQQO bHgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678862209; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KC0WmgOfjafcWzo9T9EJ/kwEick/ELqJEOpJmapTe34=; b=QMIkBwll3s9/5r297pmqFdpaurSeu4smqj4On1H7+SX9Q2TRpsS9DfzbZAqRlEe6gv N+3om1OE5AmE98Ye7LjRUhHIf57R2iFtenIgntIZO0w49NKGxRa1sc80DjUjTR5u7u4c wn9JE5/W6KLY+FvmQsJnR/1Z+HFmn/Jt6fPBvapXmu7DPfhGfxpDjIaXCodi4XVMcAkI JNZFY8B5//p86YvbXkVbMRy5ZNXZlYmcvhHqQZG8e9JYAX4VxRoi3o3DF9s28SyXPycf /qQwdGlQsb2JFKMU2LeUjwWcIMGbGNkZufEeAOzZiDAGVpPzznSlTEH8vytgKWAnyDDh Fu+g== X-Gm-Message-State: AO0yUKWDEAF/uG2+5Fv7kuub/oVcsBkyv0IyM7XYfJF+WOVD6/TgwYmc YGoYMB3LAm2HXrmFO22ogJIR0g== X-Google-Smtp-Source: AK7set+Qlxf0T9dtFxHDCEa1K9fnKl6esE6BSL3I+/JB5H9lX8Bxy36qh8ITlyt5HcCvKap3KQCepQ== X-Received: by 2002:a17:906:a245:b0:925:1d1d:6825 with SMTP id bi5-20020a170906a24500b009251d1d6825mr5153121ejb.42.1678862208766; Tue, 14 Mar 2023 23:36:48 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:940e:8615:37dc:c2bd? ([2a02:810d:15c0:828:940e:8615:37dc:c2bd]) by smtp.gmail.com with ESMTPSA id rv20-20020a17090710d400b00924ffcb65e7sm2064103ejb.49.2023.03.14.23.36.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Mar 2023 23:36:48 -0700 (PDT) Message-ID: Date: Wed, 15 Mar 2023 07:36:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] arm64: dts: cisco: add device tree for Cisco CrayAr Argos. Content-Language: en-US To: Daniel Walker , Catalin Marinas , Will Deacon , Arnd Bergmann , Olof Johansson , soc@kernel.org, Rob Herring , Krzysztof Kozlowski , xe-linux-external@cisco.com Cc: Marcin Wierzbicki , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230315010920.2473206-1-danielwa@cisco.com> From: Krzysztof Kozlowski In-Reply-To: <20230315010920.2473206-1-danielwa@cisco.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230314_233651_378833_1AF5314B X-CRM114-Status: GOOD ( 21.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15/03/2023 02:09, Daniel Walker wrote: > From: Marcin Wierzbicki > > This adds device tree include file for Cisco CrayAR SoC and > device tree file for Cisco CrayAR Argos EVB board. > > Cc: xe-linux-external@cisco.com > Signed-off-by: Marcin Wierzbicki > Signed-off-by: Daniel Walker > --- > .../devicetree/bindings/arm/cisco/crayar.yaml | 27 ++ > MAINTAINERS | 5 + > arch/arm64/Kconfig.platforms | 5 + > arch/arm64/boot/dts/Makefile | 1 + > arch/arm64/boot/dts/cisco/Makefile | 2 + > arch/arm64/boot/dts/cisco/crayar.dtsi | 326 ++++++++++++++++++ > arch/arm64/boot/dts/cisco/crayar_argos.dts | 32 ++ > 7 files changed, 398 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/cisco/crayar.yaml > create mode 100644 arch/arm64/boot/dts/cisco/Makefile > create mode 100644 arch/arm64/boot/dts/cisco/crayar.dtsi > create mode 100644 arch/arm64/boot/dts/cisco/crayar_argos.dts > > diff --git a/Documentation/devicetree/bindings/arm/cisco/crayar.yaml b/Documentation/devicetree/bindings/arm/cisco/crayar.yaml > new file mode 100644 > index 000000000000..3975ca4fd07a > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/cisco/crayar.yaml Bindings are separate patches, always, split them. > @@ -0,0 +1,27 @@ > +# SPDX-License-Identifier: GPL-2.0 Dual license. Checkpatch should complain. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/cisco/crayar.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cisco CrayAR based Platforms Device Tree Bindings Drio "Device Tree Bindings" > + > +maintainers: > + - xe-linux-external@cisco.com > + > +description: | Drop '|' > + Cisco CrayAR boards with CrayAR SOC > + > +properties: > + $nodename: > + const: '/' > + compatible: > + oneOf: > + - description: Cisco CrayAR Argos evaluation board > + items: > + - const: cisco,crayar-argos > + - const: cisco,crayar > + > +additionalProperties: true > + > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index ec57c42ed544..f94d769c6f88 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -4793,6 +4793,11 @@ X: drivers/char/ipmi/ > X: drivers/char/random.c > X: drivers/char/tpm/ > > +CISCO ARM64 DEVICE TREE SUPPORT > +M: xe-linux-external@cisco.com > +S: Supported > +F: arch/arm64/boot/dts/cisco/ > + > CHECKPATCH > M: Andy Whitcroft > M: Joe Perches > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index 89a0b13b058d..740099c56382 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -94,6 +94,11 @@ config ARCH_BITMAIN > help > This enables support for the Bitmain SoC Family. > > +config ARCH_CISCO_CRAYAR_ARGOS > + bool "Cisco Argos Platform" > + help > + This enables support for the Cisco Argos Platform. > + > config ARCH_EXYNOS > bool "Samsung Exynos SoC family" > select COMMON_CLK_SAMSUNG > diff --git a/arch/arm64/boot/dts/Makefile b/arch/arm64/boot/dts/Makefile > index 7b107fa7414b..3f83583f9996 100644 > --- a/arch/arm64/boot/dts/Makefile > +++ b/arch/arm64/boot/dts/Makefile > @@ -11,6 +11,7 @@ subdir-y += arm > subdir-y += bitmain > subdir-y += broadcom > subdir-y += cavium > +subdir-y += cisco > subdir-y += exynos > subdir-y += freescale > subdir-y += hisilicon > diff --git a/arch/arm64/boot/dts/cisco/Makefile b/arch/arm64/boot/dts/cisco/Makefile > new file mode 100644 > index 000000000000..b1d4220df2f4 > --- /dev/null > +++ b/arch/arm64/boot/dts/cisco/Makefile > @@ -0,0 +1,2 @@ > +# SPDX-License-Identifier: GPL-2.0 > +dtb-$(CONFIG_ARCH_CISCO_CRAYAR_ARGOS) += crayar_argos.dtb > diff --git a/arch/arm64/boot/dts/cisco/crayar.dtsi b/arch/arm64/boot/dts/cisco/crayar.dtsi > new file mode 100644 > index 000000000000..22579406e65c > --- /dev/null > +++ b/arch/arm64/boot/dts/cisco/crayar.dtsi > @@ -0,0 +1,326 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Device Tree Include file for Cisco CrayAR family SoC. > + * > + * Copyright (C) 2022 Cisco > + */ > + > +#include > +#include > + > +/ { > + compatible = "cisco,crayar"; > + interrupt-parent = <&gic>; > + #address-cells = <0x2>; > + #size-cells = <0x2>; > + > + base_clk: base-clk { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <500000000>; > + }; > + > + cpus { > + #address-cells = <0x1>; > + #size-cells = <0x0>; > + > + cpu0: cpu@0 { > + device_type = "cpu"; > + compatible = "arm,cortex-a75", "arm,armv8"; > + reg = <0x00000>; > + enable-method = "spin-table"; > + cpu-release-addr = <0x0 0x7003FFF8>; > + next-level-cache = <&l2_0>; > + }; > + > + cpu1: cpu@100 { > + device_type = "cpu"; > + compatible = "arm,cortex-a75", "arm,armv8"; > + reg = <0x00100>; > + enable-method = "spin-table"; > + cpu-release-addr = <0x0 0x7003FFF8>; > + next-level-cache = <&l2_1>; > + }; > + > + cpu2: cpu@200 { > + device_type = "cpu"; > + compatible = "arm,cortex-a75", "arm,armv8"; > + reg = <0x00200>; > + enable-method = "spin-table"; > + cpu-release-addr = <0x0 0x7003FFF8>; > + next-level-cache = <&l2_2>; > + }; > + > + cpu3: cpu@300 { > + device_type = "cpu"; > + compatible = "arm,cortex-a75", "arm,armv8"; > + reg = <0x00300>; > + enable-method = "spin-table"; > + cpu-release-addr = <0x0 0x7003FFF8>; > + next-level-cache = <&l2_3>; > + }; > + > + cpu4: cpu@10000 { > + device_type = "cpu"; > + compatible = "arm,cortex-a75", "arm,armv8"; > + reg = <0x10000>; > + enable-method = "spin-table"; > + cpu-release-addr = <0x0 0x7003FFF8>; > + next-level-cache = <&l2_4>; > + }; > + > + cpu5: cpu@10100 { > + device_type = "cpu"; > + compatible = "arm,cortex-a75", "arm,armv8"; > + reg = <0x10100>; > + enable-method = "spin-table"; > + cpu-release-addr = <0x0 0x7003FFF8>; > + next-level-cache = <&l2_5>; > + }; > + > + cpu6: cpu@10200 { > + device_type = "cpu"; > + compatible = "arm,cortex-a75", "arm,armv8"; > + reg = <0x10200>; > + enable-method = "spin-table"; > + cpu-release-addr = <0x0 0x7003FFF8>; > + next-level-cache = <&l2_6>; > + }; > + > + cpu7: cpu@10300 { > + device_type = "cpu"; > + compatible = "arm,cortex-a75", "arm,armv8"; > + reg = <0x10300>; > + enable-method = "spin-table"; > + cpu-release-addr = <0x0 0x7003FFF8>; > + next-level-cache = <&l2_7>; > + }; > + > + cpu-map { > + cluster0 { > + core0 { > + cpu = <&cpu0>; > + }; > + core1 { > + cpu = <&cpu1>; > + }; > + core2 { > + cpu = <&cpu2>; > + }; > + core3 { > + cpu = <&cpu3>; > + }; > + }; > + cluster1 { > + core0 { > + cpu = <&cpu4>; > + }; > + core1 { > + cpu = <&cpu5>; > + }; > + core2 { > + cpu = <&cpu6>; > + }; > + core3 { > + cpu = <&cpu7>; > + }; > + }; > + }; > + > + l2_0: l2-cache0 { > + compatible = "cache"; > + next-level-cache = <&l3_0>; > + }; > + > + l2_1: l2-cache1 { > + compatible = "cache"; > + next-level-cache = <&l3_0>; > + }; > + > + l2_2: l2-cache2 { > + compatible = "cache"; > + next-level-cache = <&l3_0>; > + }; > + > + l2_3: l2-cache3 { > + compatible = "cache"; > + next-level-cache = <&l3_0>; > + }; > + > + l2_4: l2-cache4 { > + compatible = "cache"; > + next-level-cache = <&l3_1>; > + }; > + > + l2_5: l2-cache5 { > + compatible = "cache"; > + next-level-cache = <&l3_1>; > + }; > + > + l2_6: l2-cache6 { > + compatible = "cache"; > + next-level-cache = <&l3_1>; > + }; > + > + l2_7: l2-cache7 { > + compatible = "cache"; > + next-level-cache = <&l3_1>; > + }; > + > + l3_0: l3-cache0 { > + compatible = "cache"; > + }; > + > + l3_1: l3-cache1 { > + compatible = "cache"; > + }; > + }; > + > + cci: cci@2E000000 { Lowercase hex, everywhere > + compatible = "arm,cci-550"; > + #address-cells = <0x1>; > + #size-cells = <0x1>; > + reg = <0x0 0x2E000000 0x0 0x1000>; reg is second property > + ranges = <0x0 0x0 0x2E000000 0x6000>; ranges third, and fix case everywhere > + > + secondary-if@1000 { > + compatible = "arm,cci-550-ctrl-if"; > + interface-type = "ace-lite"; > + reg = <0x1000 0x1000>; > + }; > + > + secondary-if@2000 { > + compatible = "arm,cci-550-ctrl-if"; > + interface-type = "ace-lite"; > + reg = <0x2000 0x1000>; > + }; > + > + secondary-if@3000 { > + compatible = "arm,cci-550-ctrl-if"; > + interface-type = "ace-lite"; > + reg = <0x3000 0x1000>; > + }; > + > + secondary-if@4000 { > + compatible = "arm,cci-550-ctrl-if"; > + interface-type = "ace"; > + reg = <0x4000 0x1000>; > + }; > + > + secondary-if@5000 { > + compatible = "arm,cci-550-ctrl-if"; > + interface-type = "ace"; > + reg = <0x5000 0x1000>; > + }; > + > + secondary-if@6000 { > + compatible = "arm,cci-550-ctrl-if"; > + interface-type = "ace"; > + reg = <0x6000 0x1000>; > + }; > + > + secondary-if@7000 { > + compatible = "arm,cci-550-ctrl-if"; > + interface-type = "ace"; > + reg = <0x6000 0x1000>; > + }; > + > + pm-cntr@10000 { > + compatible = "arm,cci-550-pmu"; > + reg = <0x10000 0x10000>; > + }; > + > + pm-cntr@20000 { > + compatible = "arm,cci-550-pmu"; > + reg = <0x20000 0x10000>; > + }; > + > + pm-cntr@30000 { > + compatible = "arm,cci-550-pmu"; > + reg = <0x30000 0x10000>; > + }; > + > + pm-cntr@40000 { > + compatible = "arm,cci-550-pmu"; > + reg = <0x40000 0x10000>; > + }; > + > + pm-cntr@50000 { > + compatible = "arm,cci-550-pmu"; > + reg = <0x50000 0x10000>; > + }; > + > + pm-cntr@60000 { > + compatible = "arm,cci-550-pmu"; > + reg = <0x60000 0x10000>; > + }; > + > + pm-cntr@70000 { > + compatible = "arm,cci-550-pmu"; > + reg = <0x70000 0x10000>; > + }; > + > + pm-cntr@80000 { > + compatible = "arm,cci-550-pmu"; > + reg = <0x80000 0x10000>; > + }; > + }; > + > + timer: timer { > + compatible = "arm,armv8-timer"; > + interrupt-parent = <&gic>; > + interrupts = , > + , > + , > + ; > + }; > + > + gic: interrupt-controller@20000000 { > + compatible = "arm,gic-v3"; > + #interrupt-cells = <3>; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + interrupt-controller; > + reg = <0x0 0x20000000 0x0 0x10000>, /* GICD */ > + <0x0 0x20060000 0x0 0x100000>; /* GICR */ Same problems. > + > + interrupts = ; > + > + its: its@20040000 { > + compatible = "arm,gic-v3-its"; > + msi-controller; > + mbi-ranges = <256 224>; > + reg = <0x0 0x20040000 0x0 0x10000>; > + }; > + }; Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel