From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33A97C52D71 for ; Wed, 7 Aug 2024 14:17:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OYjWOa/hLPaVN5PNqXkqyI06NRvtLXymCzruaWqdxNg=; b=3af/w7AQTAFrrlCvX+7uK2qO25 JhVRSToxIZBZFBGok+x5VoGVjyqdOvC4563cNQeX6cSvy5F/ACV7NpoJXRmaPZM4KKrUkIuse9KFI EePk26c6V58Mwly1fpSs8G00MY88qiT2hcA0LmM3dJHNBR5IajZnvnolr3mp+QBHrt7leK6EbfdAg HKINSBfD4lNFAERACkEtFyIBaGcA0JS8rwTfiMaSeRO5dCU12QIANGDtGljmtJG+RL/hHJ/fGY9XK ng70OJ0LpxRegF1GaDwxm3XJ4Cz9rIwnuLI4Am42VWjU94RBNQ3GRpDt8rLer7QLBpFNzrrbzgYFr ucvPJK3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbhTg-00000005Imr-0fga; Wed, 07 Aug 2024 14:17:24 +0000 Received: from mail-qt1-x82f.google.com ([2607:f8b0:4864:20::82f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbhT7-00000005IdC-3M8W for linux-arm-kernel@lists.infradead.org; Wed, 07 Aug 2024 14:16:51 +0000 Received: by mail-qt1-x82f.google.com with SMTP id d75a77b69052e-44ff50affc5so9255541cf.1 for ; Wed, 07 Aug 2024 07:16:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1723040208; x=1723645008; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=OYjWOa/hLPaVN5PNqXkqyI06NRvtLXymCzruaWqdxNg=; b=aYokdwEYN0DQgtuFIwTgV6bof6asoG8NMkz4ewDRdkMIDWMXrQlgOHgNvabglxqA2m HPP2G/beqUm/PVVmumexjksq56IX8QHYbljsDbrYb3T1B/KPDB+8m1m1JyD9yTwBTiPo HwjFeu8D9MS0SDCLq2GLllltDWR7KfgI1D2Wg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723040208; x=1723645008; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OYjWOa/hLPaVN5PNqXkqyI06NRvtLXymCzruaWqdxNg=; b=SoDuJg13+ZvIteYwbZhxc1sAKwYS9QCJrIc9IP3n94DOG2Fm8T4SjaHFLY56D4S/UG RXFtBjCdfSTZohq/D4zFkQo6CgDlLzZTBaVhFZDdhV5eHq223nu7aJYTddiEP9S0i5y1 Ik8kVoPamsRSSoLUXNpQQzJjBQ0mNdRBvjn5b459kBsPnM9ch8MJJlevhCoa0QilVo2H 4nRv3LxRvxi8c2m0+90+pk5RJ95/kRInf9Qv135ywFnaD6Z+kSjDUs4QxcICribKnPvT 7Khxyf9ajpRKjIcgtdSufGSX04U/RnbQucbShhu1AIX/X8oemF/vfwFD4RzYQStvjSEj 36jw== X-Forwarded-Encrypted: i=1; AJvYcCV6eTNwdP7EOEo806kCBnxGsndTBPyQOvQMqapeOKl2QMC+uC2liHg97aHokuwPUdESPCOYpUCzpNy+GRjp9D722KyI0fBSC8TQ86BXkGXsHxXXV4A= X-Gm-Message-State: AOJu0YyNyjroHUZ23+ufVe3QVFBgPGYGyfbN1BYIpAXy3CssjQ3lyt0k EnSpLCMyzaUjE7Z73zxSZoSMDI2yRDAx1mOnvyubUfjKu2+DAdx4FFuCUaWUIQ== X-Google-Smtp-Source: AGHT+IG7K89vZilE6Sz2dUud7gYcixB3g1TtZS0AZlSh6gPKYmppOaVM05ZwsSY4/bwiVXdFFXwmvQ== X-Received: by 2002:ac8:5d8c:0:b0:447:dbe8:5268 with SMTP id d75a77b69052e-45189286d41mr213923601cf.37.1723040207539; Wed, 07 Aug 2024 07:16:47 -0700 (PDT) Received: from [192.168.1.3] (ip68-4-215-93.oc.oc.cox.net. [68.4.215.93]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-451c870066csm5317501cf.4.2024.08.07.07.16.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Aug 2024 07:16:46 -0700 (PDT) Message-ID: Date: Wed, 7 Aug 2024 07:16:44 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 09/12] PCI: brcmstb: Refactor for chips with many regular inbound windows To: Manivannan Sadhasivam , Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Stanimir Varbanov , Krzysztof Kozlowski , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list References: <20240731222831.14895-1-james.quinlan@broadcom.com> <20240731222831.14895-10-james.quinlan@broadcom.com> <20240807140401.GJ3412@thinkpad> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20240807140401.GJ3412@thinkpad> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240807_071650_056866_C8B07B94 X-CRM114-Status: GOOD ( 18.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/7/2024 7:04 AM, Manivannan Sadhasivam wrote: > On Wed, Jul 31, 2024 at 06:28:23PM -0400, Jim Quinlan wrote: >> Provide support for new chips with multiple inbound windows while >> keeping the legacy support for the older chips. >> >> In existing chips there are three inbound windows with fixed purposes: the >> first was for mapping SoC internal registers, the second was for memory, >> and the third was for memory but with the endian swapped. Typically, only >> one window was used. >> >> Complicating the inbound window usage was the fact that the PCIe HW would >> do a baroque internal mapping of system memory, and concatenate the regions >> of multiple memory controllers. >> >> Newer chips such as the 7712 and Cable Modem SOCs take a step forward and >> drop the internal mapping while providing for multiple inbound windows. >> This works in concert with the dma-ranges property, where each provided >> range becomes an inbound window. >> >> Signed-off-by: Jim Quinlan >> --- [snip] >> +static void set_inbound_win_registers(struct brcm_pcie *pcie, >> + const struct inbound_win *inbound_wins, >> + int num_inbound_wins) >> +{ >> + void __iomem *base = pcie->base; >> + int i; >> + >> + for (i = 1; i <= num_inbound_wins; i++) { >> + u64 pci_offset = inbound_wins[i].pci_offset; >> + u64 cpu_addr = inbound_wins[i].cpu_addr; >> + u64 size = inbound_wins[i].size; >> + u32 reg_offset = brcm_bar_reg_offset(i); >> + u32 tmp = lower_32_bits(pci_offset); >> + >> + u32p_replace_bits(&tmp, brcm_pcie_encode_ibar_size(size), >> + PCIE_MISC_RC_BAR1_CONFIG_LO_SIZE_MASK); >> + >> + /* Write low */ >> + writel(tmp, base + reg_offset); > > Can you use writel_relaxed() instead? Here and below. I don't see a necessity to > use the barrier that comes with non-relaxed version of writel. Out of curiosity what is the reasoning here for asking to use writel_relaxed(), this is not a hot path, this is a configuration path anyway. I am not certain clear on the implication of using writel_relaxed() on systems like 7712/2712 where the busing is different from the other STB chips. -- Florian