Re: [PATCH v2 0/4] Energy Model power in micro-Watts and SCMI v3.1 alignment

From: Lukasz Luba <lukasz.luba@arm.com>
To: rafael@kernel.org
Cc: daniel.lezcano@linaro.org, amitk@kernel.org,
	linux-pm@vger.kernel.org, rui.zhang@intel.com,
	viresh.kumar@linaro.org, dietmar.eggemann@arm.com, nm@ti.com,
	sboyd@kernel.org, linux-kernel@vger.kernel.org,
	sudeep.holla@arm.com, cristian.marussi@arm.com,
	matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/4] Energy Model power in micro-Watts and SCMI v3.1 alignment
Date: Fri, 15 Jul 2022 09:56:41 +0100	[thread overview]
Message-ID: <c334d692-9787-7591-54d7-f152ecbd559e@arm.com> (raw)
In-Reply-To: <41c333e1-2545-f6be-2db2-9061297d0b9a@arm.com>

Hi Rafael,

gentle ping.

On 7/7/22 11:46, Lukasz Luba wrote:
> Hi Rafael,
> 
> On 7/7/22 08:15, Lukasz Luba wrote:
>> Hi all,
>>
>> This is a patch set which changes Energy Model power values scale to
>> micro-Watts. It also upgrades the SCMI performance layer + scmi-cpufreq
>> driver to leverage the SCMI v3.1 spec and process micro-Watts power 
>> values
>> coming from FW. The higher precision in EM power field solves an issue
>> of a rounding error, which then can be misinterpreted as 'inefficient 
>> OPP'.
>> An example rounding issue calculation is present in patch 1/4 
>> description.
>>
>> Changes:
>> v2
>> - simplified 32bit checks for max number of CPUs preventing energy
>>    estimation overflow
>> - added Reviewed-by and ACKs
>> v1 [1]
>>
>> Regards,
>> Lukasz Luba
>>
>> [1] 
>> https://lore.kernel.org/lkml/20220622145802.13032-1-lukasz.luba@arm.com/
>>
>> Lukasz Luba (4):
>>    PM: EM: convert power field to micro-Watts precision and align drivers
>>    Documentation: EM: Switch to micro-Watts scale
>>    firmware: arm_scmi: Get detailed power scale from perf
>>    cpufreq: scmi: Support the power scale in micro-Watts in SCMI v3.1
>>
>>   Documentation/power/energy-model.rst  | 14 +++----
>>   drivers/cpufreq/mediatek-cpufreq-hw.c |  7 ++--
>>   drivers/cpufreq/scmi-cpufreq.c        | 15 +++++++-
>>   drivers/firmware/arm_scmi/perf.c      | 18 +++++----
>>   drivers/opp/of.c                      | 15 ++++----
>>   drivers/powercap/dtpm_cpu.c           |  5 +--
>>   drivers/thermal/cpufreq_cooling.c     | 13 ++++++-
>>   drivers/thermal/devfreq_cooling.c     | 19 ++++++++--
>>   include/linux/energy_model.h          | 54 +++++++++++++++++++--------
>>   include/linux/scmi_protocol.h         |  8 +++-
>>   kernel/power/energy_model.c           | 24 ++++++++----
>>   11 files changed, 132 insertions(+), 60 deletions(-)
>>
> 
> I got ACKs (and on Reviewed-by) for this patch set.
> Could you take this via your PM tree, please?

This patch set is on our roadmap and would be good if it could
go as v5.20 material.

There are Acks for these patch set. If you need some
help with this (like rebasing, etc), just ping me.

Could you take them, please?

Regards,
Lukasz

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel