Re: [PATCH v4 1/3] x86,fs/resctrl: Add resctrl_arch_preconvert_bw()

[Ben Horgan <ben.horgan@arm.com>]

Hi Reinette,

On 7/6/26 22:33, Reinette Chatre wrote:
> Hi Ben,
> 
> On 7/6/26 9:06 AM, Ben Horgan wrote:
>> On MPAM systems the rounding behaviour of the MBA control would be improved
>> if the rounding in the fs/resctrl code is removed but this is not the
>> case for x86. To allow any rounding or conversion of the bandwidth value
>> provided by the user to be specified by the arch code a new arch hook is
>> required.
>>
>> Introduce resctrl_arch_preconvert_bw(), and add its x86 implementation.
>> This is currently unused in resctrl but when plumbed in it will replace the
>> call to roundup() in bw_validate().
>>
>> Signed-off-by: Dave Martin <dave.martin@arm.com>
>> Signed-off-by: Ben Horgan <ben.horgan@arm.com>
> 
> This chain does not look right. The first SOB is expected to be from the
> author but the patch does not have Dave as author. 

Ah.. I've changed the author of this and the last patch to be Dave as he
wrote the code.

Thanks,

Ben

> 
>> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
>> ---
> 
> Reinette
>