From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20384C4345F for ; Fri, 12 Apr 2024 13:08:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nWmzJHUrdiSpJanLDi5W8zwi11c1Y8TAT+o3rv4XYkA=; b=0xUfdPpcOG2XTV v/wrGM6/C8x7RwriASGqQUhnKzce/7onc+3t0K+DelffW66qBJP+r6oMlzqnK/2nlnm7gR3zPemy1 qQxOOlar0eD0iqyVjmfFWdEVqknEYG3hSNPcK6U7iYyga8bPQUVMJbEFMDNt2U3nhwZViXRzerSvF wQXP7awI7XpDP+C9Kz4dx6DbZ4KqE3nHM4lq9C1AgY0fEnmO+XSzk4LB+4jS+xS8hKZDxalMxPk9v pEI/ceamj6qNXdt07Euvd3TdpP21W8HsxbNmdiLRNIQELqlfHWNV5ZO24KB48ap+tcMDZOqeey9MF baekudzikzAByuQ+vJbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvGdJ-0000000HEU6-1u7N; Fri, 12 Apr 2024 13:07:57 +0000 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvGdD-0000000HEQk-2sMK for linux-arm-kernel@lists.infradead.org; Fri, 12 Apr 2024 13:07:55 +0000 Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-a44ad785a44so103072166b.3 for ; Fri, 12 Apr 2024 06:07:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712927269; x=1713532069; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=9rn/zc6s/zD/8BUl/7+phShce3NbGsIX6yyn+LNAZyA=; b=VDz7gxQgE2zxN7yC7T76Dej0GZ9quapVOs56WxfH8YXtl6R1M3fQQS1pN5fRVuldf+ 0303xb3JqkSJAT0qwHBSjZKCm2aDSEAPwGbgDwaoha65GUOPpRouKyF2dNaNWNyVfUi6 8wVlcHcVm+bhzuXVufMNbPLwoMOYM+qLfSXAbm1snXwuJCisgJ76ZhJcD3J+LVy1oIn1 CpRTREZmjd2Fbv3jP3DVzFEwPglBrIgMeMzPHymER4zKbliCPNLPAoLSsBHxVVBINIVH INs8qleH39PdmSLGWAAkhHyw3oVJ9bLub1rBvO12DzyTL2d8aqLXALR6m/z/i9TiDWpY V1zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712927269; x=1713532069; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9rn/zc6s/zD/8BUl/7+phShce3NbGsIX6yyn+LNAZyA=; b=hoxy0f1GlVldlkjJIRS4gcSP0v7oizOUNWo+25D24lHrRm4tMQA/YoaLx0truGuC7o m8Z64ZRMbZ1300a3g6/xRhb/M4RghBtAShcipq0nWx6vXxO4BasEqVOLVY3WK5IpvFlZ dcC/vVw9smVqxExoBws859EsHQzDBcCTJC5gofi4R0yIObdI9woU35gwMmr86uoqG+Vr mK6shdRsdXD243vAh1oMt4gixXvuM6t8my31gzylJahoaK4AaaQXsDfGB8EG4S1Lh3Z6 s6nn8ehkWxyMLX0UN87L93Uz2LHdPoHvYlAEmY88a44+IfL5wDn55nkvjBuSdewAHDOF +TkA== X-Forwarded-Encrypted: i=1; AJvYcCVxGWnJ+aJsNjjfObIrgZfpyYxRxyyWPAODQxidW34lNi43Af1cfCzvo3adV8jzD/PJwzf2yqpQChyrC4ceEw4mvVeLdnUV2bBJFBLVmYA0kST6UiY= X-Gm-Message-State: AOJu0Yz31HadCnudfZOmi4sGug67vbKdXt072ni8NWppyhe+jbsrEmgS /o9IRZnSHv9z/a9rmN/1QwNfxt7ioHX/ai92hnrSRL/75RipuwbG X-Google-Smtp-Source: AGHT+IGfx5jSsh2DJtk5KqWm8cuRSCRSzcnIOqq1OfH9R7AjpPhkp/E/ljE6HxuOMN00Ckeivw9tfA== X-Received: by 2002:a17:906:3a85:b0:a51:fa56:4fc7 with SMTP id y5-20020a1709063a8500b00a51fa564fc7mr1614361ejd.21.1712927269211; Fri, 12 Apr 2024 06:07:49 -0700 (PDT) Received: from ?IPV6:2a01:c22:7a91:3c00:8c19:da9e:a091:c46c? (dynamic-2a01-0c22-7a91-3c00-8c19-da9e-a091-c46c.c22.pool.telefonica.de. [2a01:c22:7a91:3c00:8c19:da9e:a091:c46c]) by smtp.googlemail.com with ESMTPSA id ga31-20020a1709070c1f00b00a4e24d259edsm1786441ejc.167.2024.04.12.06.07.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Apr 2024 06:07:48 -0700 (PDT) Message-ID: Date: Fri, 12 Apr 2024 15:07:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] net: phy: phy_link_topology: Handle NULL topologies To: Maxime Chevallier , davem@davemloft.net Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Vladimir Oltean , =?UTF-8?Q?K=C3=B6ry_Maincent?= , Jesse Brandeburg , =?UTF-8?Q?Marek_Beh=C3=BAn?= , Piergiorgio Beruto , Oleksij Rempel , =?UTF-8?Q?Nicol=C3=B2_Veronese?= , Simon Horman , mwojtas@chromium.org, Nathan Chancellor References: <20240412104615.3779632-1-maxime.chevallier@bootlin.com> Content-Language: en-US From: Heiner Kallweit Autocrypt: addr=hkallweit1@gmail.com; keydata= xsFNBF/0ZFUBEAC0eZyktSE7ZNO1SFXL6cQ4i4g6Ah3mOUIXSB4pCY5kQ6OLKHh0FlOD5/5/ sY7IoIouzOjyFdFPnz4Bl3927ClT567hUJJ+SNaFEiJ9vadI6vZm2gcY4ExdIevYHWe1msJF MVE4yNwdS+UsPeCF/6CQQTzHc+n7DomE7fjJD5J1hOJjqz2XWe71fTvYXzxCFLwXXbBiqDC9 dNqOe5odPsa4TsWZ09T33g5n2nzTJs4Zw8fCy8rLqix/raVsqr8fw5qM66MVtdmEljFaJ9N8 /W56qGCp+H8Igk/F7CjlbWXiOlKHA25mPTmbVp7VlFsvsmMokr/imQr+0nXtmvYVaKEUwY2g 86IU6RAOuA8E0J5bD/BeyZdMyVEtX1kT404UJZekFytJZrDZetwxM/cAH+1fMx4z751WJmxQ J7mIXSPuDfeJhRDt9sGM6aRVfXbZt+wBogxyXepmnlv9K4A13z9DVLdKLrYUiu9/5QEl6fgI kPaXlAZmJsQfoKbmPqCHVRYj1lpQtDM/2/BO6gHASflWUHzwmBVZbS/XRs64uJO8CB3+V3fa cIivllReueGCMsHh6/8wgPAyopXOWOxbLsZ291fmZqIR0L5Y6b2HvdFN1Xhc+YrQ8TKK+Z4R mJRDh0wNQ8Gm89g92/YkHji4jIWlp2fwzCcx5+lZCQ1XdqAiHQARAQABzSZIZWluZXIgS2Fs bHdlaXQgPGhrYWxsd2VpdDFAZ21haWwuY29tPsLBjgQTAQgAOBYhBGxfqY/yOyXjyjJehXLe ig9U8DoMBQJf9GRVAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEHLeig9U8DoMSycQ AJbfg8HZEK0ljV4M8nvdaiNixWAufrcZ+SD8zhbxl8GispK4F3Yo+20Y3UoZ7FcIidJWUUJL axAOkpI/70YNhlqAPMsuudlAieeYZKjIv1WV5ucNZ3VJ7dC+dlVqQdAr1iD869FZXvy91KhJ wYulyCf+s4T9YgmLC6jLMBZghKIf1uhSd0NzjyCqYWbk2ZxByZHgunEShOhHPHswu3Am0ftt ePaYIHgZs+Vzwfjs8I7EuW/5/f5G9w1vibXxtGY/GXwgGGHRDjFM7RSprGOv4F5eMGh+NFUJ TU9N96PQYMwXVxnQfRXl8O6ffSVmFx4H9rovxWPKobLmqQL0WKLLVvA/aOHCcMKgfyKRcLah 57vGC50Ga8oT2K1g0AhKGkyJo7lGXkMu5yEs0m9O+btqAB261/E3DRxfI1P/tvDZpLJKtq35 dXsj6sjvhgX7VxXhY1wE54uqLLHY3UZQlmH3QF5t80MS7/KhxB1pO1Cpcmkt9hgyzH8+5org +9wWxGUtJWNP7CppY+qvv3SZtKJMKsxqk5coBGwNkMms56z4qfJm2PUtJQGjA65XWdzQACib 2iaDQoBqGZfXRdPT0tC1H5kUJuOX4ll1hI/HBMEFCcO8++Bl2wcrUsAxLzGvhINVJX2DAQaF aNetToazkCnzubKfBOyiTqFJ0b63c5dqziAgzsFNBF/0ZFUBEADF8UEZmKDl1w/UxvjeyAeX kghYkY3bkK6gcIYXdLRfJw12GbvMioSguvVzASVHG8h7NbNjk1yur6AONfbUpXKSNZ0skV8V fG+ppbaY+zQofsSMoj5gP0amwbwvPzVqZCYJai81VobefTX2MZM2Mg/ThBVtGyzV3NeCpnBa 8AX3s9rrX2XUoCibYotbbxx9afZYUFyflOc7kEpc9uJXIdaxS2Z6MnYLHsyVjiU6tzKCiVOU KJevqvzPXJmy0xaOVf7mhFSNQyJTrZpLa+tvB1DQRS08CqYtIMxRrVtC0t0LFeQGly6bOngr ircurWJiJKbSXVstLHgWYiq3/GmCSx/82ObeLO3PftklpRj8d+kFbrvrqBgjWtMH4WtK5uN5 1WJ71hWJfNchKRlaJ3GWy8KolCAoGsQMovn/ZEXxrGs1ndafu47yXOpuDAozoHTBGvuSXSZo ythk/0EAuz5IkwkhYBT1MGIAvNSn9ivE5aRnBazugy0rTRkVggHvt3/7flFHlGVGpBHxFUwb /a4UjJBPtIwa4tWR8B1Ma36S8Jk456k2n1id7M0LQ+eqstmp6Y+UB+pt9NX6t0Slw1NCdYTW gJezWTVKF7pmTdXszXGxlc9kTrVUz04PqPjnYbv5UWuDd2eyzGjrrFOsJEi8OK2d2j4FfF++ AzOMdW09JVqejQARAQABwsF2BBgBCAAgFiEEbF+pj/I7JePKMl6Fct6KD1TwOgwFAl/0ZFUC GwwACgkQct6KD1TwOgxUfg//eAoYc0Vm4NrxymfcY30UjHVD0LgSvU8kUmXxil3qhFPS7KA+ y7tgcKLHOkZkXMX5MLFcS9+SmrAjSBBV8omKoHNo+kfFx/dUAtz0lot8wNGmWb+NcHeKM1eb nwUMOEa1uDdfZeKef/U/2uHBceY7Gc6zPZPWgXghEyQMTH2UhLgeam8yglyO+A6RXCh+s6ak Wje7Vo1wGK4eYxp6pwMPJXLMsI0ii/2k3YPEJPv+yJf90MbYyQSbkTwZhrsokjQEaIfjrIk3 rQRjTve/J62WIO28IbY/mENuGgWehRlTAbhC4BLTZ5uYS0YMQCR7v9UGMWdNWXFyrOB6PjSu Trn9MsPoUc8qI72mVpxEXQDLlrd2ijEWm7Nrf52YMD7hL6rXXuis7R6zY8WnnBhW0uCfhajx q+KuARXC0sDLztcjaS3ayXonpoCPZep2Bd5xqE4Ln8/COCslP7E92W1uf1EcdXXIrx1acg21 H/0Z53okMykVs3a8tECPHIxnre2UxKdTbCEkjkR4V6JyplTS47oWMw3zyI7zkaadfzVFBxk2 lo/Tny+FX1Azea3Ce7oOnRUEZtWSsUidtIjmL8YUQFZYm+JUIgfRmSpMFq8JP4VH43GXpB/S OCrl+/xujzvoUBFV/cHKjEQYBxo+MaiQa1U54ykM2W4DnHb1UiEf5xDkFd4= In-Reply-To: <20240412104615.3779632-1-maxime.chevallier@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240412_060751_932104_7B7452FC X-CRM114-Status: GOOD ( 25.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12.04.2024 12:46, Maxime Chevallier wrote: > In situations where phylib is a module, the topology can be NULL as it's > not initialized at netdev creation. > What we see here is a bigger drawback of IS_REACHABLE(). For phylib it's false from net core, but true from r8169 driver. So topo_create is a stub, but topo_add is not. IS_REACHABLE() hides dependencies. topo_create et al don't really use something from phylib. Therefore, could/should it be moved to net core? At least for topo_create this would resolve the dependency. We could also add a config symbol and the PHY topology an optional extension of net core. > Allow passing a NULL topology pointer to phy_link_topo helpers. > > Signed-off-by: Maxime Chevallier > Closes: https://lore.kernel.org/netdev/2e11b89d-100f-49e7-9c9a-834cc0b82f97@gmail.com/ > Closes: https://lore.kernel.org/netdev/20240409201553.GA4124869@dev-arch.thelio-3990X/ > --- > > Hi, > > This patch fixes a commit that is in net-next, hence the net-next tag and the > lack of "Fixes" tag. > > Nathan, Heiner, can you confirm this solves what you're seeing ? > > I think we can improve on this solution by moving the topology init at > the first PHY insertion and clearing it at netdev destruction. > > Maxime > > drivers/net/phy/phy_link_topology.c | 10 +++++++++- > include/linux/phy_link_topology.h | 7 ++++++- > 2 files changed, 15 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/phy/phy_link_topology.c b/drivers/net/phy/phy_link_topology.c > index 985941c5c558..0f3973f07fac 100644 > --- a/drivers/net/phy/phy_link_topology.c > +++ b/drivers/net/phy/phy_link_topology.c > @@ -42,6 +42,9 @@ int phy_link_topo_add_phy(struct phy_link_topology *topo, > struct phy_device_node *pdn; > int ret; > > + if (!topo) > + return 0; > + > pdn = kzalloc(sizeof(*pdn), GFP_KERNEL); > if (!pdn) > return -ENOMEM; > @@ -93,7 +96,12 @@ EXPORT_SYMBOL_GPL(phy_link_topo_add_phy); > void phy_link_topo_del_phy(struct phy_link_topology *topo, > struct phy_device *phy) > { > - struct phy_device_node *pdn = xa_erase(&topo->phys, phy->phyindex); > + struct phy_device_node *pdn; > + > + if (!topo) > + return; > + > + pdn = xa_erase(&topo->phys, phy->phyindex); > > /* We delete the PHY from the topology, however we don't re-set the > * phy->phyindex field. If the PHY isn't gone, we can re-assign it the > diff --git a/include/linux/phy_link_topology.h b/include/linux/phy_link_topology.h > index 6b79feb607e7..21ca78127d0f 100644 > --- a/include/linux/phy_link_topology.h > +++ b/include/linux/phy_link_topology.h > @@ -40,7 +40,12 @@ struct phy_link_topology { > static inline struct phy_device * > phy_link_topo_get_phy(struct phy_link_topology *topo, u32 phyindex) > { > - struct phy_device_node *pdn = xa_load(&topo->phys, phyindex); > + struct phy_device_node *pdn; > + > + if (!topo) > + return NULL; > + > + pdn = xa_load(&topo->phys, phyindex); > > if (pdn) > return pdn->phy; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel