From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 773C3C48260 for ; Thu, 25 Jan 2024 10:12:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=StnF/O1sBvAPFja/NqK5dZqVbULkCar4TSqFUA+KB7w=; b=egE907IHzPwVxF sh+ugEKJBqm4WoGVZ9+UKSB/N/p7WdeBWYFikOEhao6e5HZwvsIPJ+m0Bd11D4KtEX2cY2GQZjcTJ NJa5ql2Tnv5aNfs7FR2vfgjIBANRORHImh5CiOedRbHfis8RkyLWoFNz69mKPJIuyhIcCRE12Ehfi R52MDFfj8CD1oLFBZMbstaAIdDC5+nClqYzchR46Am8SSq0/O9W6ly6GtwDgzmv1CmQgIc0mvpSqr U9XdO/PHoQxWdv2mekiutd0rx2saeSihUMSCsgHTpmUoqfnX5GCypw4smHxpmCdPuwpQT24DAs4jK 6q1+oieVbmGch+k9Rquw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSwiH-0001NG-03; Thu, 25 Jan 2024 10:12:01 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSwff-0000lu-0G for linux-arm-kernel@lists.infradead.org; Thu, 25 Jan 2024 10:09:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706177353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yWoYzQpHqgg6p1rlk03GKE1EaJ8e4bAmbUSX9Jtw5II=; b=dv9pxrp+nmtyOxz+wcJ0QFr62LqfEyp/bcdGjLRfZZcuWxm2VCNCARISHTE7SK/MpIPIpz NXCRacrNx/N9OxOuiGXPfzDcTK7Sc6JhkxH1UUdOx80jZslTnzvUFBzeLa3VMLPD7NK3ut UUjzC9k/wVOGWyI2cLtC1YyvrN9dS2E= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-592-s0h5VMzTOMqrnXD9h9-fUA-1; Thu, 25 Jan 2024 05:09:10 -0500 X-MC-Unique: s0h5VMzTOMqrnXD9h9-fUA-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-50e7329512cso1262298e87.1 for ; Thu, 25 Jan 2024 02:09:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706177349; x=1706782149; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yWoYzQpHqgg6p1rlk03GKE1EaJ8e4bAmbUSX9Jtw5II=; b=VS79JZW+uUW/k04pIZUNwe0qtqtucm2FNMk87F1cvwltptwoo0ayAot+Xgf7IfN0UT S16QGwcVkMFrnGwvsV6r/3PlhviXdh5rCUQvACcIcjO3zRoDK60aqOJYIW7/nu/HODva g1l+wLk5p6wxCCZXW7KLYX2zDfEKO1g6LHA/+5MSvxAKCGSkyVny5+zcko2MOaA/Fnku 4Op2zpE4sI8prl6+y3hM81OxI4EUJ685MKJL7y2pJZaNtJfhMrJ4yLzNT+lFocSatbCt 02nazTfpDKIKsB3xJ73VVh+J1lhG2mCmmNTcaiz4lPbin0LYDmXFjArFgQrM4zMKjkrs Gdrw== X-Gm-Message-State: AOJu0YwkbNwShIjkhMhgs4bHLHSG06wXwxV8j7x6gDlhjfZfleimS4hV H4gWNEfenHt/8SAnVimwSUpaoD7ty1qoc4AhF+L3f6mR6LTKWHwvfFUzO+QgSqV6hU2PKZ8jIwO oU6mklsWPeJ0Pau6TEmhny24Hl75qqjl5So0VJs/kpY2CmOZD3JsLJe9bNZDml11l6B4GTD78 X-Received: by 2002:ac2:4d9b:0:b0:510:1566:31ce with SMTP id g27-20020ac24d9b000000b00510156631cemr794328lfe.3.1706177349260; Thu, 25 Jan 2024 02:09:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IHe3B8xKCMAJ4wJGZwfJsCX0GVsfC5KHo76YW2BpN7eKcJrIqIpXpnzx3Vg8kFxSI2HVPfSsw== X-Received: by 2002:ac2:4d9b:0:b0:510:1566:31ce with SMTP id g27-20020ac24d9b000000b00510156631cemr794308lfe.3.1706177348841; Thu, 25 Jan 2024 02:09:08 -0800 (PST) Received: from gerbillo.redhat.com (146-241-244-75.dyn.eolo.it. [146.241.244.75]) by smtp.gmail.com with ESMTPSA id bi24-20020a05600c3d9800b0040ec8118b61sm2000025wmb.17.2024.01.25.02.09.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 02:09:08 -0800 (PST) Message-ID: Subject: Re: [PATCH net] net: stmmac: xgmac: fix safety error descriptions From: Paolo Abeni To: Furong Xu <0x1207@gmail.com>, Serge Semin Cc: "David S. Miller" , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Maxime Coquelin , Joao Pinto , Simon Horman , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, xfr@outlook.com, rock.xu@nio.com Date: Thu, 25 Jan 2024 11:09:06 +0100 In-Reply-To: <20240125103454.0000312a@gmail.com> References: <20240123085037.939471-1-0x1207@gmail.com> <20240125103454.0000312a@gmail.com> Autocrypt: addr=pabeni@redhat.com; prefer-encrypt=mutual; keydata=mQINBGISiDUBEAC5uMdJicjm3ZlWQJG4u2EU1EhWUSx8IZLUTmEE8zmjPJFSYDcjtfGcbzLPb63BvX7FADmTOkO7gwtDgm501XnQaZgBUnCOUT8qv5MkKsFH20h1XJyqjPeGM55YFAXc+a4WD0YyO5M0+KhDeRLoildeRna1ey944VlZ6Inf67zMYw9vfE5XozBtytFIrRyGEWkQwkjaYhr1cGM8ia24QQVQid3P7SPkR78kJmrT32sGk+TdR4YnZzBvVaojX4AroZrrAQVdOLQWR+w4w1mONfJvahNdjq73tKv51nIpu4SAC1Zmnm3x4u9r22mbMDr0uWqDqwhsvkanYmn4umDKc1ZkBnDIbbumd40x9CKgG6ogVlLYeJa9WyfVMOHDF6f0wRjFjxVoPO6p/ZDkuEa67KCpJnXNYipLJ3MYhdKWBZw0xc3LKiKc+nMfQlo76T/qHMDfRMaMhk+L8gWc3ZlRQFG0/Pd1pdQEiRuvfM5DUXDo/YOZLV0NfRFU9SmtIPhbdm9cV8Hf8mUwubihiJB/9zPvVq8xfiVbdT0sPzBtxW0fXwrbFxYAOFvT0UC2MjlIsukjmXOUJtdZqBE3v3Jf7VnjNVj9P58+MOx9iYo8jl3fNd7biyQWdPDfYk9ncK8km4skfZQIoUVqrWqGDJjHO1W9CQLAxkfOeHrmG29PK9tHIwARAQABtB9QYW9sbyBBYmVuaSA8cGFiZW5pQHJlZGhhdC5jb20+iQJSBBMBCAA8FiEEg1AjqC77wbdLX2LbKSR5jcyPE6QFAmISiDUCGwMFCwkIBwIDIgIBBhUKCQgLAgQWAgMBAh4HAheAAAoJECkkeY3MjxOkJSYQAJcc6MTsuFxYdYZkeWjW//zbD3ApRHzpNlHLVSuJqHr9/aDS+tyszgS8jj9MiqALzgq4iZbg 7ZxN9ZsDL38qVIuFkSpgMZCiUHdxBC11J8nbBSLlpnc924UAyr5XrGA99 6Wl5I4Km3128GY6iAkH54pZpOmpoUyBjcxbJWHstzmvyiXrjA2sMzYjt3Xkqp0cJfIEekOi75wnNPofEEJg28XPcFrpkMUFFvB4Aqrdc2yyR8Y36rbw18sIX3dJdomIP3dL7LoJi9mfUKOnr86Z0xltgcLPGYoCiUZMlXyWgB2IPmmcMP2jLJrusICjZxLYJJLofEjznAJSUEwB/3rlvFrSYvkKkVmfnfro5XEr5nStVTECxfy7RTtltwih85LlZEHP8eJWMUDj3P4Q9CWNgz2pWr1t68QuPHWaA+PrXyasDlcRpRXHZCOcvsKhAaCOG8TzCrutOZ5NxdfXTe3f1jVIEab7lNgr+7HiNVS+UPRzmvBc73DAyToKQBn9kC4jh9HoWyYTepjdcxnio0crmara+/HEyRZDQeOzSexf85I4dwxcdPKXv0fmLtxrN57Ae82bHuRlfeTuDG3x3vl/Bjx4O7Lb+oN2BLTmgpYq7V1WJPUwikZg8M+nvDNcsOoWGbU417PbHHn3N7yS0lLGoCCWyrK1OY0QM4EVsL3TjOfUtCNQYW9sbyBBYmVuaSA8cGFvbG8uYWJlbmlAZ21haWwuY29tPokCUgQTAQgAPBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEoitAhsDBQsJCAcCAyICAQYVCgkICwIEFgIDAQIeBwIXgAAKCRApJHmNzI8TpBzHD/45pUctaCnhee1vkQnmStAYvHmwrWwIEH1lzDMDCpJQHTUQOOJWDAZOFnE/67bxSS81Wie0OKW2jvg1ylmpBA0gPpnzIExQmfP72cQ1TBoeVColVT6Io35BINn+ymM7c0Bn8RvngSEpr3jBtqvvWXjvtnJ5/HbOVQCg62NC6ewosoKJPWpGXMJ9SKsVIOUHsmoWK60spzeiJoSmAwm3zTJQnM5kRh2q iWjoCy8L35zPqR5TV+f5WR5hTVCqmLHSgm1jxwKhPg9L+GfuE4d0SWd84y GeOB3sSxlhWsuTj1K6K3MO9srD9hr0puqjO9sAizd0BJP8ucf/AACfrgmzIqZXCfVS7jJ/M+0ic+j1Si3yY8wYPEi3dvbVC0zsoGj9n1R7B7L9c3g1pZ4L9ui428vnPiMnDN3jh9OsdaXeWLvSvTylYvw9q0DEXVQTv4/OkcoMrfEkfbXbtZ3PRlAiddSZA5BDEkkm6P9KA2YAuooi1OD9d4MW8LFAeEicvHG+TPO6jtKTacdXDRe611EfRwTjBs19HmabSUfFcumL6BlVyceIoSqXFe5jOfGpbBevTZtg4kTSHqymGb6ra6sKs+/9aJiONs5NXY7iacZ55qG3Ib1cpQTps9bQILnqpwL2VTaH9TPGWwMY3Nc2VEc08zsLrXnA/yZKqZ1YzSY9MGXWYLkCDQRiEog1ARAAyXMKL+x1lDvLZVQjSUIVlaWswc0nV5y2EzBdbdZZCP3ysGC+s+n7xtq0o1wOvSvaG9h5q7sYZs+AKbuUbeZPu0bPWKoO02i00yVoSgWnEqDbyNeiSW+vI+VdiXITV83lG6pS+pAoTZlRROkpb5xo0gQ5ZeYok8MrkEmJbsPjdoKUJDBFTwrRnaDOfb+Qx1D22PlAZpdKiNtwbNZWiwEQFm6mHkIVSTUe2zSemoqYX4QQRvbmuMyPIbwbdNWlItukjHsffuPivLF/XsI1gDV67S1cVnQbBgrpFDxN62USwewXkNl+ndwa+15wgJFyq4Sd+RSMTPDzDQPFovyDfA/jxN2SK1Lizam6o+LBmvhIxwZOfdYH8bdYCoSpqcKLJVG3qVcTwbhGJr3kpRcBRz39Ml6iZhJyI3pEoX3bJTlR5Pr1Kjpx13qGydSMos94CIYWAKhegI06aTdvvuiigBwjngo/Rk5S+iEGR5KmTqGyp27o6YxZy6D4NIc6PKUzhIUxfvuHNvfu sD2W1U7eyLdm/jCgticGDsRtweytsgCSYfbz0gdgUuL3EBYN3JLbAU+UZpy v/fyD4cHDWaizNy/KmOI6FFjvVh4LRCpGTGDVPHsQXaqvzUybaMb7HSfmBBzZqqfVbq9n5FqPjAgD2lJ0rkzb9XnVXHgr6bmMRlaTlBMAEQEAAYkCNgQYAQgAIBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEog1AhsMAAoJECkkeY3MjxOkY1YQAKdGjHyIdOWSjM8DPLdGJaPgJdugHZowaoyCxffilMGXqc8axBtmYjUIoXurpl+f+a7S0tQhXjGUt09zKlNXxGcebL5TEPFqgJTHN/77ayLslMTtZVYHE2FiIxkvW48yDjZUlefmphGpfpoXe4nRBNto1mMB9Pb9vR47EjNBZCtWWbwJTIEUwHP2Z5fV9nMx9Zw2BhwrfnODnzI8xRWVqk7/5R+FJvl7s3nY4F+svKGD9QHYmxfd8Gx42PZc/qkeCjUORaOf1fsYyChTtJI4iNm6iWbD9HK5LTMzwl0n0lL7CEsBsCJ97i2swm1DQiY1ZJ95G2Nz5PjNRSiymIw9/neTvUT8VJJhzRl3Nb/EmO/qeahfiG7zTpqSn2dEl+AwbcwQrbAhTPzuHIcoLZYV0xDWzAibUnn7pSrQKja+b8kHD9WF+m7dPlRVY7soqEYXylyCOXr5516upH8vVBmqweCIxXSWqPAhQq8d3hB/Ww2A0H0PBTN1REVw8pRLNApEA7C2nX6RW0XmA53PIQvAP0EAakWsqHoKZ5WdpeOcH9iVlUQhRgemQSkhfNaP9LqR1XKujlTuUTpoyT3xwAzkmSxN1nABoutHEO/N87fpIbpbZaIdinF7b9srwUvDOKsywfs5HMiUZhLKoZzCcU/AEFjQsPTATACGsWf3JYPnWxL9 User-Agent: Evolution 3.50.3 (3.50.3-1.fc39) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240125_020919_215958_7C7DE736 X-CRM114-Status: GOOD ( 21.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2024-01-25 at 10:34 +0800, Furong Xu wrote: > On Wed, 24 Jan 2024 17:25:27 +0300 > Serge Semin wrote: > > > On Tue, Jan 23, 2024 at 04:50:37PM +0800, Furong Xu wrote: > > > Commit 56e58d6c8a56 ("net: stmmac: Implement Safety Features in > > > XGMAC core") prints safety error descriptions when safety error assert, > > > but missed some special errors, and mixed correctable errors and > > > uncorrectable errors together. > > > This patch complete the error code list and print the type of errors. > > > > The XGMAC ECC Safety code has likely been just copied from the DW GMAC > > v5 (DW QoS Eth) part. So this change is partly relevant to that code too. I > > can't confirm that the special errors support is relevant to the DW > > QoS Eth too (it likely is though), so what about splitting this patch > > up into two: > > 1. Elaborate the errors description for DW GMAC v5 and DW XGMAC. > > 2. Add new ECC safety errors support. > > ? > > > > On the other hand if we were sure that both DW QoS Eth and XGMAC > > safety features implementation match the ideal solution would be to > > refactor out the common code into a dedicated module. > > > > -Serge(y) > > > > Checked XGMAC Version 3.20a and DW QoS Eth Version 5.20a, the safety error > code definitions are not identical at all, they do have some differences, > about more than 20 bits of status register are different. > I think we should just leave them in individual implementations. @Serge: given the above, would you still advice for splitting this patch into 2? Thanks, Paolo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel