From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E2B7C982D8 for ; Fri, 18 Sep 2026 21:21:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=o3AIqpCx1xGDSyIic5bd3W6l+0N3zsLVo4Tor3degLA=; b=VLelVAmW1LcWWpMQ2Ma/2uQstQ +IgHmW97CgMEjL5qQen9yuySlw+c2JY7pt9tPKbz/V2y67Cvu5N+o7g4NTL2cPPRpmqOY9LSqvGzC wgtOFHly1Ulh2PFd11v1L7goU1kvR9elLzsHiAUfiq6QnlakPIznrnpdVhpS8aE12PMQD2b9ICntT QQgdWehnSMcYW9j4LvIKpWmxwM0CoA/Hlbl4nmAIXgpjw0tXPlmU0A08jmt50fkzu2fFmTQ+7FWS+ QAXy/0InI1bb4ILJGCAYZwttKRXv6MnJCBVI3qtoVb4LN5oU7k9KY3j7NKdLwWGROdtsfiIoF4OR1 L35YT/zQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7g1L-0000000FYr1-2X3F; Fri, 18 Sep 2026 21:21:23 +0000 Received: from sender4-pp-f112.zoho.com ([136.143.188.112]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7g1J-0000000FYqX-30hZ; Fri, 18 Sep 2026 21:21:22 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1789766477; cv=none; d=zohomail.com; s=zohoarc; b=ZRTPs+/EQn6AzTGcOTrIbRhRrGLanIGQioKhMY1bIqzFOpYljLMSAWgLVX4dAw6keghmfU8OJpFdEroBzPej1tDz9Doh0X9S3K258mM/BCTKdBBXYz6ruR9nZWMw2cVaZbO5YmT7jDKytf6ZfySLtcFuiAPVp4/qgqc2yoTG7Oo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789766477; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=o3AIqpCx1xGDSyIic5bd3W6l+0N3zsLVo4Tor3degLA=; b=TJRg6etdGn4KnZZ5H8DyjVpjloCwlQlKaMtzwgvsGQPa3a3IdzJzDoRdTsekyjNxr8SVahj+9y0QJGp8D+oMG/+rguHShBqvbsOXMyAM84qtdd+cBYWXgKVhvBn4gbWQsC3cn58rJrQ+qyw3HHAUOs30RurVTR57QzUNjpKU7nQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=michael.riesch@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1789766477; s=zohomail; d=collabora.com; i=michael.riesch@collabora.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=o3AIqpCx1xGDSyIic5bd3W6l+0N3zsLVo4Tor3degLA=; b=B3pnhjhLpfd3841dq7Q6zohkaeJnGM8mGeORhvnmjlo+ROGq6yAEjqC+Dj6cQIDU fekNUYdo84Yig+aeNdLrVIJGmHp38/wEaqBC1/0yQxH0a+iBP7QyUVPbbR6RYMEUR8o fF3bMYeBGjKVktReAuCls7H0jSUlxHB34sZbTygk= Received: by smtp.zohomail.com with SMTPS id 1789766475322457.08237500283667; Fri, 18 Sep 2026 14:21:15 -0700 (PDT) Message-ID: Date: Fri, 18 Sep 2026 23:21:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] media: dt-bindings: add rockchip rk3576 vicap To: Amin Gattout , Mehdi Djait , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260915-vicap-rk3576-v1-0-d3f5eb58a0b5@gmail.com> <20260915-vicap-rk3576-v1-1-d3f5eb58a0b5@gmail.com> Content-Language: en-US From: Michael Riesch In-Reply-To: <20260915-vicap-rk3576-v1-1-d3f5eb58a0b5@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260918_142121_807551_E2A48E08 X-CRM114-Status: GOOD ( 17.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Amin, Thanks for the patch, LGTM! On 9/15/26 14:27, Amin Gattout wrote: > Add the compatible for the Video Capture (VICAP) unit of the Rockchip > RK3576. This variant features five MIPI CSI-2 ports and a connection > to the image signal processor (ISP). The pixel clock of each MIPI port > enters the VICAP through a dedicated gate in the clock and reset unit, > so the variant takes five interface clocks and five interface resets > in addition to the aclk, hclk and dclk of the other variants. > > Signed-off-by: Amin Gattout Reviewed-by: Michael Riesch Best regards, Michael > --- > .../bindings/media/rockchip,rk3568-vicap.yaml | 46 +++++++++++++++++++++- > 1 file changed, 45 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/rockchip,rk3568-vicap.yaml b/Documentation/devicetree/bindings/media/rockchip,rk3568-vicap.yaml > index 080b64503b1b..b7dfaf3b378d 100644 > --- a/Documentation/devicetree/bindings/media/rockchip,rk3568-vicap.yaml > +++ b/Documentation/devicetree/bindings/media/rockchip,rk3568-vicap.yaml > @@ -15,6 +15,10 @@ description: > the data from camera sensors, video decoders, or other companion ICs and > transfers it into system main memory by AXI bus. > > + The Rockchip RK3576 Video Capture (VICAP) is similar to its RK3568 > + counterpart, but features five MIPI CSI-2 ports and an additional > + connection to the image signal processor (ISP) block. > + > The Rockchip RK3588 Video Capture (VICAP) is similar to its RK3568 > counterpart, but features six MIPI CSI-2 ports and additional connections > to the image signal processor (ISP) blocks. > @@ -23,6 +27,7 @@ properties: > compatible: > enum: > - rockchip,rk3568-vicap > + - rockchip,rk3576-vicap > - rockchip,rk3588-vicap > > reg: > @@ -33,7 +38,7 @@ properties: > > clocks: > minItems: 4 > - maxItems: 5 > + maxItems: 8 > > clock-names: > items: > @@ -42,6 +47,9 @@ properties: > - const: dclk > - const: iclk > - const: iclk1 > + - const: iclk2 > + - const: iclk3 > + - const: iclk4 > minItems: 4 > > iommus: > @@ -221,6 +229,40 @@ allOf: > > port@11: false > > + - if: > + properties: > + compatible: > + contains: > + const: rockchip,rk3576-vicap > + then: > + properties: > + clocks: > + minItems: 8 > + > + clock-names: > + minItems: 8 > + > + resets: > + minItems: 8 > + maxItems: 8 > + > + reset-names: > + items: > + - const: arst > + - const: hrst > + - const: drst > + - const: irst0 > + - const: irst1 > + - const: irst2 > + - const: irst3 > + - const: irst4 > + > + ports: > + properties: > + port@6: false > + > + port@11: false > + > - if: > properties: > compatible: > @@ -230,9 +272,11 @@ allOf: > properties: > clocks: > minItems: 5 > + maxItems: 5 > > clock-names: > minItems: 5 > + maxItems: 5 > > resets: > minItems: 9 >