From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B30BC433E1 for ; Fri, 24 Jul 2020 07:30:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF0122065E for ; Fri, 24 Jul 2020 07:30:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="i8sa6A2z"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="Fr77JvZc"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="unX9TgIs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF0122065E Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DqcMiN3Ovi6nFoNLbGj7A0lPkyq1SOo/5PPASNjPA4k=; b=i8sa6A2zH+DKjZUDtP5/Kpy4G /PlSgNmbCz/pW0rS+GVCwpTHUr+JrA6IUrynV6IaXnN/WlWIRlRsG8MXIRL/XSVp706VS83vYjx89 cOatpWBUw52j8UA1ehzP+lFXYfYKIqVhryB/3cMtyaYRBrXNr/PRBZsrMFBZaPSq3ME5H3TIph0VY N++83hqtU2qV+3LqC6CiWme7/5oR8x6MybRF31V9qzaHWgoSo+s6HosuqpUifHoJpwhdxW2sos3fu cPUz1qG+XAtc6iJ9CexvmVuvysMmW3PJmjcUfa0NqJeO8xObwptWyOttQj8jeeO8NXiQT5UquJJxT /YyLAFMsA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jys8Z-0005sH-Fo; Fri, 24 Jul 2020 07:28:59 +0000 Received: from esa4.microchip.iphmx.com ([68.232.154.123]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jys8V-0005rE-Dt for linux-arm-kernel@lists.infradead.org; Fri, 24 Jul 2020 07:28:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1595575735; x=1627111735; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=ItbYPIzTUu13yh+phgPg6OerWttch76Z9MoU2aQdJz0=; b=Fr77JvZcEeunvJQdojHfDFM0YtEg6/vTOk1BbI2ZOKR1+A8ulmhw6mqj 8qpv54a4viBIrXOb9wyKy7ZmS5HbmhBU7by6ZfyT8LaiowG5rW3M6DhH0 LUzCXnXtYud5mjJnyea4MjsoMdvuVofNmTYRuijt37FTA20iGjx4GqXYB fwj+uIPkn6OGbuV/HGBizsGcZX/3kwsQTSapDUTlL3hE0XJtjThSbQJ7G g3Rsm93JPkitZknB7MMHMA4cNNeJmViBBRwlapI+Ev/ilZz8ayOTi5+nN VdK+qkZeZB/rOAFOPmpAMOlJRa16xmdttQHW0MpflS+zjYE0DaKMYvDhY A==; IronPort-SDR: nuAOv8QwVt6Z8qEIWIxUywitdv2Z6CEBgYm1tByNTx3/BriG6na3UfueE5dbNKjQnxOjM7o6kI 3hxt2AWhle6w9sww/Vgmc/A5c3SjRvvc4f26XLwzwpi0JCQGSAKqjTHF0Jw9txBmMLGi2IZ801 g4tutu8HbbzKxZfgWZfBOR0jSAXedgZuvBzozo9BNnkI6aY45wAx1xGpNlwwtYOA8T5yYICpop 4TNUQfiZSuMyNCsCk6lXUbnfYS02UgqycISMyE+TTXw+ypG9dN1PwpC3qZZe5Fy1VP6CHNbBIj InU= X-IronPort-AV: E=Sophos;i="5.75,389,1589266800"; d="scan'208";a="81144471" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 24 Jul 2020 00:28:52 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Fri, 24 Jul 2020 00:28:45 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3 via Frontend Transport; Fri, 24 Jul 2020 00:28:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HfVnxUZgBFWY8OdcZUb5HoK5t8r7FhDjOYlrQ0Sv11nJAPSQU9dNpfbCl5jHpOwp40+9v61OZgi2eb34/8SCwThWvjC43YT/noy1Q8nwAm4B6jzaOo1QX749tM1h0LMDQ/Nx3wqJkEJ4G4HHYo0B1QICBh72vCfdlihByCJmC02ouZ4AMnr5/VA9fgzADgxq0R+7knOgHPSqiM0sJYFybqOY2QSXIqKTXuSc3YLu2RIqQFJVmNlqw66z6oK2H5vq1icibCFna64IlOMjVlY3uwcTr7rJjqzQNBcPJ13S3XUHv1CxQalBjjenJvt8bzt5oHkg7KNdPWto4UrbJ0CObA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ItbYPIzTUu13yh+phgPg6OerWttch76Z9MoU2aQdJz0=; b=K5YBm77D4YQUtpDsQ+MdsBEzjIWSKrbb8WpjxL/sDFXcZ2JWWaKoETGkxfMAPHBeROrsIpPGNKvGt5DW1lJDua4neDYT+Nc6+8lSwhbydfKcGPLXie4Ct+SsgVrzsMTCs0ADN/YxhxW1nSaSs+pH3ne41X3HoWiuneWG0UgLL295qBlWBOjnclih30TpesIbusDL6+YI584n5W00CWOXbuNtYDEOadJk1mu5KiW8rYYw8g8OiUugTba+lLNYDD2eSNHyXtf2RJ4jCgAtf0OWT5GIU648F0rANWaKI0H5GB2puq8iOVGbee1qzehh5WoMHiPgh9ydQIDQZw2F+a+j0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ItbYPIzTUu13yh+phgPg6OerWttch76Z9MoU2aQdJz0=; b=unX9TgIsdJBx/FqM6wfG2xlwEe2HGuY2mAdSthrWPrH0rhGwiIp6Al1a6Q6GNuxh73a7fY+0aD9h8XhdwEFllYTcczXsTOeHqxaUTfqRvzv5K0VA1jnN3ujLnQ2im9IOED/O1f0FMiI3ib+NM77YHitG+SQdpOLeyx/3zsefcME= Received: from SN6PR11MB3422.namprd11.prod.outlook.com (2603:10b6:805:da::18) by SN6PR11MB3021.namprd11.prod.outlook.com (2603:10b6:805:d1::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17; Fri, 24 Jul 2020 07:28:39 +0000 Received: from SN6PR11MB3422.namprd11.prod.outlook.com ([fe80::8964:f2f1:afb8:27f7]) by SN6PR11MB3422.namprd11.prod.outlook.com ([fe80::8964:f2f1:afb8:27f7%6]) with mapi id 15.20.3216.020; Fri, 24 Jul 2020 07:28:39 +0000 From: To: , , , , , Subject: Re: [PATCH net-next v2 3/7] net: macb: parse PHY nodes found under an MDIO node Thread-Topic: [PATCH net-next v2 3/7] net: macb: parse PHY nodes found under an MDIO node Thread-Index: AQHWYYwMmD+BfB7F50+r6VDdk0f0lA== Date: Fri, 24 Jul 2020 07:28:39 +0000 Message-ID: References: <20200721171316.1427582-1-codrin.ciubotariu@microchip.com> <20200721171316.1427582-4-codrin.ciubotariu@microchip.com> <460e5f3d-f3a0-154e-d617-d1536c96e390@gmail.com> In-Reply-To: <460e5f3d-f3a0-154e-d617-d1536c96e390@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=microchip.com; x-originating-ip: [82.137.16.151] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 432a70c6-70a8-406f-f484-08d82fa32f81 x-ms-traffictypediagnostic: SN6PR11MB3021: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-bypassexternaltag: True x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ykFFsuL0/Zb0kc7vGJmuD0TiOI/b6Eyk8isCURwjOW1rCJXrdo93VvRfBeldEPzI9sO6swcnyMTTz1q4kbo1ojNyqYhNPERZna+tBw0gvd05W0m9zIrDVhNd/cAev2Gz2I9AUehfIoQth/Wh8KfN3SdVY4xXpSNdCF5ndHeF31j97sGDsWDwEfbIzRPL5VPKwIPytC6IyaejLbOOHeKNpjiK2ZaP5bto65jIUXlAg+N/jR58qyRtS27L38IpXwklEtHRxSVI9XHud6iuBIIgw02OetAlHchDDMVxZiqtSJH6p1ot+H5EL4nqGOtPcka8ffunSHFwnKicG4LIdV0ef1DpM/j5NHDhj9AI95dlfB6v1BHOgkPBg/MpgZ+BYgmz x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3422.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(346002)(136003)(396003)(376002)(39860400002)(366004)(54906003)(110136005)(31686004)(26005)(53546011)(107886003)(7416002)(6506007)(2906002)(5660300002)(36756003)(4326008)(66476007)(478600001)(71200400001)(8936002)(31696002)(186003)(86362001)(76116006)(64756008)(66946007)(316002)(6512007)(66446008)(6486002)(2616005)(66556008)(8676002)(91956017)(43740500002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: Uybk//gQSUyAwgGDWYZv27KQB2BtKPiYYQeexG7Pc0/va04VvLAQlmuRKlUrm3kEX+VMYjEFon9tXQOHF+ksXM399efUkVb8+z1wvPkQC8M/hDdfkC4WriMMGRmPSqPgQ5IFM7MUW4P2J8TJ6ba+WDaL6Hs8WaZpdSAy89VGw3vj2L2tnyv0TOsea0lHjkBalsIJ858JJuPuKtEWN2N4RGXsdjJjCxo5ESZ0c3FtWrKRy/v6ySl5bLadwNjAobCpokEMUJXiS03bUmllhijANRUcwz6ao2J3exJUAP/m26xw2DI9LMCiaYqevgb8AM/LqUHbX4S0qS2RfZG8tkWtYp2zOiwtXgcmdYfkHQcBhWtgR17iqhsigT7EYjAMoM/p6UFOTdfborYWzPK1jNNwd3GQLrFb0bZRH48tfKlZtRMdxkMBxWRwJdo5r7ZvyS1eukHbn5fXrtFFPoeUDervaNEQy2lxRQcfGyu7kA7B6Hg= Content-ID: <537F9F333B85FF4C91A3EE1A831CDD77@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3422.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 432a70c6-70a8-406f-f484-08d82fa32f81 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2020 07:28:39.4186 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1FWQ5kqU0UJIN7aV6DASgInjT/+Z1vN7DcdcQqn5eGBKua89aoS3H4wTBKeoXtsZNaQiRWYjN3bn98FRSDfSDkDCa57p1ktFxTz1Yvo2Y+o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3021 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200724_032855_792073_80A82B21 X-CRM114-Status: GOOD ( 23.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew@lunn.ch, alexandre.belloni@bootlin.com, Ludovic.Desroches@microchip.com, robh+dt@kernel.org, kuba@kernel.org, davem@davemloft.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23.07.2020 21:59, Florian Fainelli wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 7/21/20 10:13 AM, Codrin Ciubotariu wrote: >> The MACB embeds an MDIO bus controller. For this reason, the PHY nodes >> were represented as sub-nodes in the MACB node. Generally, the >> Ethernet controller is different than the MDIO controller, so the PHYs >> are probed by a separate MDIO driver. Since adding the PHY nodes directly >> under the ETH node became deprecated, we adjust the MACB driver to look >> for an MDIO node and register the subnode MDIO devices. >> >> Signed-off-by: Codrin Ciubotariu >> --- >> >> Changes in v2: >> - readded newline removed by mistake; >> >> drivers/net/ethernet/cadence/macb_main.c | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c >> index 89fe7af5e408..b25c64b45148 100644 >> --- a/drivers/net/ethernet/cadence/macb_main.c >> +++ b/drivers/net/ethernet/cadence/macb_main.c >> @@ -740,10 +740,20 @@ static int macb_mii_probe(struct net_device *dev) >> static int macb_mdiobus_register(struct macb *bp) >> { >> struct device_node *child, *np = bp->pdev->dev.of_node; >> + struct device_node *mdio_node; >> + int ret; >> >> if (of_phy_is_fixed_link(np)) >> return mdiobus_register(bp->mii_bus); > > Does not this need changing as well? Consider the use case of having > your MACB Ethernet node have a fixed-link property to describe how it > connects to a switch, and your MACB MDIO controller, expressed as a > sub-node, describing the MDIO attached switch it connects to. Just asking, does this worth having/changing it as long as there is no in kernel board/configuration that could benefit off? Thank you, Claudiu Beznea > >> >> + /* if an MDIO node is present, it should contain the PHY nodes */ >> + mdio_node = of_get_child_by_name(np, "mdio"); >> + if (mdio_node) { >> + ret = of_mdiobus_register(bp->mii_bus, mdio_node); >> + of_node_put(mdio_node); >> + return ret; >> + } >> + >> /* Only create the PHY from the device tree if at least one PHY is >> * described. Otherwise scan the entire MDIO bus. We do this to support >> * old device tree that did not follow the best practices and did not >> > > > -- > Florian > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel