From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34249C433FE for ; Wed, 26 Oct 2022 12:32:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3NC47HOSXTSkxJ996mSO+QK1Qu2rzRggCtI/GzjZGg8=; b=rEpPnn64oDlE/f GvGyQDUQqpmfi7qm6cYOC9tNtf2g+8UtA4xdYFIVBzuBqA7z7exr3an/RispVn4KKFOwww5AsjC18 Lb0H6YZ3uXkCivuVqPA33QJAUuRtigAKis5zIJHgQRgtw9Q00WX9SkyCZ5m0jocNKXs38Qxk7CGMv jQEPmw+3L4lIWS/35LL9910Hw+qH+WuBGVK8uCaSZjCNs36qSkyfxWtxMan2T8QvyWb/D0XG3eg/F lmsA9b1fVqa2Jzn6Nhj2LZ5giLmffd7ABWluHJEhyVJkmgafPZ+6099cTosd9eF7CaWCTaJ4/TkwQ FiOXq/2tVJE873m5qQQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1onfYw-009Asx-Kk; Wed, 26 Oct 2022 12:31:14 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1onfYs-009Art-74; Wed, 26 Oct 2022 12:31:12 +0000 Received: from [192.168.2.190] (109-252-112-196.nat.spd-mgts.ru [109.252.112.196]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dmitry.osipenko) by madras.collabora.co.uk (Postfix) with ESMTPSA id A160F660283C; Wed, 26 Oct 2022 13:31:04 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1666787465; bh=cVeQ921nr1AcNBVj1P6cg8IcXyv7Hv4rrSLvF9n0vLk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=SJWsV0ogx4gukVqrHHNKVgKYZ0kQz8qF4ZbwVQbXmfCAcWW4X8jM2jbdSIC6O+ROD mlrhJWseWDEdiODY58uwsEURti2LqQwah7CejmrvhqIDfSJt/tIR1Cnr0f3IUM+G55 QRpxyefWC1CNP6ov7hkqLEMDJXITcPtUtJIoJ0DWwY/Kn9O2PqLXOft56F+tpwa5Fj i1TExjR1seBKD05WzlfypAdVrIKgqz9+cbe8v5VNIG6T/ulg8qYxU5a/nLOYhlY4ey HRJkDF0H5nFUjK5uXNE7oWp4/VdZkAGoPWtxCR8LVla4tW9PUTM7jdP4pf0IMwFpss XHXynQR2p0ORA== Message-ID: Date: Wed, 26 Oct 2022 15:31:01 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] drm/rockchip: dw_hdmi: filter regulator -EPROBE_DEFER error messages Content-Language: en-US To: Aurelien Jarno , linux-kernel@vger.kernel.org Cc: Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , David Airlie , Daniel Vetter , Sascha Hauer , "open list:DRM DRIVERS FOR ROCKCHIP" , "moderated list:ARM/Rockchip SoC support" , "open list:ARM/Rockchip SoC support" References: <20220926203752.5430-1-aurelien@aurel32.net> From: Dmitry Osipenko In-Reply-To: <20220926203752.5430-1-aurelien@aurel32.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221026_053110_578046_7F95DEED X-CRM114-Status: GOOD ( 18.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/26/22 23:37, Aurelien Jarno wrote: > When the avdd-0v9 or avdd-1v8 supply are not yet available, EPROBE_DEFER > is returned by rockchip_hdmi_parse_dt(). This causes the following error > message to be printed multiple times: > > dwhdmi-rockchip fe0a0000.hdmi: [drm:dw_hdmi_rockchip_bind [rockchipdrm]] *ERROR* Unable to parse OF data > > Fix that by not printing the message when rockchip_hdmi_parse_dt() > returns -EPROBE_DEFER. > > Fixes: ca80c4eb4b01 ("drm/rockchip: dw_hdmi: add regulator support") > Signed-off-by: Aurelien Jarno > --- > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c > index c14f88893868..2f4b8f64cbad 100644 > --- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c > +++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c > @@ -565,7 +565,8 @@ static int dw_hdmi_rockchip_bind(struct device *dev, struct device *master, > > ret = rockchip_hdmi_parse_dt(hdmi); > if (ret) { > - DRM_DEV_ERROR(hdmi->dev, "Unable to parse OF data\n"); > + if (ret != -EPROBE_DEFER) > + DRM_DEV_ERROR(hdmi->dev, "Unable to parse OF data\n"); > return ret; > } > Reviewed-by: Dmitry Osipenko Nit: all the DRM_DEV_ERROR() usage in this function is inappropriate to me. These errors should be converted to dev_err_probe(), IMO. -- Best regards, Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel