From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E49F2C433F5 for ; Mon, 20 Sep 2021 16:44:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6A9860F38 for ; Mon, 20 Sep 2021 16:44:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A6A9860F38 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=1cqPg7G8QSLk50l5o+BbCpwMfRevh6jLkQszM7jEBF4=; b=dhAt9Md26h49GCA4nGkEOt3oeC 9PFXoO8QmU+gf5Ok87BZb3qTmOvYUtV7ddycsBhbEbP4IINlhiObhK1bYfPPYpVccssyFwsajMocI W8FmgQuWrwo4x0prSvgp+8bQ4XQEf0aR/ChS13C94c2ynBWNSYhf7TsPVprzuyj7InHDigT89SVnJ kXy9xwdyX0ZwMJUTxR/0WquqNekPsRxzD8p47twmMOnnNrKPutoKbMW+jOZnfr4eHIL68egSEV3eR LYolnb4bWEzdZuxYM5rbzymcA+teGv2zFU/35dyqb+Lff9lY3g0QrcTXqFyYWT8Xtt0zoCXOlXzov x9NH8FsQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSMNm-002SNk-8g; Mon, 20 Sep 2021 16:43:06 +0000 Received: from mxout02.lancloud.ru ([45.84.86.82]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSMNi-002SMk-T0 for linux-arm-kernel@lists.infradead.org; Mon, 20 Sep 2021 16:43:04 +0000 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout02.lancloud.ru 52B8A222A946 Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH 4/4] pata_imx: deny IRQ0 To: Fabio Estevam CC: Sergey Shtylyov , Jens Axboe , , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" References: <2e552c36-84a5-a642-a8f0-1395f77a1a6a@omprussia.ru> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Mon, 20 Sep 2021 19:42:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT01.lancloud.ru (fd00:f066::141) To LFEX1907.lancloud.ru (fd00:f066::207) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210920_094303_166273_39EB3D00 X-CRM114-Status: GOOD ( 13.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/20/21 3:52 PM, Fabio Estevam wrote: [...] >>>> IMHO the current code is correct as-is. >>> >>> Not quite... I don't want to leave a bad example for the future driver authors. What should >>> I change in the patch description for the patch to become acceptable for you? >> >> Please see how the PCI subsystem has converted the handling of >> platform_get_irq(): >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.15-rc2&id=0584bff09629666eea97c7ac428e55b00df211f5 >> >> Why does drivers/ata/ need to handle platform_get_irq() differently? >> >> I still don't see the need for changing drivers/ata/pata_imx.c in this aspect. > > Also, please check this commit too: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.15-rc2&id=a85a6c86c25be2d2a5f9c31491f612ce0edc7869 You think I haven't seen this? :-) WARN() is not enough to make IRQ invalid, isn't it? MBR, Sergey _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel