From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3CFAC7EE24 for ; Mon, 5 Jun 2023 13:05:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cs3rRj0EM4kCyBqJtFsnT1PHiupWR5pW6ZGuFY6WX5U=; b=jsXizCCaM0EWga oFhNUnNPMtETtLIFAUPGNhg0dYa1bvBigUpUcQcHEYXiAJZeCKJLlNM3Dbn1yUJKA/5odUg9QmgwP PzuDQS73yfIK/uS88IjLOlJqWBLZTrxAoigJYVeMRUH5IK8p0M6A4IiX5PiszgQgGLqSGI6fDxk0Y XiVnhRWMfMiATXAVx89mup2pi5aDxE0spiMKECpmp3GWfVmV9IlSHV4eRI72LeVIB5xLUZMYVZyDI 6WBgCCUPk0aNBeRmMVlqHb41njaGzbJKS/NZCkXGXE+O6uWE71BieBAK0pFpuLELSBL3P3+FS4+KY qdXIck6rGkmvWPkoV2YA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q69tJ-00FYBC-0c; Mon, 05 Jun 2023 13:04:57 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q69tG-00FYAH-2u for linux-arm-kernel@lists.infradead.org; Mon, 05 Jun 2023 13:04:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1685970295; x=1717506295; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=nROIitPltbPWMd0kgRZLjZjy+4djGlBLlehlPkk3LwQ=; b=M6V5kC0EAdMmuOwRtkC3aWUTefE5saKA1Y9V5336M3hfp+aQk0pRW2L1 rztwyx9Gr1znFJFDao0ROUmlSFXD3kiDogRbR6J2B3dmZSNro4AZ3vjR3 h+axZIdX0vB0k6SYQo9PG/SRM994HRXHLcZH1pW8qRY+gH2rX5lwxAgQi GBHGOgcViXQ/o0RsAiqTuPTzRdBUuaQ99T0FTrsVs2luuTCBeGMe1l9G6 0OggVHFASgSZxd/W420Bsw/SvimIYOwZLLMNGtDDFWnpVcy4aQOH0avvs LnaIprQxoCMVLOo0k1ouy4i0cKuMXQ6Aip1sUQvybVrdcSbvlPrzasIw9 w==; X-IronPort-AV: E=Sophos;i="6.00,217,1681196400"; d="scan'208";a="214657607" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 05 Jun 2023 06:04:52 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 5 Jun 2023 06:04:47 -0700 Received: from [10.159.245.112] (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2507.21 via Frontend Transport; Mon, 5 Jun 2023 06:04:41 -0700 Message-ID: Date: Mon, 5 Jun 2023 15:04:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 17/21] power: reset: at91-poweroff: lookup for proper pmc dt node for sam9x7 Content-Language: en-US To: Krzysztof Kozlowski , Varshini Rajendran , , , , , , , , , , , , , , , , , , , , , , , , , , , , , CC: , , , , , , References: <20230603200243.243878-1-varshini.rajendran@microchip.com> <20230603200243.243878-18-varshini.rajendran@microchip.com> <2a538004-351f-487a-361c-df723d186c27@linaro.org> From: Nicolas Ferre Organization: microchip In-Reply-To: <2a538004-351f-487a-361c-df723d186c27@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230605_060455_013209_AB52D455 X-CRM114-Status: GOOD ( 13.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/06/2023 at 08:43, Krzysztof Kozlowski wrote: > On 03/06/2023 22:02, Varshini Rajendran wrote: >> Use sam9x7 pmc's compatible to lookup for in the SHDWC driver >> >> Signed-off-by: Varshini Rajendran >> --- >> drivers/power/reset/at91-sama5d2_shdwc.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/power/reset/at91-sama5d2_shdwc.c b/drivers/power/reset/at91-sama5d2_shdwc.c >> index d8ecffe72f16..d0f29b99f25e 100644 >> --- a/drivers/power/reset/at91-sama5d2_shdwc.c >> +++ b/drivers/power/reset/at91-sama5d2_shdwc.c >> @@ -326,6 +326,7 @@ static const struct of_device_id at91_pmc_ids[] = { >> { .compatible = "atmel,sama5d2-pmc" }, >> { .compatible = "microchip,sam9x60-pmc" }, >> { .compatible = "microchip,sama7g5-pmc" }, >> + { .compatible = "microchip,sam9x7-pmc" }, > > Why do you need new entry if these are compatible? Yes, PMC is very specific to a SoC silicon. As we must look for it in the shutdown controller, I think we need a new entry here. Best regards, Nicolas -- Nicolas Ferre _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel