From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1DD6C27C4F for ; Fri, 21 Jun 2024 11:27:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+AbWTm7QYhVs521X2AgBsRmkjpYYxf77pV7a0Yxd2xk=; b=g8k4Zm0BUtr7xzfJh7ugE7ikny cf0Mdi+wiNudP5Y7UBJ1tZEFwFhKHaR/5qUyQtRjTKP1a/xAIwoOWdXCKAMwS1qo6GxXZqQHEVbc2 NG6VX5gxZgx4mt+o+4cNBcPBG3ZIk9YKGGrfJzIfMoIjz4eUwmKepYtgLcGcro+sx1n34v0UwWY2P DKxdby1ykBxcjQl3Umdp5rWBzUGAIh0GquvU2akzLv7tv8AuZS0DBzyu/KAik3T1rgMtVrTQS2GFD kuUSBZCqc7TrVhCovp+u6SFabjNybaNmtdVGQHrAwWyKHc7M9Sk7rgzttAtfMNrNgkokbug7EtzmU AAYBa6fQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKcPz-00000008viA-2NEz; Fri, 21 Jun 2024 11:26:59 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKcPw-00000008vgq-16I6 for linux-arm-kernel@lists.infradead.org; Fri, 21 Jun 2024 11:26:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718969215; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+AbWTm7QYhVs521X2AgBsRmkjpYYxf77pV7a0Yxd2xk=; b=bt7lgX+ztaDhIptU79T3Akb7fmNLO+fxJBKYodFxVIObhspPeDmpbGtneiWbsVTY5dwebR Ty2HTGcIkvkG6M7FGlEADTfrf9cHqI9/EXvIJnDndRjkR6DRye6XckC3Rrqh+NoaIcpmYK ne9fsRslQE+FdDh9GRnI2FCXtpm1pgw= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-610-2kTesjeWPMa9QjJiJiwKMQ-1; Fri, 21 Jun 2024 07:26:54 -0400 X-MC-Unique: 2kTesjeWPMa9QjJiJiwKMQ-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6b505b56840so19336096d6.3 for ; Fri, 21 Jun 2024 04:26:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718969213; x=1719574013; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+AbWTm7QYhVs521X2AgBsRmkjpYYxf77pV7a0Yxd2xk=; b=wFRfJjk+K05QygXENGJMrGCbNMcIW4dfLif9Kh2DfCkOH24ePLNNuUjSdQhpxOJA3V lL+n4/BycJeQjz5qjQxnvRocqX0A/YQmxG8bqkZz4bHfUsOoCb2DKXitJ2iG8whU4nPS qp8Zd15D3kKrBpEyGuDu2Y3wqBQawj3cxwAoTxv/Aau52qoxOK+hUu8ZewZHhTLh/XqY juEIUQZZrw5An/L+RoRCBUb3qauzFTGW/egokiiWJeVLgI+/IXtRcvR4MdWTX624nqj7 4FJbqvxKhyuOfjRi74ypUb9pj0aMZkAJeON8bVWBh8JG/uQavG52C+pLU0iImBI2SWjy GCuw== X-Forwarded-Encrypted: i=1; AJvYcCVo9uZKX2htyJ5iqKOu1JCZwbW4B5yHOuYgn338mrpaYDv+kDRiSl4bp4ABvvb1wYuS7G7uuzx6QJVtJg2NICwcl4i6wRQAGje5iKVeqED2wNvIxZE= X-Gm-Message-State: AOJu0YzyyU3xx52fk3R6fjPB0jrt3yjCV76dj+UcEai3ux6yjkDS/8c8 r+lIn41OaSDbvUKYqT7GV7z/MIubdnvR45vAVDb/scypZnAle6xD6m+BVVbZWyktlun+6HxRPnj +hkJesVscUECIzHW+RRrk2Rkvv8XyuK+X8A35PqT066h1Fdr8kot0xE8FvR5fAUzOPVODWKPF X-Received: by 2002:a0c:df93:0:b0:6b4:fece:1322 with SMTP id 6a1803df08f44-6b501ebbe51mr94781206d6.55.1718969213637; Fri, 21 Jun 2024 04:26:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHtpc/94A17BbeMJBFiG1uB3pSn3hfOV4uhOgztsnw0fPNyMBVvu8SC58FfeqcgOO6s7gUeSg== X-Received: by 2002:a0c:df93:0:b0:6b4:fece:1322 with SMTP id 6a1803df08f44-6b501ebbe51mr94780956d6.55.1718969213179; Fri, 21 Jun 2024 04:26:53 -0700 (PDT) Received: from [10.26.1.93] ([66.187.232.136]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b51ecfe878sm7912306d6.14.2024.06.21.04.26.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Jun 2024 04:26:52 -0700 (PDT) Message-ID: Date: Fri, 21 Jun 2024 07:26:51 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] ACPI: Add config to disable ACPI SPCR console by default on arm64 To: Liu Wei Cc: catalin.marinas@arm.com, guohanjun@huawei.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, lpieralisi@kernel.org, rafael@kernel.org, sudeep.holla@arm.com, will@kernel.org References: <20240530015332.7305-1-liuwei09@cestc.cn> <20240621044706.87181-1-liuwei09@cestc.cn> From: Prarit Bhargava In-Reply-To: <20240621044706.87181-1-liuwei09@cestc.cn> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240621_042656_481990_C652E5F0 X-CRM114-Status: GOOD ( 23.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/21/24 00:47, Liu Wei wrote: > For varying privacy and security reasons, sometimes we would like to > completely silence the serial console output, and only enable it through > cmdline when needed. > > But there are many existing systems that depend on this console, > so add CONFIG_ARM_DISABLE_ACPI_SPCR_CONSOLE for this situation. > > Signed-off-by: Liu Wei > Suggested-by: Prarit Bhargava > --- > > v2: Add a config option suggested by Prarit > --- > arch/arm64/kernel/acpi.c | 12 ++++++++++++ > drivers/acpi/arm64/Kconfig | 11 +++++++++++ > 2 files changed, 23 insertions(+) > > diff --git a/arch/arm64/kernel/acpi.c b/arch/arm64/kernel/acpi.c > index dba8fcec7f33..3365fabb5cf8 100644 > --- a/arch/arm64/kernel/acpi.c > +++ b/arch/arm64/kernel/acpi.c > @@ -227,7 +227,19 @@ void __init acpi_boot_table_init(void) > if (earlycon_acpi_spcr_enable) > early_init_dt_scan_chosen_stdout(); > } else { > + /* > + * For varying privacy and security reasons, sometimes need > + * to completely silence the serial console output, and only > + * enable it by cmdline when needed. > + * But there are many existing systems that depend on this > + * behavior, so use CONFIG_ARM_DISABLE_ACPI_SPCR_CONSOLE. > + */ > +#ifdef CONFIG_ARM_DISABLE_ACPI_SPCR_CONSOLE > + acpi_parse_spcr(earlycon_acpi_spcr_enable, false); > +#else > acpi_parse_spcr(earlycon_acpi_spcr_enable, true); > +#endif > + I don't think you want a config option here after all. See my previous comment about "acpi=nospcr". I realized that if you do use a config then distros will not have the ability to default 'on', and advise users to disable it for their use cases. Try the 'acpi=nospcr' option. That should keep everyone happy. P. > if (IS_ENABLED(CONFIG_ACPI_BGRT)) > acpi_table_parse(ACPI_SIG_BGRT, acpi_parse_bgrt); > } > diff --git a/drivers/acpi/arm64/Kconfig b/drivers/acpi/arm64/Kconfig > index b3ed6212244c..7e4d860d7089 100644 > --- a/drivers/acpi/arm64/Kconfig > +++ b/drivers/acpi/arm64/Kconfig > @@ -21,3 +21,14 @@ config ACPI_AGDI > > config ACPI_APMT > bool > + > +config ARM_DISABLE_ACPI_SPCR_CONSOLE > + bool "Disable ACPI SPCR Console by Default on Arm64" > + depends on ARM64 && ACPI_SPCR_TABLE > + default n > + help > + For varying privacy and security reasons, sometimes need to > + completely silence the serial console output, and only enable > + it by kernel cmdline when needed. > + > + Say Y to disable ACPI SPCR console by default. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0A2FC2BB85 for ; Fri, 21 Jun 2024 16:40:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MIhStWkUsn2i74dea2Oo88tCHeQyqvVaIb6mmUdebOc=; b=s3LXIZloOsWSL7hoeQnbGBS64U yqT9/+KY6Wz+IHrU+Oo9bdZnovmwiTICfJ5smTcaArDOxOgafg4zFMUkO8XANbXY/394s/yUPXaz9 FYY9UCFGjCMK41w/DuQn9NGDdDEKmuJtBmO2TRWg5iKjSh0TjutVbfTg5G8p9oYih29mtEtH+uEEl FgAYR3W6zfIz1eQiE+55uhoacBjFaNzhXl8ql9TcOdlWzOM4C3KGzxipCCMvD8/3g/iUeWq+1HTC1 Myd28NfX6/xUtx1r1KdBKqhp9CfI2LPjHVM+0AxPXJuKWWOLx8sWJF/RC680nuWJ2Rs45FpV8Qn9B BSDXW2iQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKhJF-00000009wlM-3zih; Fri, 21 Jun 2024 16:40:21 +0000 Received: from [1.203.97.246] (helo=smtp.cecloud.com) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKhIt-00000009waT-3j2u for linux-arm-kernel@lists.infradead.org; Fri, 21 Jun 2024 16:40:03 +0000 Received: from localhost (localhost [127.0.0.1]) by smtp.cecloud.com (Postfix) with ESMTP id 11E077C0112; Sat, 22 Jun 2024 00:39:55 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-SKE-CHECKED: 1 X-ABS-CHECKED: 1 X-ANTISPAM-LEVEL: 2 Received: from localhost.localdomain (117.240.211.222.broad.my.sc.dynamic.163data.com.cn [222.211.240.117]) by smtp.cecloud.com (postfix) whith ESMTP id P2702681T281465900102000S1718987992732469_; Sat, 22 Jun 2024 00:39:53 +0800 (CST) X-RL-SENDER: liuwei09@cestc.cn X-SENDER: liuwei09@cestc.cn X-LOGIN-NAME: liuwei09@cestc.cn X-FST-TO: prarit@redhat.com X-RCPT-COUNT: 10 X-LOCAL-RCPT-COUNT: 1 X-MUTI-DOMAIN-COUNT: 0 X-SENDER-IP: 222.211.240.117 X-ATTACHMENT-NUM: 0 X-UNIQUE-TAG: <750264334267299d61681e5ae89bbad6> X-System-Flag: 0 From: Liu Wei To: prarit@redhat.com, Liu Wei Cc: catalin.marinas@arm.com, guohanjun@huawei.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, lpieralisi@kernel.org, rafael@kernel.org, sudeep.holla@arm.com, will@kernel.org Subject: Re: [PATCH v2] ACPI: Add config to disable ACPI SPCR console by default on arm64 Date: Sat, 22 Jun 2024 00:39:25 +0800 Message-ID: X-Mailer: git-send-email 2.42.1 In-Reply-To: <20240621044706.87181-1-liuwei09@cestc.cn> References: <20240530015332.7305-1-liuwei09@cestc.cn> <20240621044706.87181-1-liuwei09@cestc.cn> Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62F081741DB for ; Fri, 21 Jun 2024 11:26:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="drxdoO3Q" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718969217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+AbWTm7QYhVs521X2AgBsRmkjpYYxf77pV7a0Yxd2xk=; b=drxdoO3QXJS+cNv6gnJ4+Uk5Wbel5ipQzW9ZcmuXTjYsfXBImrusoVSidWv5qf0JWII/uf AqpVdCj2a8TnAhDDFAlhn9U2wiAGpGfQp1tRyVZ1MV6x1lbqBGp61nSj65Eut9XnDMuKbP M4EtrFw079xn080AbU1J9BZsNhqzNw0= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-664-kHLQ7AdZM0uQYmwjJ7ycYw-1; Fri, 21 Jun 2024 07:26:54 -0400 X-MC-Unique: kHLQ7AdZM0uQYmwjJ7ycYw-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6b50be910afso21500826d6.2 for ; Fri, 21 Jun 2024 04:26:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718969213; x=1719574013; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+AbWTm7QYhVs521X2AgBsRmkjpYYxf77pV7a0Yxd2xk=; b=rdrkcV+jalRcKHXdUE+jEWe33/qNgR+yTM8VCmmwLCRdJtATehgTw5dUtqYogrUH82 3e3GKCFgbH1JIy1aoy2T4EW5sj3DPjDYiSAtc6RVHPgt1Bhur0nmukH5AjsP21ysZXt4 JODPkkFBxhY4xU9D8fy+3lSbiA3pT95ZwtqQMePN7tOCJLkH29zdV/i/wvfekoMtkcmf 6ZpUlhO+X9RWDy5UWcqJ2928IeXkdIWQ4TMnTTR4JiLFZGM2OncgStajsPCSzCa84UQe Y3VlqsU5ucZAnixcrstuv/khT1KRkU591VJ8sk166oqJvcHmgn629zyAkwv4iaFWgEV6 Wxpw== X-Forwarded-Encrypted: i=1; AJvYcCX/pYxiYR8AKK6yCNk7GG9xRTiMUKEROfmvmmFLrbOuvTdTDWsNfYE4LxF1M7HQlPO9rbc2pOXMNlhrqkhpywfg7rBrz0lhJkFVh32x X-Gm-Message-State: AOJu0YzMSmvpfE8RSnU/AXz8DZVZpCszEEYM3JUq5OYGms0sTEdsZkNa Fc5yToFK46IHdfU2LxlT3ysrhiCjtIwJMuafisFakj6IqEqD9WfwVgqUiVofPsiRGZzCxcVn7kp GfUyQEBI2snlAZZR+3/KM7zQYacsBKrTdhhdx0hzeLa3zeAR6duGLaIpsCr9HJA== X-Received: by 2002:a0c:df93:0:b0:6b4:fece:1322 with SMTP id 6a1803df08f44-6b501ebbe51mr94781236d6.55.1718969213640; Fri, 21 Jun 2024 04:26:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHtpc/94A17BbeMJBFiG1uB3pSn3hfOV4uhOgztsnw0fPNyMBVvu8SC58FfeqcgOO6s7gUeSg== X-Received: by 2002:a0c:df93:0:b0:6b4:fece:1322 with SMTP id 6a1803df08f44-6b501ebbe51mr94780956d6.55.1718969213179; Fri, 21 Jun 2024 04:26:53 -0700 (PDT) Received: from [10.26.1.93] ([66.187.232.136]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b51ecfe878sm7912306d6.14.2024.06.21.04.26.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Jun 2024 04:26:52 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240621_094000_975274_2E5AA27C X-CRM114-Status: GOOD ( 26.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Message-ID: <20240621163925.oWhlLfHRd4WjIcFFSifzPYSZSnPA8tmGXIBkcZEmDr8@z> From: Prarit Bhargava On 6/21/24 00:47, Liu Wei wrote: > > For varying privacy and security reasons, sometimes we would like to > > completely silence the serial console output, and only enable it through > > cmdline when needed. > > > > But there are many existing systems that depend on this console, > > so add CONFIG_ARM_DISABLE_ACPI_SPCR_CONSOLE for this situation. > > > > Signed-off-by: Liu Wei > > Suggested-by: Prarit Bhargava > > --- > > > > v2: Add a config option suggested by Prarit > > --- > > arch/arm64/kernel/acpi.c | 12 ++++++++++++ > > drivers/acpi/arm64/Kconfig | 11 +++++++++++ > > 2 files changed, 23 insertions(+) > > > > diff --git a/arch/arm64/kernel/acpi.c b/arch/arm64/kernel/acpi.c > > index dba8fcec7f33..3365fabb5cf8 100644 > > --- a/arch/arm64/kernel/acpi.c > > +++ b/arch/arm64/kernel/acpi.c > > @@ -227,7 +227,19 @@ void __init acpi_boot_table_init(void) > > if (earlycon_acpi_spcr_enable) > > early_init_dt_scan_chosen_stdout(); > > } else { > > + /* > > + * For varying privacy and security reasons, sometimes need > > + * to completely silence the serial console output, and only > > + * enable it by cmdline when needed. > > + * But there are many existing systems that depend on this > > + * behavior, so use CONFIG_ARM_DISABLE_ACPI_SPCR_CONSOLE. > > + */ > > +#ifdef CONFIG_ARM_DISABLE_ACPI_SPCR_CONSOLE > > + acpi_parse_spcr(earlycon_acpi_spcr_enable, false); > > +#else > > acpi_parse_spcr(earlycon_acpi_spcr_enable, true); > > +#endif > > + > > I don't think you want a config option here after all. See my previous > comment about "acpi=nospcr". I realized that if you do use a config > then distros will not have the ability to default 'on', and advise users > to disable it for their use cases. > > Try the 'acpi=nospcr' option. That should keep everyone happy. > Ok, I will send new version soon. Thanks for your suggestion! Liu Wei > P. >