From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA5F5C43334 for ; Tue, 12 Jul 2022 18:20:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eP4F5gx5fHcXBzz5f9LaFdOVVr4AmJyi5tML93c+vFk=; b=VvJj1e286+eUtZ lpnTGaS0oEmACrsdChv/7KiH9X7NAoCMfbm4s9lOUYwAzSKzKD1pbx5QR/onuH9cquGpiCwaVups1 1/dPh9cGudWg1JPXk6DnXtme05iS6Yiuljms7d6/1uu3KZ8n9YRAZPWcybNAi/XOO3BIXKJF8AcoV olicYnNw3+9Ai5JQeUVo/VchFnywVIuPYbhiIz0ipxH1D8Dn4BWyR71rXDyPzWVz5gQC1KydRRZRk B5gAP25UAVNdWco30qMl7zmKVmnpbdsNLWDQotG01zyKZ+xlKxY+WZC0xLOphWOq/L8BqKeyFr7CT uJEWgEszvmaqHDyOj0lw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBKTW-00Dgn0-0H; Tue, 12 Jul 2022 18:19:10 +0000 Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBKTS-00Dgjt-Uy for linux-arm-kernel@lists.infradead.org; Tue, 12 Jul 2022 18:19:08 +0000 Received: by mail-lj1-x22c.google.com with SMTP id q7so10823458lji.12 for ; Tue, 12 Jul 2022 11:19:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=JMQ1Fi79A0irIgGyUI6PCh63flvImOH2aGttq9qDyQs=; b=y9r7FhafnYvsSz00A1RwZZhtcyDeUlxPoSJaq4eDskAgQegtb06JvvJBQmgxjTxayH G55b8QAbWHkyo/JGBUculJi2pqTIWWJ79SEadMsTIY1Di8YVIbcmHrLhdxz4G5nFHvse bc+OIH22tPsQ71EYxKdGw5IsF0JNxhBctA54rxOiuhi1+PtcrnW4xnJKkc6yy8ZrvM98 4iOoPcRztj4evF/vVZWXyaTUIaDjh5VpPgvKvgtYSThWj84LK/c6rbWMATbFPW9wycJC XRhr1NJJrDLcT6dDXAC3tb9XU373VffnpQsIfB7Zq2+hZaXeOBt4CQ+qIp2pF+F+x9qq FgDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=JMQ1Fi79A0irIgGyUI6PCh63flvImOH2aGttq9qDyQs=; b=CleGx2/jUdZWs0iuJGEO8Ied7Oj1fR0sROFFgg2IkIOU/LgzMvWOgXrzB9aqSd37ue E5+ZwHYBecTlBrskrAOE9zNI3XVmw2bRmAHag731JdtH9/7OayFyrBJA6LIEbHPC7jA9 nU9ylJh2iC9XJdrFLLu+c/5epOxVJxzzdNvleUi6kV+lU1HXNvabprE2VeltFnJQ9sty 1W7cIvb/SQHMqGMZhsiG6/jGmMeHZJBwfO5OehfZpooU7rew57GbAkcQXBt1dFQMGww0 uMg7acF719EenBL0GLs78UQyVUkSFRsasM/UXYxNpe9JRJvKzM5niHOWd1HxmuY6+w3E xTSA== X-Gm-Message-State: AJIora9uNMqePuMFQ5Pk+APjHr99KJzgvwYCLrXRR/N+ijRUV7Dpmoe3 A3uz75ESOskVMwBQnNuzbsmtL0+qjmGKYrKd X-Google-Smtp-Source: AGRyM1tC/q9gDYFNopU+9HAIbDNxNonrgeLFGrJ13IUtbK5ZlYSmdteLoZQ1OfR0Hjc5cWoZJOcL6g== X-Received: by 2002:a2e:9695:0:b0:25d:65f9:fb95 with SMTP id q21-20020a2e9695000000b0025d65f9fb95mr8153763lji.302.1657649942181; Tue, 12 Jul 2022 11:19:02 -0700 (PDT) Received: from [10.0.0.8] (fwa5da9-171.bb.online.no. [88.93.169.171]) by smtp.gmail.com with ESMTPSA id m5-20020a2ea885000000b0025a7338317esm2511199ljq.64.2022.07.12.11.19.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Jul 2022 11:19:01 -0700 (PDT) Message-ID: Date: Tue, 12 Jul 2022 20:18:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [RFC PATCH 1/3] dt-bindings: arm64: bcmbca: Merge BCM4908 into BCMBCA Content-Language: en-US To: William Zhang , Linux ARM List Cc: kursad.oney@broadcom.com, anand.gore@broadcom.com, dan.beygelman@broadcom.com, f.fainelli@gmail.com, Broadcom Kernel List , joel.peshkin@broadcom.com, Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, rafal@milecki.pl References: <20220712021144.7068-1-william.zhang@broadcom.com> <20220712021144.7068-2-william.zhang@broadcom.com> <94b0ab39-279d-d3c2-98a4-054c10ad041c@broadcom.com> From: Krzysztof Kozlowski In-Reply-To: <94b0ab39-279d-d3c2-98a4-054c10ad041c@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220712_111907_114683_B8AA6F58 X-CRM114-Status: GOOD ( 12.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/07/2022 19:37, William Zhang wrote: >>> + - description: BCM4908 Family based boards >>> + items: >>> + - enum: >>> + # BCM4908 SoC based boards >>> + - brcm,bcm94908 >>> + - asus,gt-ac5300 >>> + - netgear,raxe500 >>> + # BCM4906 SoC based boards >>> + - brcm,bcm94906 >>> + - netgear,r8000p >>> + - tplink,archer-c2300-v1 >>> + - enum: >>> + - brcm,bcm4908 >>> + - brcm,bcm4906 >>> + - brcm,bcm49408 >> >> This is wrong. brcm,bcm94908 followed by brcm,bcm4906 does not look >> like valid list of compatibles. >> > For 4908 board variant, it will need to be followed by 4908 chip. Sorry > for the basic question but is there any requirement to enforce this kind > of rule? I would assume dts writer know what he/she is doing and select > the right combination. The entire point of DT schema is to validate DTS. Combination like above prevents that goal. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel