Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/4] ARM: da850: don't add the emac clock to the clock lookup table twice
Date: Mon, 2 Jan 2017 14:56:42 +0530	[thread overview]
Message-ID: <c41cecd3-7ede-c220-d849-9df5d3e20409@ti.com> (raw)
In-Reply-To: <1481124138-27337-3-git-send-email-bgolaszewski@baylibre.com>

On Wednesday 07 December 2016 08:52 PM, Bartosz Golaszewski wrote:
> Similarly to the aemif clock - this screws up the linked list of clock
> children. Create a separate clock for mdio inheriting the rate from
> emac_clk.
> 
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

Applied with change in headline (see comment on 1/4). Also added a 
comment explaining why mdio clk is needed.

> ---
>  arch/arm/mach-davinci/da850.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-davinci/da850.c b/arch/arm/mach-davinci/da850.c
> index e9d019c..6b1fbac 100644
> --- a/arch/arm/mach-davinci/da850.c
> +++ b/arch/arm/mach-davinci/da850.c
> @@ -319,6 +319,11 @@ static struct clk emac_clk = {
>  	.gpsc		= 1,
>  };
>  

/*
 * In order to avoid adding the emac_clk to the clock lookup table twice (and
 * screwing up the linked list in the process) create a separate clock for
 * mdio inheriting the rate from emac_clk.
 */

> +static struct clk mdio_clk = {
> +	.name		= "mdio",
> +	.parent		= &emac_clk,
> +};

Thanks,
Sekhar

  reply	other threads:[~2017-01-02  9:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-07 15:22 [PATCH v4 0/4] ARM: da850: fix pll0 rate setting Bartosz Golaszewski
2016-12-07 15:22 ` [PATCH v4 1/4] ARM: da850: fix infinite loop in clk_set_rate() Bartosz Golaszewski
2017-01-02  8:52   ` Sekhar Nori
2016-12-07 15:22 ` [PATCH v4 2/4] ARM: da850: don't add the emac clock to the clock lookup table twice Bartosz Golaszewski
2017-01-02  9:26   ` Sekhar Nori [this message]
2016-12-07 15:22 ` [PATCH v4 3/4] ARM: da850: coding style fix Bartosz Golaszewski
2017-01-02  9:30   ` Sekhar Nori
2016-12-07 15:22 ` [PATCH v4 4/4] ARM: da850: fix da850_set_pll0rate() Bartosz Golaszewski
2017-01-02 10:12   ` Sekhar Nori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c41cecd3-7ede-c220-d849-9df5d3e20409@ti.com \
    --to=nsekhar@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox