From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E354C77B76 for ; Mon, 17 Apr 2023 07:36:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VZAf+sEehw+QMEPwqtOUW4ReCmbXBUf59LDuXZA3ghw=; b=uN3f2ioHjNI7qs 1/qh2JTNSz5GuTuYszvI9ImFojr8AOadW9v52C8t2iEMeomNF+u6QzObFQ32sKGVuNI6+QxOmn5qq Jwbxl9m1t0je06Ymjcd7SNsPiWM3fcp00OYwaTRY8vTlnQ3348Wpw4hAVqF801Au9nC9x8sIzRJ3x xnyCc2LioyveBPqVFD7OGpCw45cSz33tKklwOTPPxop5+OaYC8nl4FiiaIjpw+0t7QkCs6WY5+VBq VSpyW0xicc3h5omIG2lTm2IbBSwBKM4oarmhXpZ4/gGSSdapZol2T1aGaA+FrToqvwc7YdjBx1rGM TAFHKl5CAFqwbmgEuTRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1poJP9-00FC9h-1h; Mon, 17 Apr 2023 07:36:03 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1poJP6-00FC8J-1x for linux-arm-kernel@lists.infradead.org; Mon, 17 Apr 2023 07:36:02 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 33H7Zp5L051645; Mon, 17 Apr 2023 02:35:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1681716951; bh=Z4LB/IWF7ou7ipPzsHyZXXQjaY1cCvmLaOqcfk3aGqw=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=GvzRGLO8i/x9jaN2hCg9cDTkELxNrkqjj1u+E39JgPG5OUfTo5rtWSBtZeK4tmjHW 7y4j7RXToWCZOiooM9xzj46Jbz51yjhf5HQ1Hd0nQh485qq6Iavg4q/zGtkzgVweS6 J2OO2s6ymZ+PVyDYmzUE2Ny6JxYUiVfB0ApGb5sI= Received: from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 33H7ZpBs065183 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 17 Apr 2023 02:35:51 -0500 Received: from DLEE101.ent.ti.com (157.170.170.31) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Mon, 17 Apr 2023 02:35:50 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE101.ent.ti.com (157.170.170.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Mon, 17 Apr 2023 02:35:51 -0500 Received: from [172.24.145.7] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 33H7ZlA5085138; Mon, 17 Apr 2023 02:35:48 -0500 Message-ID: Date: Mon, 17 Apr 2023 13:05:47 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 1/5] arm64: dts: ti: k3-j784s4-main: Add system controller and SERDES lane mux Content-Language: en-US To: Vignesh Raghavendra , , CC: , , , , , , References: <20230414151553.339599-1-j-choudhary@ti.com> <20230414151553.339599-2-j-choudhary@ti.com> From: Jayesh Choudhary In-Reply-To: X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230417_003600_838497_39704DA5 X-CRM114-Status: GOOD ( 13.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Vignesh, On 17/04/23 10:07, Vignesh Raghavendra wrote: > Hi Jayesh > > On 14/04/23 20:45, Jayesh Choudhary wrote: >> From: Siddharth Vadapalli >> >> The system controller node manages the CTRL_MMR0 region. >> Add serdes_ln_ctrl node which is used for controlling the SERDES lane mux. >> >> Signed-off-by: Siddharth Vadapalli >> Signed-off-by: Jayesh Choudhary >> --- >> arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 22 ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi >> index e9169eb358c1..344f4ffa0b82 100644 >> --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi >> @@ -5,6 +5,9 @@ >> * Copyright (C) 2022 Texas Instruments Incorporated - https://www.ti.com/ >> */ >> >> +#include >> +#include >> + >> &cbass_main { >> msmc_ram: sram@70000000 { >> compatible = "mmio-sram"; >> @@ -26,6 +29,25 @@ l3cache-sram@200000 { >> }; >> }; >> >> + scm_conf: scm-conf@100000 { > > generic node name please: "syscon@" Okay. > >> + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd"; >> + reg = <0x00 0x00100000 0x00 0x1c000>; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges = <0x00 0x00 0x00100000 0x1c000>; >> + >> + serdes_ln_ctrl: mux-controller@4080 { > > Either add reg property or replace @ with - Will use '-'. > > Run make with W=12 to catch such errors. Okay. Will do. Thanks. [...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel