From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B672DC4360C for ; Sat, 28 Sep 2019 23:09:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 791B3208E4 for ; Sat, 28 Sep 2019 23:09:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="clXo0fZK"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=gmx.net header.i=@gmx.net header.b="IeB9AbiT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 791B3208E4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gmx.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YQQLQrOkvUbV7eLWYcO+KwTrY4RdjvShKs0jCMhZ8MI=; b=clXo0fZKMCbCbD hcSYh6CLvLQ4tkDNfSXB+YTQ2blEFOzERhxxVvOjrlB/NZAIWLrTDHC21JraG03G6itvwGtcIwKYb DWYf6nqrwe9Cekbo2D2/fLQc0/CI+St5e5TtDfPuvLjmmFIuNa9jRMp1TY9vwWvZwS7gLWZmv8n5m 8AVPXiN0cDbpRcmYz++lhFnsJSIEdrX3pWr2ug0ogPe/iN/HgtwDXA+kPdl7ukNCh9swUjoS8AaZO 5UkaCuQqiiYpuIP9rLEkpLT+2uc805FYd8BL6B+vLrXjixufcKdYAkNKyk5yy18ZsX+jPEvhqN0c2 Q+zV1wetSdsHOxxY0MFQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iELqQ-0000ki-4a; Sat, 28 Sep 2019 23:09:42 +0000 Received: from mout.gmx.net ([212.227.15.18]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iELqM-0000kM-Dd for linux-arm-kernel@lists.infradead.org; Sat, 28 Sep 2019 23:09:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1569712161; bh=8771iJl1nf1lZSh/T9aeSbD8M6At8DM9TBzdCPUEo9g=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=IeB9AbiTjwkjXzQttZZ3hYgZnT4N/g8kbWl/Wagvf/opDT8qbZUCqEYsPFVTIArhr sJq9GoRkVOWe5NLbG1Dlpcw8vkY5dMQGsmeIG76xzgd06t+N8tGZN+C1qyo25NYrYr PMTPW3v5XfyaZwun2dqh1bux9wBpRCLdRCrZsyFw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.162] ([37.4.249.130]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MD9T1-1iMqHY1Oqn-009B3O; Sun, 29 Sep 2019 01:09:21 +0200 Subject: Re: [PATCH V3 6/8] ARM: bcm: Add support for BCM2711 SoC To: Florian Fainelli , Rob Herring , Mark Rutland , Eric Anholt , Ray Jui , Scott Branden References: <1569672435-19823-1-git-send-email-wahrenst@gmx.net> <1569672435-19823-7-git-send-email-wahrenst@gmx.net> <6b251871-59ae-6040-cbbc-74207b2169f3@gmail.com> From: Stefan Wahren Message-ID: Date: Sun, 29 Sep 2019 01:09:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <6b251871-59ae-6040-cbbc-74207b2169f3@gmail.com> Content-Language: en-US X-Provags-ID: V03:K1:eBZgWx7jKID8fzMfH4zW8mxLbUkYw+z83ZZwIhkN+LUm0xDNk9z 4BzSk5Ra6J9H2DnlvJkSlDAugpcVL7euD2bL+wZAokQvXUgJyZDvu7Wtto7kvlpYvoe/UuZ oDSvZ0s+JXugn3h4Ijnm0qYl8DUuYuIEenLJJyC5+Gb1MIcQAmyGvFcgQVLyGkvUx8cZxzW fWrRoGVkLC9mFCCSdCytA== X-UI-Out-Filterresults: notjunk:1;V03:K0:9Q6v5PlVBLw=:lxiRvwQmOYAyjPxjjKfc8O ZWMjUMZls6HYdv5HpjPhHK6uchS4d29qcUqwGmqXMK92XwFiRt5lJ2vvWX2iCwdTfwp1r49Vg kUXwM2I4TxF/vHbk3QtVeJ2weON8E1R2/mhGDr2qd7VPJkAHzTalK1iYW4VxK3dxUV/ZXxgtI LfwbB8PKVHUHXEPjE+fB98sM/4uZIOJIkRLTIme7+V6E366rJvderMqxCa2hz8u3SH5GBTB9u 25ajmZpCmGPzFqF63smlRbruKBMhwx/bsUESbmtv/X6OExxHcf5sdcmMU9mi+1LUZANzYTb94 RQMPMmGlk7wcDTLsrbU8VAij4zYbUETY3S4LmnH9p0Cf7C0NqH+HcxURm/aoKoPGA28DRAIZG i70Rve8+eS7ccglThn3oPD88HR+QYHhlUHeYeG4z8V/seWSIP3vqLWoIpEToE+NJcxtWo1ljO NjTmyEyTsVXyN8xEO5AC+LD/OnFtZ9InAVQQb6zJXhfWtCyNzcwHx4wDXkRmso3SuM/kDJY2Y M4ONKrTdrMo/89vzJBtMfjcROCFBF6yQgsxDYBs7dSwk8g4a3hRXNJLEPqsVN6+xxTS0fNMqQ FRsQ+deGuC7f9jxgkUE0CRhtrQ2gpNESqlNZUn5drm7j6G72DL2mRhP9inEnCeUX8hegaPMTB CIfWeTadOyhCdKGHMt8y35eiBhrd0+GshRQT4s5yQ183gBo5nOoOM5XgS1XG3BbFw7SYmmj1k 5vjVqFoiC0VFsFbruHG1FXnmqjFRxNjuCpwB4rIQzZtyb//UpjjZLvDjKkk1HM+Y0YT8eRNxF iL6F3r+5IKU1yA2dsvimRGkg15sefeOhDEgRag/ewkd8o9VhQVx/XHMBqerxBOF1zqPP9PphX NpvObsKzo1TGDmwRgUfIVyvbi8HEVQDhuJe2EIv0/YlFCTcWXyPu7vTlmrhJVs0H+q+K/bD0w OD0kxWeQz2k/PdMCNti60Gg2Hxne/2KP3/hPwz6wO2Km/f6YckYIFIiqPRSY6lS+w/1lC0RoM pNoLvl3k/4u/+oPGSOZ4FUTSLUpdWDc5HwmT4mvRtZbloo2U/09BkUCNNPJlXRg22a6syhLnG jYGxtLxPCifQbpW025hfiCIlq8nq/83lQqXMpt9gP9Hv20zgKJNV/nnnuTzmetTsJgoXoL6uT In1vB8jIyymrRhDv0F2kRZlLfs9eVXmGgPhlY5eM+to/IytkdHLTxPp849EubfMABwHaydYYy aNe7IUkmzAFMZRVQMYi6uplVPthrxrCycklYy3TFK+ZPcX1WMryvyumbJBr0= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190928_160938_793010_DAFD56EF X-CRM114-Status: GOOD ( 19.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Catalin Marinas , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, Will Deacon , Nicolas Saenz Julienne Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am 28.09.19 um 21:16 schrieb Florian Fainelli: > > On 9/28/2019 5:07 AM, Stefan Wahren wrote: >> Add the BCM2711 to ARCH_BCM2835, but use new machine board code >> because of the differences. >> >> Signed-off-by: Stefan Wahren >> Reviewed-by: Eric Anholt >> --- >> arch/arm/mach-bcm/Kconfig | 3 ++- >> arch/arm/mach-bcm/Makefile | 3 ++- >> arch/arm/mach-bcm/bcm2711.c | 24 ++++++++++++++++++++++++ >> arch/arm64/Kconfig.platforms | 5 +++-- >> 4 files changed, 31 insertions(+), 4 deletions(-) >> create mode 100644 arch/arm/mach-bcm/bcm2711.c >> >> diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig >> index 5e5f1fa..39bcbea 100644 >> --- a/arch/arm/mach-bcm/Kconfig >> +++ b/arch/arm/mach-bcm/Kconfig >> @@ -161,6 +161,7 @@ config ARCH_BCM2835 >> select GPIOLIB >> select ARM_AMBA >> select ARM_ERRATA_411920 if ARCH_MULTI_V6 >> + select ARM_GIC if ARCH_MULTI_V7 >> select ARM_TIMER_SP804 >> select HAVE_ARM_ARCH_TIMER if ARCH_MULTI_V7 >> select TIMER_OF > Are not we missing a select ZONE_DMA here? Yes. I think for arm and arm64. > >> @@ -169,7 +170,7 @@ config ARCH_BCM2835 >> select PINCTRL_BCM2835 >> select MFD_CORE >> help >> - This enables support for the Broadcom BCM2835 and BCM2836 SoCs. >> + This enables support for the Broadcom BCM2711 and BCM283x SoCs. >> This SoC is used in the Raspberry Pi and Roku 2 devices. >> >> config ARCH_BCM_53573 >> diff --git a/arch/arm/mach-bcm/Makefile b/arch/arm/mach-bcm/Makefile >> index b59c813..7baa8c9 100644 >> --- a/arch/arm/mach-bcm/Makefile >> +++ b/arch/arm/mach-bcm/Makefile >> @@ -42,8 +42,9 @@ obj-$(CONFIG_ARCH_BCM_MOBILE_L2_CACHE) += kona_l2_cache.o >> obj-$(CONFIG_ARCH_BCM_MOBILE_SMC) += bcm_kona_smc.o >> >> # BCM2835 >> -obj-$(CONFIG_ARCH_BCM2835) += board_bcm2835.o >> ifeq ($(CONFIG_ARCH_BCM2835),y) >> +obj-y += board_bcm2835.o >> +obj-y += bcm2711.o >> ifeq ($(CONFIG_ARM),y) >> obj-$(CONFIG_SMP) += platsmp.o >> endif >> diff --git a/arch/arm/mach-bcm/bcm2711.c b/arch/arm/mach-bcm/bcm2711.c >> new file mode 100644 >> index 0000000..dbe2967 >> --- /dev/null >> +++ b/arch/arm/mach-bcm/bcm2711.c >> @@ -0,0 +1,24 @@ >> +// SPDX-License-Identifier: GPL-2.0+ >> +/* >> + * Copyright (C) 2019 Stefan Wahren >> + */ >> + >> +#include >> + >> +#include >> + >> +#include "platsmp.h" >> + >> +static const char * const bcm2711_compat[] = { >> +#ifdef CONFIG_ARCH_MULTI_V7 >> + "brcm,bcm2711", >> +#endif >> +}; >> + >> +DT_MACHINE_START(BCM2711, "BCM2711") >> +#ifdef CONFIG_ZONE_DMA >> + .dma_zone_size = SZ_1G, >> +#endif >> + .dt_compat = bcm2711_compat, >> + .smp = smp_ops(bcm2836_smp_ops), >> +MACHINE_END >> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms >> index 16d7614..b5d31dc 100644 >> --- a/arch/arm64/Kconfig.platforms >> +++ b/arch/arm64/Kconfig.platforms >> @@ -37,11 +37,12 @@ config ARCH_BCM2835 >> select PINCTRL >> select PINCTRL_BCM2835 >> select ARM_AMBA >> + select ARM_GIC >> select ARM_TIMER_SP804 >> select HAVE_ARM_ARCH_TIMER >> help >> - This enables support for the Broadcom BCM2837 SoC. >> - This SoC is used in the Raspberry Pi 3 device. >> + This enables support for the Broadcom BCM2837 and BCM2711 SoC. >> + This SoC is used in the Raspberry Pi 3 and 4 device. > Nit: > > These SoCs are used in the Raspberry Pi 3 and 4 devices. > > With that: > > Acked-by: Florian Fainelli _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel