From: Marc Zyngier <maz@kernel.org>
To: "Raghavendra, Vignesh" <vigneshr@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC v2 2/2] irqchip: irq-ti-sci-inta: Add direct mapped interrupts
Date: Sat, 08 Apr 2023 12:36:38 +0100 [thread overview]
Message-ID: <c42185ee1b224fd7814b6e336a3fc3f5@kernel.org> (raw)
In-Reply-To: <d9d6dc1b-cc1d-d823-8777-3a8d6d2328f7@ti.com>
On 2023-04-08 12:27, Raghavendra, Vignesh wrote:
> Hi,
>
> On 4/8/2023 4:10 PM, Marc Zyngier wrote:
>>> +static unsigned int ti_sci_inta_direct_events_am62x[] = {
>>> + /* CPSW etherenti DMA events */
>>> + TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4627),
>>> + TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4635),
>>> + TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4643),
>>> + TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4651),
>>> + TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4659),
>>> + TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4667),
>>> + TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4675),
>>> + TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4683),
>>> + TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 5651),
>>> +};
>>> +
>>> +static struct ti_sci_inta_soc_data soc_data_am62x = {
>>> + .events_list = ti_sci_inta_direct_events_am62x,
>>> + .events_list_size = ARRAY_SIZE(ti_sci_inta_direct_events_am62x),
>>> +};
>> I don't think these tables belong in a driver, and they are bound to
>> grow without any obvious limits.
>
> Fair point.
>
>> You have firmware tables that can express these things. Surely they
>> can be put to a good use.
>
> By firmware tables you mean device tree?
That, or any other machine-specific mean. From what I get of these
systems, they already make heavy use of some runtime firmware to get
things configured. That side could also provide setup information.
I don't mind either way, as long as we don't end-up with forever
growing in-kernel tables that are just board files in disguise.
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-04-08 11:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 15:04 [PATCH RFC v2 0/2] irqchip: irq-ti-sci-inta: Add initial IRQ affinity support Vignesh Raghavendra
2023-03-27 15:04 ` [PATCH RFC v2 1/2] irqchip: irq-ti-sci-inta: Allocates VINTs at probe Vignesh Raghavendra
2023-04-08 10:39 ` Marc Zyngier
2023-04-08 11:34 ` Raghavendra, Vignesh
2023-03-27 15:04 ` [PATCH RFC v2 2/2] irqchip: irq-ti-sci-inta: Add direct mapped interrupts Vignesh Raghavendra
2023-04-08 10:40 ` Marc Zyngier
2023-04-08 11:27 ` Raghavendra, Vignesh
2023-04-08 11:36 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c42185ee1b224fd7814b6e336a3fc3f5@kernel.org \
--to=maz@kernel.org \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=ssantosh@kernel.org \
--cc=tglx@linutronix.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).