From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BECF5C3DA79 for ; Mon, 15 Jan 2024 09:27:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HMd06RS5KpJrHJhnLT+kWIr354relB0msLhp7tP69e4=; b=K8DmQs1yve7VvU +IIC4weurKFRQyXE7cm4fZBDSXdT1fuYEljhD8WXEGMYi+5PBa+7JKVooOncfdP3+YxC0NDz3eNlm yqvc0Ksw+ZkSxaSrmtCfYzG4wvYHKsiVw3InxUzAmhkxfisO6dSZv+TUVrCW5cMFk9onchRb3QJFz 3TJ9xo3LnaW20PujyiZ5dZSbgFilxqNIaRbmQpuImHN8DSCmQzbLdzEWZ8QA/nXe29uAPocKGlBig PtevUvQHiwt6gV6aZ6heHyNpxl9qhWlaU99dw993h45Eb7U4Oosan0sCXz0sSbyf+U8nsfvnoYcxn nNPsdPbOcxWZmkPdIKMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rPJF3-008Pr4-0Y; Mon, 15 Jan 2024 09:26:49 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rPJF0-008PqQ-38 for linux-arm-kernel@lists.infradead.org; Mon, 15 Jan 2024 09:26:48 +0000 Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-a2d348d213dso168414566b.0 for ; Mon, 15 Jan 2024 01:26:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705310804; x=1705915604; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YHhsOVyVdum5BvTOU6puggsd8m+EmQHCPAae0qxBHok=; b=lHz+YJt9sM9h7UegyqC+/EB4t9dH8hX4amMStj3HIDyK02HFRjjqPxSpKKhRXTbM9z nA/GQRVhAOrXc4DFQKQYda/eypiXPQeYU17rdr8Pka21FbcR4ceCmI0Zx2z+uOJhQrT9 CJ/VeMV36cwRe+izSsTFRTO7SEjmi4sTh3K9Bb1vKhO6H5asEmVZuQnSGfXRdXn4jc1q SjKbKjyNIkwz4YfqhViWgdsUUTfUtiW2Db1wKmS06JbvX45umzb4L480XC/uR/Q/SAYq Yv/Yx2t31YvRFEEXZtQYuLZn8IckuadXdw+NpCVH+lKJP+wktyxA65pL8WS/+DoIoqV6 OkXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705310804; x=1705915604; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YHhsOVyVdum5BvTOU6puggsd8m+EmQHCPAae0qxBHok=; b=Sc/jDYW74cMHbzxNmSWhq6wYcnMixf4c8fnCbM9//GKG9tJY7R5lp8N6YoOUR2lJ2d T1ts6EvVYj1uooSHe2H+z4kLjRRY6/Vf3PxK5gbxlRhFSK52qnM2QXXUv/3kW4RDkVoj vvoU9hNns/GVKnjeMDqWkQVCTdWe9nheV+6rb85Q5Sud3NEU0p9C8Kl7BIidEsB5CuPf VugXvINOnKCNEL6Bi7iyDLN2DL1FmGwzYyFWugf78cPbIqcDaWNSKiPcupooRD8GuqXh PsI4jfFg28wZLojB5Fyy9ZtdLT/FGlkr3J+qQnenJq9UwscXz3fYRexYq+a6x2jY2ki8 /rzg== X-Gm-Message-State: AOJu0Yz+DsFpnvYBvTnq5YMwGjYPiwR1GR8McUU9yS+bU+GRk+gaSyVS mX8AQuncMIkE+OzjHslGy9uA5IW8UDoLGg== X-Google-Smtp-Source: AGHT+IH7cZL8diFYSaoGSTkZ0mpTzMbH5ut90Gi/coaMPo1tndTeyRADHfIre2mkNCxz1dCGRtEkYQ== X-Received: by 2002:a17:906:360a:b0:a2c:55f1:ca14 with SMTP id q10-20020a170906360a00b00a2c55f1ca14mr2020858ejb.119.1705310804110; Mon, 15 Jan 2024 01:26:44 -0800 (PST) Received: from [192.168.1.20] ([178.197.215.66]) by smtp.gmail.com with ESMTPSA id ks19-20020a170906f85300b00a2b086c29e1sm5049162ejb.127.2024.01.15.01.26.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jan 2024 01:26:43 -0800 (PST) Message-ID: Date: Mon, 15 Jan 2024 10:26:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 2/3] dt-bindings: hwmon: Support Aspeed g6 PWM TACH Control Content-Language: en-US To: Billy Tsai , Rob Herring Cc: "jdelvare@suse.com" , "linux@roeck-us.net" , "krzysztof.kozlowski+dt@linaro.org" , "joel@jms.id.au" , "andrew@aj.id.au" , "corbet@lwn.net" , "thierry.reding@gmail.com" , "u.kleine-koenig@pengutronix.de" , "p.zabel@pengutronix.de" , "naresh.solanki@9elements.com" , "linux-hwmon@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-pwm@vger.kernel.org" , BMC-SW , "patrick@stwcx.xyz" References: <20240108074348.735014-1-billy_tsai@aspeedtech.com> <20240108074348.735014-3-billy_tsai@aspeedtech.com> <20240113015556.GA3829553-robh@kernel.org> <40210196-3852-4c8b-94e6-e744890f003f@linaro.org> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240115_012647_010736_9771EC1D X-CRM114-Status: GOOD ( 15.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15/01/2024 09:43, Billy Tsai wrote: >>>>> +examples: >>>>> + - | >>>>> + #include >>>>> + pwm_tach: pwm-tach-controller@1e610000 { >>>>> + compatible = "aspeed,ast2600-pwm-tach"; >>>>> + reg = <0x1e610000 0x100>; >>>>> + clocks = <&syscon ASPEED_CLK_AHB>; >>>>> + resets = <&syscon ASPEED_RESET_PWM>; >>>>> + #pwm-cells = <3>; >>>>> + >>>>> + fan-0 { >>>>> + tach-ch = /bits/ 8 <0x0>; >>>>> + }; >>>>> + >>>>> + fan-1 { >>>>> + tach-ch = /bits/ 8 <0x1 0x2>; >>>>> + }; >>> >>>> NAK on this based on how you are using pwm-fan in v10 discussion. See my >>>> comments there. >>> >>> Okay, I will merge everything from the pwm-fan0 node into the fan-0 node >>> and add the 'simple-bus' to the compatible string of the pwm_tach node. > >> What simple-bus has anything to do with it? This is not a bus. Just to >> remind: we talk about bindings, not driver. > > Hi Krzysztof, > > If I want to create a dt-binding to indicate that the child nodes > should be treated as platform devices, which will be probed based on the probed? Bindings do not probe. You ignored: "we talk about bindings, not driver." > compatible string, can I add "simple-bus" for our pwm_tach node like the > following? No, because this is not a bus. > pwm_tach: pwm-tach-controller@1e610000 { > compatible = "aspeed,ast2600-pwm-tach", "simple-bus"; > reg = <0x1e610000 0x100>; > clocks = <&syscon ASPEED_CLK_AHB>; > resets = <&syscon ASPEED_RESET_PWM>; > #pwm-cells = <3>; > > fan-0 { > tach-ch = /bits/ 8 <0x0>; > compatible = "pwm-fan"; > pwms = <&pwm_tach 0 40000 0>; > }; > > fan-1 { > tach-ch = /bits/ 8 <0x1 0x2>; > compatible = "pwm-fan"; > pwms = <&pwm_tach 1 40000 0>; > }; > }; > Or do you have any other suggestions for describing this in the dt-bindings? There is no need to describe it in the bindings. The existing compatible describes it sufficiently. Your pwms now duplicate the tach-ch... I don't understand what you want to achieve here in terms of hardware description (again, please steer away from talking about Linux drivers and probing, it's not related). Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel