From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1D2BC61DA4 for ; Mon, 13 Mar 2023 17:19:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WVg1237Kt2VHvzrPzidaFS+MY5Ir6Bi2WXfGG9TF724=; b=m/P+ed4ZwjGMUH y37zXKDCEWqrCvjGJBq0RiVG30HEyYSCmX2g9MuC8qHaRCVNndvboAqpMBdIzinYQ9pYvxHRp9ODz 4cFkUGy7KkGuH+PpXb/GNs9F4utm8GmDnHOoxHb3FR+3/haXyQigV+8wwZUbYievandZmrfWCjdOk gqx6eS3SGjl34aGPFyuW/82ktztGFrNMx4kiExp1PcW6Z12PD0dy6CD3C9ePUTqtQNGhxF8TQVAHF E0k+Vd5osxnbgpa61r7VRDk4Ddz/8o/B8ccysnyo8GKrlAGr96slNIHbbBfrgpTUhJWauwrip54sQ oV6ABxvhRHkf/LIlsUxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbloZ-0072mO-0U; Mon, 13 Mar 2023 17:18:27 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pblh2-006zfz-7l for linux-arm-kernel@lists.infradead.org; Mon, 13 Mar 2023 17:10:41 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 32DHAUDP001571; Mon, 13 Mar 2023 12:10:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1678727430; bh=9bLRawV7JpSTjU6bheC0tqfSEaV8MxNXsheeotQAqPw=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=x1za+trDOmJje1m3EqHNoK/P6o0wsjlbORfpmbeKrIL9PI8xcRt8C/+uCgLNlUMoQ ztMP/vek+hM3gc0xOaz9LXMv6hxWjrdKmpxFaiVHIeacIREj1Pqlo69mkZ2byXdhMM MjiLF3ewWplgXmrnx3PTymQTvfkcvHUtANMGcJRE= Received: from DFLE112.ent.ti.com (dfle112.ent.ti.com [10.64.6.33]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 32DHATRV004081 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 13 Mar 2023 12:10:29 -0500 Received: from DFLE103.ent.ti.com (10.64.6.24) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Mon, 13 Mar 2023 12:10:28 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Mon, 13 Mar 2023 12:10:28 -0500 Received: from [10.250.32.223] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 32DHARMa124516; Mon, 13 Mar 2023 12:10:28 -0500 Message-ID: Date: Mon, 13 Mar 2023 12:10:27 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v5 2/6] arm64: dts: ti: k3-am62-main: Add McASP nodes To: Jai Luthra , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Catalin Marinas , Will Deacon , Mark Brown CC: , , , Jayesh Choudhary References: <20230313-mcasp_upstream-v5-0-d6844707aa8a@ti.com> <20230313-mcasp_upstream-v5-2-d6844707aa8a@ti.com> Content-Language: en-US From: Andrew Davis In-Reply-To: <20230313-mcasp_upstream-v5-2-d6844707aa8a@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230313_101040_420115_DFA5D88D X-CRM114-Status: GOOD ( 15.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/13/23 9:49 AM, Jai Luthra wrote: > From: Jayesh Choudhary > > Add the nodes for McASP 0-2. > > Use the audio-friendly 96MHz main_1_hsdivout6_clk as clock parent > instead of the default 100Mhz main_2_hsdivout8_clk source. > > Signed-off-by: Jayesh Choudhary > Signed-off-by: Jai Luthra > --- > arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 60 ++++++++++++++++++++++++++++++++ > 1 file changed, 60 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi > index ea683fd77d6a..4da5747987bb 100644 > --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi > @@ -787,4 +787,64 @@ epwm2: pwm@23020000 { > clock-names = "tbclk", "fck"; > status = "disabled"; > }; > + > + mcasp0: mcasp@2b00000 { I wonder if we want to switch to generic node naming here, audio-controller@.. > + compatible = "ti,am33xx-mcasp-audio"; > + reg = <0x00 0x02b00000 0x00 0x2000>, > + <0x00 0x02b08000 0x00 0x400>; > + reg-names = "mpu","dat"; Space after , > + interrupts = , > + ; Align with space, indent with tab, as you did with "reg" property. Same for McASP 1/2. Reviewed-by: Andrew Davis > + interrupt-names = "tx", "rx"; > + > + dmas = <&main_bcdma 0 0xc500 0>, <&main_bcdma 0 0x4500 0>; > + dma-names = "tx", "rx"; > + > + clocks = <&k3_clks 190 0>; > + clock-names = "fck"; > + assigned-clocks = <&k3_clks 190 0>; > + assigned-clock-parents = <&k3_clks 190 2>; > + power-domains = <&k3_pds 190 TI_SCI_PD_EXCLUSIVE>; > + status = "disabled"; > + }; > + > + mcasp1: mcasp@2b10000 { > + compatible = "ti,am33xx-mcasp-audio"; > + reg = <0x00 0x02b10000 0x00 0x2000>, > + <0x00 0x02b18000 0x00 0x400>; > + reg-names = "mpu","dat"; > + interrupts = , > + ; > + interrupt-names = "tx", "rx"; > + > + dmas = <&main_bcdma 0 0xc501 0>, <&main_bcdma 0 0x4501 0>; > + dma-names = "tx", "rx"; > + > + clocks = <&k3_clks 191 0>; > + clock-names = "fck"; > + assigned-clocks = <&k3_clks 191 0>; > + assigned-clock-parents = <&k3_clks 191 2>; > + power-domains = <&k3_pds 191 TI_SCI_PD_EXCLUSIVE>; > + status = "disabled"; > + }; > + > + mcasp2: mcasp@2b20000 { > + compatible = "ti,am33xx-mcasp-audio"; > + reg = <0x00 0x02b20000 0x00 0x2000>, > + <0x00 0x02b28000 0x00 0x400>; > + reg-names = "mpu","dat"; > + interrupts = , > + ; > + interrupt-names = "tx", "rx"; > + > + dmas = <&main_bcdma 0 0xc502 0>, <&main_bcdma 0 0x4502 0>; > + dma-names = "tx", "rx"; > + > + clocks = <&k3_clks 192 0>; > + clock-names = "fck"; > + assigned-clocks = <&k3_clks 192 0>; > + assigned-clock-parents = <&k3_clks 192 2>; > + power-domains = <&k3_pds 192 TI_SCI_PD_EXCLUSIVE>; > + status = "disabled"; > + }; > }; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel