From: Neil Armstrong <neil.armstrong@linaro.org>
To: Arseniy Krasnov <AVKrasnov@sberdevices.ru>,
Liang Yang <liang.yang@amlogic.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel@sberdevices.ru, oxffffaa@gmail.com
Subject: Re: [PATCH v3] mtd: rawnand: meson: initialize struct with zeroes
Date: Mon, 27 Feb 2023 11:07:08 +0100 [thread overview]
Message-ID: <c4803c08-c74e-ed04-3f21-aa63e6c2e734@linaro.org> (raw)
In-Reply-To: <20230227095906.754178-1-AVKrasnov@sberdevices.ru>
On 27/02/2023 10:59, Arseniy Krasnov wrote:
> This structure must be zeroed, because it's field 'hw->core' is used as
> 'parent' in 'clk_core_fill_parent_index()', but it will be uninitialized.
> This happens, because when this struct is not zeroed, pointer 'hw' is
> "initialized" by garbage, which is valid pointer, but points to some
> garbage. So 'hw' will be dereferenced, but 'core' contains some random
> data which will be interpreted as a pointer. The following backtrace is
> result of dereference of such pointer:
>
> [ 1.081319] __clk_register+0x414/0x820
> [ 1.085113] devm_clk_register+0x64/0xd0
> [ 1.088995] meson_nfc_probe+0x258/0x6ec
> [ 1.092875] platform_probe+0x70/0xf0
> [ 1.096498] really_probe+0xc8/0x3e0
> [ 1.100034] __driver_probe_device+0x84/0x190
> [ 1.104346] driver_probe_device+0x44/0x120
> [ 1.108487] __driver_attach+0xb4/0x220
> [ 1.112282] bus_for_each_dev+0x78/0xd0
> [ 1.116077] driver_attach+0x2c/0x40
> [ 1.119613] bus_add_driver+0x184/0x240
> [ 1.123408] driver_register+0x80/0x140
> [ 1.127203] __platform_driver_register+0x30/0x40
> [ 1.131860] meson_nfc_driver_init+0x24/0x30
>
> Fixes: 1e4d3ba66888 ("mtd: rawnand: meson: fix the clock")
> Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> drivers/mtd/nand/raw/meson_nand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
> index 5ee01231ac4c..30e326adabfc 100644
> --- a/drivers/mtd/nand/raw/meson_nand.c
> +++ b/drivers/mtd/nand/raw/meson_nand.c
> @@ -991,7 +991,7 @@ static const struct mtd_ooblayout_ops meson_ooblayout_ops = {
>
> static int meson_nfc_clk_init(struct meson_nfc *nfc)
> {
> - struct clk_parent_data nfc_divider_parent_data[1];
> + struct clk_parent_data nfc_divider_parent_data[1] = {0};
> struct clk_init_data init = {0};
> int ret;
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-27 10:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 9:59 [PATCH v3] mtd: rawnand: meson: initialize struct with zeroes Arseniy Krasnov
2023-02-27 10:07 ` Neil Armstrong [this message]
2023-02-27 10:19 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4803c08-c74e-ed04-3f21-aa63e6c2e734@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=AVKrasnov@sberdevices.ru \
--cc=jbrunet@baylibre.com \
--cc=kernel@sberdevices.ru \
--cc=khilman@baylibre.com \
--cc=liang.yang@amlogic.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=miquel.raynal@bootlin.com \
--cc=oxffffaa@gmail.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).