From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rikard Falkeborn <rikard.falkeborn@gmail.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: "Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Andreas Färber" <afaerber@suse.de>,
"Manivannan Sadhasivam" <mani@kernel.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-actions@lists.infradead.org,
"Kuninori Morimoto" <kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH] ASoC: samsung: Constify snd_soc_dapm_{route,widget} structs
Date: Fri, 1 Apr 2022 18:02:03 +0200 [thread overview]
Message-ID: <c4b1e34f-453c-11b6-c083-2e5a638e8db1@linaro.org> (raw)
In-Reply-To: <20220330204227.25081-1-rikard.falkeborn@gmail.com>
On 30/03/2022 22:42, Rikard Falkeborn wrote:
> These structs only have their address assigned to the
> dapm_{routes,widget} fields in the snd_soc_card struct,
> both which are pointers to const data. Make them const to
> allow the compiler to put them in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> ---
> sound/soc/samsung/bells.c | 4 ++--
> sound/soc/samsung/littlemill.c | 4 ++--
> sound/soc/samsung/lowland.c | 4 ++--
> sound/soc/samsung/speyside.c | 4 ++--
> sound/soc/samsung/tobermory.c | 4 ++--
> 5 files changed, 10 insertions(+), 10 deletions(-)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-01 16:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 20:42 [PATCH] ASoC: samsung: Constify snd_soc_dapm_{route,widget} structs Rikard Falkeborn
2022-04-01 16:02 ` Krzysztof Kozlowski [this message]
2022-04-05 9:31 ` [PATCH] ASoC: samsung: Constify snd_soc_dapm_{route, widget} structs Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4b1e34f-453c-11b6-c083-2e5a638e8db1@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=afaerber@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=perex@perex.cz \
--cc=rikard.falkeborn@gmail.com \
--cc=s.nawrocki@samsung.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).