From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11E29C76195 for ; Mon, 22 Jul 2019 05:48:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E29DF2229C for ; Mon, 22 Jul 2019 05:48:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="klJfCuGJ"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="DUPqdpqH"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="YP4q1pfw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E29DF2229C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gNcHaqjijL9kfP/KjMncoXEt7cFyUyaAG31i58js6bk=; b=klJfCuGJKzZlHyiCFZ9VsTrQW g2/hoG2Y75MZMITA+0OnoQ8mpjPOux22XazR0Bds6YRxgthJEuyTKgHvSTzsW+b63jEwmEWsoVtvY Uq5A6Anz+B0efeykr0v+y8FyTFaS2MiSbvo6zWm10a3GcCL8FA9L/D5TGJFVMQvokJPO11bhNg9si iQDva8UHPB/FSVe92BbZBndkrj3PsvoAMTKP6g5GqMKpdjIkc2XZ4WsjBs46AU8TXa5y2XKM67nya 5j6M4aEq4uwk1M09qc44jmeIKLKaYkk3ca6ixuJH+3+JpBf9edSkcGnkgOct5UoKt8OHnMd5jab7J wokjQVm8g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hpRBX-00024d-At; Mon, 22 Jul 2019 05:48:31 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hpRBT-000243-8U for linux-arm-kernel@lists.infradead.org; Mon, 22 Jul 2019 05:48:28 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id EA3226043F; Mon, 22 Jul 2019 05:48:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1563774505; bh=NU8ZN7RCXpkbFXfaEAk2r5vNN1g36wgevgLSQbO3cMg=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=DUPqdpqHSez5/9W87NvayAgZoVD3m2KHAntBw1WYbxdQNTGA6rnXbgrRSpHKtdV9g MpMhMvpCBjqFoSAPGb4Gxy5zI+xlOwQiDDEvxrLxxYQhZ/LnTmxyOPAeGR0SzJe22T DbXogCmYG+M41DPNSw8bayd1C0B1COZIh+64R+5k= Received: from [10.79.136.27] (blr-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.18.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3DDCD6043F; Mon, 22 Jul 2019 05:48:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1563774504; bh=NU8ZN7RCXpkbFXfaEAk2r5vNN1g36wgevgLSQbO3cMg=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=YP4q1pfw79TVf26gWKKYcYUgfHkh3h80Qms6HqnKL12k8BlVHza26unX+PgIxko/m RxMdb4W26v1FDTcACBXBOFbx8FzBBuC+72DU9zV8zz5D8sC2m6SLraPzjSuuoE87WI ZkeOUI637eQPbvzYfxxTLon7MORl/MpeVplNWw98= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3DDCD6043F Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=saiprakash.ranjan@codeaurora.org Subject: Re: [PATCHv8 5/5] coresight: cpu-debug: Add support for Qualcomm Kryo To: Leo Yan , Mathieu Poirier References: <20190717165602.GA4271@xps15> <20190721143553.GA25136@leoy-ThinkPad-X240s> From: Sai Prakash Ranjan Message-ID: Date: Mon, 22 Jul 2019 11:18:18 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190721143553.GA25136@leoy-ThinkPad-X240s> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190721_224827_342700_D2F9B55D X-CRM114-Status: GOOD ( 22.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Rajendra Nayak , Suzuki K Poulose , Alexander Shishkin , Greg Kroah-Hartman , Marc Gonzalez , linux-kernel@vger.kernel.org, Bjorn Andersson , David Brown , Rob Herring , Sibi Sankar , Vivek Gautam , linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Mike Leach Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/21/2019 8:05 PM, Leo Yan wrote: > On Wed, Jul 17, 2019 at 10:56:02AM -0600, Mathieu Poirier wrote: >> On Fri, Jul 12, 2019 at 07:46:27PM +0530, Sai Prakash Ranjan wrote: >>> Add support for coresight CPU debug module on Qualcomm >>> Kryo CPUs. This patch adds the UCI entries for Kryo CPUs >>> found on MSM8996 which shares the same PIDs as ETMs. >>> >>> Without this, below error is observed on MSM8996: >>> >>> [ 5.429867] OF: graph: no port node found in /soc/debug@3810000 >>> [ 5.429938] coresight-etm4x: probe of 3810000.debug failed with error -22 >>> [ 5.435415] coresight-cpu-debug 3810000.debug: Coresight debug-CPU0 initialized >>> [ 5.446474] OF: graph: no port node found in /soc/debug@3910000 >>> [ 5.448927] coresight-etm4x: probe of 3910000.debug failed with error -22 >>> [ 5.454681] coresight-cpu-debug 3910000.debug: Coresight debug-CPU1 initialized >>> [ 5.487765] OF: graph: no port node found in /soc/debug@3a10000 >>> [ 5.488007] coresight-etm4x: probe of 3a10000.debug failed with error -22 >>> [ 5.493024] coresight-cpu-debug 3a10000.debug: Coresight debug-CPU2 initialized >>> [ 5.501802] OF: graph: no port node found in /soc/debug@3b10000 >>> [ 5.512901] coresight-etm4x: probe of 3b10000.debug failed with error -22 >>> [ 5.513192] coresight-cpu-debug 3b10000.debug: Coresight debug-CPU3 initialized >>> >>> Signed-off-by: Sai Prakash Ranjan >>> --- >>> .../hwtracing/coresight/coresight-cpu-debug.c | 33 +++++++++---------- >>> drivers/hwtracing/coresight/coresight-priv.h | 10 +++--- >>> 2 files changed, 21 insertions(+), 22 deletions(-) >>> >>> diff --git a/drivers/hwtracing/coresight/coresight-cpu-debug.c b/drivers/hwtracing/coresight/coresight-cpu-debug.c >>> index 2463aa7ab4f6..96544b348c27 100644 >>> --- a/drivers/hwtracing/coresight/coresight-cpu-debug.c >>> +++ b/drivers/hwtracing/coresight/coresight-cpu-debug.c >>> @@ -646,24 +646,23 @@ static int debug_remove(struct amba_device *adev) >>> return 0; >>> } >>> >>> +static const struct amba_cs_uci_id uci_id_debug[] = { >>> + { >>> + /* CPU Debug UCI data */ >>> + .devarch = 0x47706a15, >>> + .devarch_mask = 0xfff0ffff, >>> + .devtype = 0x00000015, >>> + } >>> +}; >>> + >>> static const struct amba_id debug_ids[] = { >>> - { /* Debug for Cortex-A53 */ >>> - .id = 0x000bbd03, >>> - .mask = 0x000fffff, >>> - }, >>> - { /* Debug for Cortex-A57 */ >>> - .id = 0x000bbd07, >>> - .mask = 0x000fffff, >>> - }, >>> - { /* Debug for Cortex-A72 */ >>> - .id = 0x000bbd08, >>> - .mask = 0x000fffff, >>> - }, >>> - { /* Debug for Cortex-A73 */ >>> - .id = 0x000bbd09, >>> - .mask = 0x000fffff, >>> - }, >>> - { 0, 0 }, >>> + CS_AMBA_ID(0x000bbd03), /* Cortex-A53 */ >>> + CS_AMBA_ID(0x000bbd07), /* Cortex-A57 */ >>> + CS_AMBA_ID(0x000bbd08), /* Cortex-A72 */ >>> + CS_AMBA_ID(0x000bbd09), /* Cortex-A73 */ >>> + CS_AMBA_UCI_ID(0x000f0205, uci_id_debug), /* Qualcomm Kryo */ >>> + CS_AMBA_UCI_ID(0x000f0211, uci_id_debug), /* Qualcomm Kryo */ >>> + {}, >>> }; >>> >>> static struct amba_driver debug_driver = { >>> diff --git a/drivers/hwtracing/coresight/coresight-priv.h b/drivers/hwtracing/coresight/coresight-priv.h >>> index 7d401790dd7e..41ae5863104d 100644 >>> --- a/drivers/hwtracing/coresight/coresight-priv.h >>> +++ b/drivers/hwtracing/coresight/coresight-priv.h >>> @@ -185,11 +185,11 @@ static inline int etm_writel_cp14(u32 off, u32 val) { return 0; } >>> } >>> >>> /* coresight AMBA ID, full UCI structure: id table entry. */ >>> -#define CS_AMBA_UCI_ID(pid, uci_ptr) \ >>> - { \ >>> - .id = pid, \ >>> - .mask = 0x000fffff, \ >>> - .data = uci_ptr \ >>> +#define CS_AMBA_UCI_ID(pid, uci_ptr) \ >>> + { \ >>> + .id = pid, \ >>> + .mask = 0x000fffff, \ >>> + .data = (void *)uci_ptr \ >>> } >> >> I will pickup this patch - it will show up in my next tree when rc1 comes out. > > I tested this patch on the mainline kernel with latest commit > f1a3b43cc1f5 ("Merge branch 'for-linus' of > git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input"). FWIW: > > Tested-by: Leo Yan > > P.s. Acutally I tested this patch for 5.2-rcx a few days ago and found > a regression for CPU debug module: I observed the CPU debug module > panic dump will stuck. After I pulled to latest kernel code base the > CPU debug module can work well; also works well with this patch. F.Y.I. > Thanks Leo. -Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel