From mboxrd@z Thu Jan 1 00:00:00 1970 From: m.szyprowski@samsung.com (Marek Szyprowski) Date: Tue, 21 Feb 2017 14:49:34 +0100 Subject: [PATCH -next v2] pinctrl: samsung: Fix return value check in samsung_pinctrl_get_soc_data() In-Reply-To: References: <20170125140321.23911-1-weiyj.lk@gmail.com> <20170205155849.4362-1-weiyj.lk@gmail.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi All, On 2017-02-13 15:49, Linus Walleij wrote: > On Sun, Feb 5, 2017 at 4:58 PM, Wei Yongjun wrote: > >> From: Wei Yongjun >> >> In case of error, the function devm_ioremap() returns NULL pointer not >> ERR_PTR(). Fix by using devm_ioremap_resource instead of devm_ioremap. >> >> Fixes: 8b1bd11c1f8f ("pinctrl: samsung: Add the support the multiple >> IORESOURCE_MEM for one pin-bank") >> Signed-off-by: Wei Yongjun >> --- >> v1 -> v2: use devm_ioremap_resource instead of devm_ioremap > Patch applied with Krzysztof's ACK. Sadly this patch breaks support for IMEM pinctrl block on Exynos5433/TM2 and it took us some time to find the source of the problem. devm_ioremap_resource() is not functionally a full equivalent of devm_ioremap(). The problem here is that registers for IMEM and ALIVE pin controllers are shared and both devices have <0x11090000 0x1000> range in their reg property. devm_ioremap_resource() maps given resource exclusively for the device, while devm_ioremap() allows non-exclusive mappings. This patch has to be reverted asap. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland