Re: [PATCH v4 30/39] power: reset: at91-poweroff: lookup for proper pmc dt node for sam9x7

From: claudiu beznea <claudiu.beznea@tuxon.dev>
To: Varshini Rajendran <varshini.rajendran@microchip.com>,
	sre@kernel.org, nicolas.ferre@microchip.com,
	alexandre.belloni@bootlin.com, linux-pm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Sebastian Reichel <sebastian.reichel@collabora.com>
Subject: Re: [PATCH v4 30/39] power: reset: at91-poweroff: lookup for proper pmc dt node for sam9x7
Date: Sun, 3 Mar 2024 14:22:40 +0200	[thread overview]
Message-ID: <c4e00fb5-3124-4b2d-a096-11f6e5b86758@tuxon.dev> (raw)
In-Reply-To: <20240223172920.673110-1-varshini.rajendran@microchip.com>

On 23.02.2024 19:29, Varshini Rajendran wrote:
> Use sam9x7 pmc's compatible to lookup for in the SHDWC driver.
> 
> Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
> Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
> Changes in v4:
> - Updated Acked-by tag
> ---
>  drivers/power/reset/at91-sama5d2_shdwc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/power/reset/at91-sama5d2_shdwc.c b/drivers/power/reset/at91-sama5d2_shdwc.c
> index 959ce0dbe91d..2121d7e74e12 100644
> --- a/drivers/power/reset/at91-sama5d2_shdwc.c
> +++ b/drivers/power/reset/at91-sama5d2_shdwc.c
> @@ -326,6 +326,7 @@ static const struct of_device_id at91_pmc_ids[] = {
>  	{ .compatible = "atmel,sama5d2-pmc" },
>  	{ .compatible = "microchip,sam9x60-pmc" },
>  	{ .compatible = "microchip,sama7g5-pmc" },
> +	{ .compatible = "microchip,sam9x7-pmc" },

Maybe would be better to add a phandle in DT instead of continuing
populating this array. But then the backward compatibility should be
preserved. I leave this to Sebastian.

>  	{ /* Sentinel. */ }
>  };
>  

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel