public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Stefan Wahren <stefan.wahren@i2se.com>
To: Richard Schleich <rs@noreya.tech>,
	robh+dt@kernel.org, nsaenz@kernel.org,  f.fainelli@gmail.com,
	bcm-kernel-feedback-list@broadcom.com,
	devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: bcm2711: Fix comment
Date: Sun, 6 Feb 2022 13:55:46 +0100	[thread overview]
Message-ID: <c4e11d53-67af-1a51-9765-2ae16dc1372f@i2se.com> (raw)
In-Reply-To: <20220205195802.52449-1-rs@noreya.tech>

Hi Richard,

the subject of this patch is too general. Here is my suggestion:

ARM: dts: bcm2711: Fix comment about L2 cache set calculation

But maybe you have a better idea.

Am 05.02.22 um 20:58 schrieb Richard Schleich:
> No functional change.

Please write a simple sentence, explaining why this change is necessary.

Thanks

>
> Signed-off-by: Richard Schleich <rs@noreya.tech>
> ---
>  arch/arm/boot/dts/bcm2711.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi
> index d9f31873e711..0f2f26dc5ec6 100644
> --- a/arch/arm/boot/dts/bcm2711.dtsi
> +++ b/arch/arm/boot/dts/bcm2711.dtsi
> @@ -536,7 +536,7 @@ l2: l2-cache0 {
>  			compatible = "cache";
>  			cache-size = <0x100000>;
>  			cache-line-size = <64>;
> -			cache-sets = <1024>; // 1MiB(size)/64(line-size)=16000ways/16-way set
> +			cache-sets = <1024>; // 1MiB(size)/64(line-size)=16384ways/16-way set
>  			cache-level = <2>;
>  		};
>  	};

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-02-06 12:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-05 19:58 [PATCH] ARM: dts: bcm2711: Fix comment Richard Schleich
2022-02-06 12:55 ` Stefan Wahren [this message]
2022-02-11 22:23 ` Florian Fainelli
2022-02-11 22:24   ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c4e11d53-67af-1a51-9765-2ae16dc1372f@i2se.com \
    --to=stefan.wahren@i2se.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=nsaenz@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=rs@noreya.tech \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox