From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E87ACC4363D for ; Wed, 21 Oct 2020 02:49:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 67BCB22240 for ; Wed, 21 Oct 2020 02:49:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TqIMxUCZ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lVG67OeM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 67BCB22240 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wyBYoC8k+ppl7YE3huOMHeYHseuPPT3Jq0OvqICq1aI=; b=TqIMxUCZHc/KzB/yVoeq4/XVr D0dTdJCmCxy804Fc+xnu8enkF3ZAj9Uj39wDdPwjnDCZPUUWf6R4BY0LT7dcSk5lAajmdK29maFmS cl7FcUtvaOqJuowheFInYLGHXn1VzrxGYlY4KCUGucYb9B7S0r1SK/GbqCP399SBN40IRjCJNOaDR ZcooNhWy4gGIPs0KpZUttvkx96YtKR5BcIOFfMFyagbhGeMKJIo/wEadxHfJC0EsLtqz6TTbyvVhk vPHUc9CmKxVz6i7grPP0MVcdCj5rJHB1v4ayaQZEQohhG/kP+81Zz8jV3mfbAGge3V4cYEVpXJp3O oZqzYp1NQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kV4A1-0004gX-Ll; Wed, 21 Oct 2020 02:47:33 +0000 Received: from mail-qv1-xf42.google.com ([2607:f8b0:4864:20::f42]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kV49z-0004g0-8u for linux-arm-kernel@lists.infradead.org; Wed, 21 Oct 2020 02:47:31 +0000 Received: by mail-qv1-xf42.google.com with SMTP id h11so355920qvq.7 for ; Tue, 20 Oct 2020 19:47:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=v3ZIEdHQfLLzm/P+Ct5cHY1Me2E++bPihPMu41U8QkQ=; b=lVG67OeM3b+nj7K6KFzb0Xrbv8PbURCAuhsrtKalBDGFc9UTug3iBPbA3MgE685Hvt uUujA0knDqIl+3Q6yb+JkvpWVyVdtxfygSdcdHzhFkUO5ipUGda/rYm6Ly7COWFyGGs2 vjopCoh8vla81UsSbQKBvgEsG/KZNFWTl/JMlY5qYW2JSMFrdi5HvjtZlyLjPYyhzeBf SN/uJse5OxB+7HwuDo1R2IlY5wFTHSxQX79lXOU4UF/PQIZcN8mKVX5uWcflhq5vj72N 5rXk4l0GL6nHlOY5oN9Tu4ZgEUnhlm+k2b5kRnZuA2VXSmrJQkVAkaUTymVX1RjYV/t/ Z1YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=v3ZIEdHQfLLzm/P+Ct5cHY1Me2E++bPihPMu41U8QkQ=; b=In9EzwduahoZ814NDL+H9AvColntaAXt7eggATUuS9a/IKT3k6FbAw/TO0hMqjxp4i G3Xm+Kxav6vqvTaOLiyyTlrTufDsRZV6sdh9gZuqowzme1dIcBbrfTSOuJUA7Kp99OE/ D3MaDfzQuFBAKfNHGFjIN4fxClvX6yXIjgFt0PoZ0Ish9v37S9tQ66GgKbglEInn/ePw 43D9y2kJtRiIilgD9SdvNAWbqLqsLj3lRGRN1d2V/OBdXTVI6z8LXcnauq6+fi4INrhO VlYeTHJCBI2OkjtO/sXyPQfSfPmuy2U9el8f530Yd1FqlHGp2P/ZNJmw+X5wL5AB+28U Kfeg== X-Gm-Message-State: AOAM532MS5eZX4mLaOkdPgy7aDwpQpBn6GeQOwdHVhIfWGG/dNqxoSmI lxmfbOWCeNvx3MQFms9GULcWKA== X-Google-Smtp-Source: ABdhPJzNK7DzVtnNIc41sKBtvkoG8AgJ09aUkLnLngPzRVYf1huGu8anNgPJNWPswnYUsy5tcIex8w== X-Received: by 2002:a0c:b741:: with SMTP id q1mr929362qve.37.1603248449608; Tue, 20 Oct 2020 19:47:29 -0700 (PDT) Received: from [192.168.1.93] (pool-71-163-245-5.washdc.fios.verizon.net. [71.163.245.5]) by smtp.gmail.com with ESMTPSA id h4sm424193qtq.41.2020.10.20.19.47.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Oct 2020 19:47:29 -0700 (PDT) Subject: Re: [PATCH 06/11] firmware: arm_scmi: add support for protocol modularization To: Cristian Marussi , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20201014150545.44807-1-cristian.marussi@arm.com> <20201014150545.44807-7-cristian.marussi@arm.com> From: Thara Gopinath Message-ID: Date: Tue, 20 Oct 2020 22:47:28 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201014150545.44807-7-cristian.marussi@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201020_224731_328101_FE583F32 X-CRM114-Status: GOOD ( 18.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: f.fainelli@gmail.com, vincent.guittot@linaro.org, sudeep.holla@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, souvik.chakravarty@arm.com, etienne.carriere@linaro.org, lukasz.luba@arm.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/14/20 11:05 AM, Cristian Marussi wrote: > Modify protocol initialization callback adding a new parameter representing > a reference to the available xfer core operations and introduce a macro to > simply register with the core new protocols as loadable drivers. > Keep standard protocols as builtin. > > Signed-off-by: Cristian Marussi > --- > drivers/firmware/arm_scmi/base.c | 56 ++++++++++-------- > drivers/firmware/arm_scmi/bus.c | 14 ++++- > drivers/firmware/arm_scmi/clock.c | 56 +++++++++--------- > drivers/firmware/arm_scmi/common.h | 42 +++++++++----- > drivers/firmware/arm_scmi/driver.c | 50 ++++++++++------ > drivers/firmware/arm_scmi/perf.c | 88 +++++++++++++++-------------- > drivers/firmware/arm_scmi/power.c | 46 ++++++++------- > drivers/firmware/arm_scmi/reset.c | 46 ++++++++------- > drivers/firmware/arm_scmi/sensors.c | 52 +++++++++-------- > drivers/firmware/arm_scmi/system.c | 16 ++++-- > include/linux/scmi_protocol.h | 18 +++++- > 11 files changed, 288 insertions(+), 196 deletions(-) > > diff --git a/drivers/firmware/arm_scmi/base.c b/drivers/firmware/arm_scmi/base.c > index f40821eeb103..8d7214fd2187 100644 > --- a/drivers/firmware/arm_scmi/base.c > +++ b/drivers/firmware/arm_scmi/base.c > @@ -15,6 +15,8 @@ > #define SCMI_BASE_NUM_SOURCES 1 > #define SCMI_BASE_MAX_CMD_ERR_COUNT 1024 > > +static const struct scmi_xfer_ops *ops; Minor nit. I would consider renaming ops to something more meaningful like xfer_ops (or anything that makes sense). ops by itself leads to confusion with ops in scmo_protocol and in scmi_protocol_events. Same suggestion for all other declarations of ops in this patch. -- Warm Regards Thara _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel