From: "Jianjun Wang (王建军)" <Jianjun.Wang@mediatek.com>
To: "kw@linux.com" <kw@linux.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"kernel@collabora.com" <kernel@collabora.com>,
"manivannan.sadhasivam@linaro.org"
<manivannan.sadhasivam@linaro.org>,
"robh@kernel.org" <robh@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"lpieralisi@kernel.org" <lpieralisi@kernel.org>,
Ryder Lee <Ryder.Lee@mediatek.com>,
"fshao@chromium.org" <fshao@chromium.org>,
"bhelgaas@google.com" <bhelgaas@google.com>
Subject: Re: [PATCH v4 1/2] PCI: mediatek-gen3: Add support for setting max-link-speed limit
Date: Fri, 8 Nov 2024 01:43:44 +0000 [thread overview]
Message-ID: <c5385db34878763ba7df3711a514e4332418cbbd.camel@mediatek.com> (raw)
In-Reply-To: <20241104132512.GC2504924@rocinante>
Hi Krzysztof,
On Mon, 2024-11-04 at 22:25 +0900, Krzysztof Wilczyński wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> Hello,
>
> > > I wonder if this debug message would be better served as a
> > > warning to let
> > > the user know that the speed has been overridden due to the
> > > platform
> > > limitation. Thoughts?
> > >
> > > Also, there is no need to sent a new series if you fine with the
> > > suggestions. I will mend the code on the branch when applying.
> > >
> >
> > A warning seems to be a bit too much and would appear like
> > something to worry
> > about (or something unintended)...
> >
> > Perhaps a dev_info() would work better here?
>
> Sounds good! Thank you!
>
> Will handle the necessary changes while applying the series.
>
> Krzysztof
This patch may need more discussion. I have replied in the previous
version:
https://lore.kernel.org/linux-pci/7e220693f076c84cc1bc3d91e797580b320b4598.camel@mediatek.com/T/#m1b9f2d26a228712b6b9d02eba11d8063862772c1
Should we wait longer before applying this patch? Do you have any
suggestions? I can provide more logs or test results if needed. Sorry
for the inconvenience.
Thanks.
>
next prev parent reply other threads:[~2024-11-08 1:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 11:49 [PATCH v4 0/2] PCI: mediatek-gen3: Support limiting link speed and width AngeloGioacchino Del Regno
2024-11-04 11:49 ` [PATCH v4 1/2] PCI: mediatek-gen3: Add support for setting max-link-speed limit AngeloGioacchino Del Regno
2024-11-04 13:06 ` Krzysztof Wilczyński
2024-11-04 13:10 ` AngeloGioacchino Del Regno
2024-11-04 13:25 ` Krzysztof Wilczyński
2024-11-08 1:43 ` Jianjun Wang (王建军) [this message]
2024-11-11 20:47 ` Krzysztof Wilczyński
2024-11-06 1:22 ` Bjorn Helgaas
2024-11-04 11:49 ` [PATCH v4 2/2] PCI: mediatek-gen3: Add support for restricting link width AngeloGioacchino Del Regno
2024-11-04 13:20 ` Krzysztof Wilczyński
2024-11-06 13:29 ` AngeloGioacchino Del Regno
2024-11-06 14:02 ` Krzysztof Wilczyński
2024-11-06 1:24 ` Bjorn Helgaas
2024-11-06 7:43 ` Jianjun Wang (王建军)
2024-11-04 17:00 ` [PATCH v4 0/2] PCI: mediatek-gen3: Support limiting link speed and width Krzysztof Wilczyński
2024-11-04 17:02 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5385db34878763ba7df3711a514e4332418cbbd.camel@mediatek.com \
--to=jianjun.wang@mediatek.com \
--cc=Ryder.Lee@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bhelgaas@google.com \
--cc=fshao@chromium.org \
--cc=kernel@collabora.com \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox