From: Vladimir Murzin <vladimir.murzin@arm.com>
To: Bradley Morgan <brads@mainlining.org>,
catalin.marinas@arm.com, will@kernel.org
Cc: mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] arm64: entry: drop the unused tmp2 argument of mte_set_kernel_gcr()
Date: Fri, 9 Oct 2026 11:37:45 +0100 [thread overview]
Message-ID: <c53b373b-9f70-42f0-affc-6978f0508b87@arm.com> (raw)
In-Reply-To: <20261007185512.2.mte-tmp2@mainlining.org>
On 10/7/26 18:45, Bradley Morgan wrote:
> mte_set_kernel_gcr() takes a tmp2 argument the macro never uses. It
> used to, the body passed \tmp and \tmp2 to mte_set_gcr, then
> commit 82868247897b ("arm64: kasan: mte: use a constant kernel
> GCR_EL1 value") swapped that for
>
> mov \tmp, KERNEL_GCR_EL1
>
> and tmp2 stayed in the declaration and in the one caller, which
> passes x23 for it.
>
> Drop it, both places.
>
> Signed-off-by: Bradley Morgan <brads@mainlining.org>
> ---
> Resending, the first send's body got mangled.
>
> arch/arm64/kernel/entry.S | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S
> index f63049ac32dc..c3106dee61e1 100644
> --- a/arch/arm64/kernel/entry.S
> +++ b/arch/arm64/kernel/entry.S
> @@ -171,7 +171,7 @@ alternative_else_nop_endif
> #endif
> .endm
>
> - .macro mte_set_kernel_gcr, tmp, tmp2
> + .macro mte_set_kernel_gcr, tmp
> #ifdef CONFIG_KASAN_HW_TAGS
> alternative_cb ARM64_ALWAYS_SYSTEM, kasan_hw_tags_enable
> b 1f
> @@ -258,7 +258,7 @@ alternative_else_nop_endif
>
> apply_ssbd 1, x22, x23
>
> - mte_set_kernel_gcr x22, x23
> + mte_set_kernel_gcr x22
>
> /*
> * Any non-self-synchronizing system register updates required for
> -- 2.53.0
>
Reviewed-by: Vladimir Murzin <vladimir.murzin@arm.com>
prev parent reply other threads:[~2026-10-09 10:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 17:45 [PATCH RESEND] arm64: entry: drop the unused tmp2 argument of mte_set_kernel_gcr() Bradley Morgan
2026-10-09 10:37 ` Vladimir Murzin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c53b373b-9f70-42f0-affc-6978f0508b87@arm.com \
--to=vladimir.murzin@arm.com \
--cc=brads@mainlining.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox